Bug#861168: qa.debian.org: msg parameter inserts extra line numbers
Hi, On Tue, Apr 25, 2017 at 01:49:13PM -0400, James McCoy wrote: > When I view that URL, it looks as per your expectations. After > disabling Javascript, I see that the line numbers aren't adjusted. Thanks for the report and the additional information! I've dug it a bit, and it indeed comes from the fact the additional space needed between line numbers to align well (when a popup message is present) is done in javascript in debsources.js. A solution could be adding these empty lines server-side. It was the case before e246fcf, but it was needed to fix #762941… Cheers, -- Matthieu signature.asc Description: PGP signature
Bug#861168: qa.debian.org: msg parameter inserts extra line numbers
Control: retitle -1 [debsources] msg parameter displays extra line numbers when Javascript is disabled Control: tag -1 confirmed On Tue, Apr 25, 2017 at 05:57:48PM +0800, Paul Wise wrote: > Normally the cowsay code header looks like this: > > https://sources.debian.net/src/cowsay/3.03%2Bdfsg2-3/cowsay > > 1 #!/usr/bin/perl > 2 > 3 ## > 4 ## Cowsay 3.03 > 5 ## > 6 ## This file is part of cowsay. (c) 1999-2000 Tony Monroe. > 7 ## > > When I add a msg parameter it looks like this: Like this: https://sources.debian.net/src/cowsay/3.03%2Bdfsg2-3/cowsay/?msg=4:title:message > 1 #!/usr/bin/perl > 2 > 3 ## > 4 ## Cowsay 3.03 > 5 > 6 title > 7 text > 8 > 9 ## > 10 ## This file is part of cowsay. (c) 1999-2000 Tony Monroe. > 11 ## > > I didn't expect that the msg paramer would insert line numbers, > I would expect these line numbers instead: > > 1 #!/usr/bin/perl > 2 > 3 ## > 4 ## Cowsay 3.03 > > title > text > > 5 ## > 6 ## This file is part of cowsay. (c) 1999-2000 Tony Monroe. > 7 ## When I view that URL, it looks as per your expectations. After disabling Javascript, I see that the line numbers aren't adjusted. Cheers, James
Bug#861168: qa.debian.org: msg parameter inserts extra line numbers
Package: qa.debian.org Severity: minor Normally the cowsay code header looks like this: https://sources.debian.net/src/cowsay/3.03%2Bdfsg2-3/cowsay 1 #!/usr/bin/perl 2 3 ## 4 ## Cowsay 3.03 5 ## 6 ## This file is part of cowsay. (c) 1999-2000 Tony Monroe. 7 ## When I add a msg parameter it looks like this: 1 #!/usr/bin/perl 2 3 ## 4 ## Cowsay 3.03 5 6 title 7 text 8 9 ## 10 ## This file is part of cowsay. (c) 1999-2000 Tony Monroe. 11 ## I didn't expect that the msg paramer would insert line numbers, I would expect these line numbers instead: 1 #!/usr/bin/perl 2 3 ## 4 ## Cowsay 3.03 title text 5 ## 6 ## This file is part of cowsay. (c) 1999-2000 Tony Monroe. 7 ## -- bye, pabs https://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
