Bug#861379: debsources: /patches/api/list/ contains packages with no patches (such as 0xffff)

2017-04-28 Thread Paul Wise
On Fri, 2017-04-28 at 19:02 +0200, Orestis Ioannou wrote:

> Doing so would enable us to actually know which packages do have
> patches, or better which versions of each package have patches. 

I need an API that can help make these links more like the 4th link by
exporting the amount of patches for each supported package version:

https://packages.qa.debian.org/~pabs/g/glibc.html (want patch counts, 
versions/suites in title attributes)
https://packages.qa.debian.org/~pabs/n/nsis.html (3.0 has no patches, needs 
hiding)
https://packages.qa.debian.org/~pabs/0/0x.html (no version has patches, all 
need hiding, want single version anyway)
https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=779400;filename=distro-tracker-patches-mockup.png;msg=5

For me the ideal data set would be a list of packages with 1 or more
patches, each with the associated suite names, version numbers and
patch counts, or files patched counts for packages that use diff.gz.
I'd prefer if it didn't include patch info for obsolete suites.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise


signature.asc
Description: This is a digitally signed message part


Bug#861379: debsources: /patches/api/list/ contains packages with no patches (such as 0xffff)

2017-04-28 Thread Orestis Ioannou
Hey,


On 04/28/2017 05:38 PM, Paul Wise wrote:
> On Fri, 2017-04-28 at 09:43 +0200, Matthieu Caneill wrote:
> 
>> I'm not sure this is a bug. The /api/list endpoint was meant to list
>> all packages, containing 0 or more patches.
> 
> That doesn't seem to be useful for any use-case I can think of.
> 

Agreed!

>> Orestis, any memory of this rationale?
> 
> That would be interesting to hear.
> 

Well the think is that right now everything happens on the fly (for the
patches). there is/was an effort to implement a plugin (as the ones we
have for counting lines of code, ctags etc) to store patches information
in the database.
Doing so would enable us to actually know which packages do have
patches, or better which versions of each package have patches. till
then it is not feasible to have this kind of information.
Unfortunately this effort is currently stalled due to the fact that i
got a job and my contributions to debsources have dropped considerably.

By june things are looking much better on my end so i hope to resume the
work on this plugins (+ other things i ve been working on)

If anyone is willing to do this in the meantime, then i could push
somewhere the work i've already done (modification for the DB schema,
and i think a prototype of the plugin). in the list archive there should
be a discussion about this as well.

cheers,

Orestis



Bug#861379: debsources: /patches/api/list/ contains packages with no patches (such as 0xffff)

2017-04-28 Thread Paul Wise
On Fri, 2017-04-28 at 09:43 +0200, Matthieu Caneill wrote:

> I'm not sure this is a bug. The /api/list endpoint was meant to list
> all packages, containing 0 or more patches.

That doesn't seem to be useful for any use-case I can think of.

> Orestis, any memory of this rationale?

That would be interesting to hear.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise


signature.asc
Description: This is a digitally signed message part


Bug#861379: debsources: /patches/api/list/ contains packages with no patches (such as 0xffff)

2017-04-28 Thread Matthieu Caneill
Hi,

On Fri, Apr 28, 2017 at 03:30:58PM +0800, Paul Wise wrote:
> The debsources patches list API mentions the package 0x but this
> package doesn't contain any patches according to the debsources website
> and apt-file and downloading the source package.

Thanks for the report.
I'm not sure this is a bug. The /api/list endpoint was meant to list
all packages, containing 0 or more patches.

Orestis, any memory of this rationale?

Cheers,
--
Matthieu


signature.asc
Description: PGP signature


Bug#861379: debsources: /patches/api/list/ contains packages with no patches (such as 0xffff)

2017-04-28 Thread Paul Wise
Package: qa.debian.org
Severity: normal
User: qa.debian@packages.debian.org
Usertags: debsources

The debsources patches list API mentions the package 0x but this
package doesn't contain any patches according to the debsources website
and apt-file and downloading the source package.

https://sources.debian.net/patches/api/list/
https://sources.debian.net/patches/0x/
https://sources.debian.net/patches/0x/0.7-2/

$ apt-file show -I dsc 0x | grep patch
0x: /.pc/.quilt_patches
0x: /.pc/applied-patches
$ apt source -qq 0x
...
$ find 0x* -iname '*patch*'
0x-0.7/.pc/applied-patches
0x-0.7/.pc/.quilt_patches

-- 
bye,
pabs

https://wiki.debian.org/PaulWise


signature.asc
Description: This is a digitally signed message part