Bug#861713: netdata: `service netdata restart` fails due to missing pidfile

[Daniel Ring]

Control: reopen -1
Control: found -1 1.6.0+dfsg-2

This bug is still present in the current version of netdata.

The patch Daniel Piddock provided fixes the start and stop init triggers,
but unfortunately restart is still broken. It looks like the stop trigger
returns before netdata actually shuts down and causes the start trigger
afterward to fail.

Sincerely,
Daniel Ring

Bug#861713: netdata: `service netdata restart` fails due to missing pidfile

[Daniel Piddock]

Control: tags -1 + patch

I also hit this issue.

netdata doesn't store its pid to a file by default. Can be turned on with
the -P flag. Patch for netdata.init attached.

Daniel


init.patch
Description: Binary data

Bug#861713: netdata: `service netdata restart` fails due to missing pidfile

[Daniel Ring]

I use sysvinit (upgraded from wheezy, when it was the default).
The init script that `service` calls is "debian/netdata.init" from the source 
package. Running it directly from init.d has the same effect.

May 3, 2017 6:02 AM, "Lennart Weller"  wrote:

> What init do you use on your system?
> The creation of the pid file should have been done by the init.
> 
> May 3, 2017 5:09 AM, "Daniel Ring"  wrote:
> 
>> Package: netdata
>> Version: 1.5.0+dfsg-4
>> Severity: normal
>> 
>> Dear Maintainer,
>> 
>> The init scripts provided with this package do not seem to work properly.
>> I reported this bug upstream at 
>> https://github.com/firehol/netdata/issues/2135, but the init
>> scripts provided with this package have been modified for Debian so I'm not 
>> sure where the issue
>> first arose.
>> The directory "/var/run/netdata" is not created by default on my system. 
>> Creating it and chowning
>> to netdata:netdata had no effect.
>> 
>> Running `service netdata restart` results in the following output:
>> [ ok ] Stopping the netdata daemon...done (not running - there is no 
>> /var/run/netdata/netdata.pid).
>> [] Starting the netdata daemon...2017-05-02 19:55:59: netdata: ERROR: 
>> IPv4 bind() on ip
>> '127.0.0.1' port 1 failed. (errno 98, Address already in use)
>> 2017-05-02 19:55:59: netdata: ERROR: Cannot bind to ip '127.0.0.1', port 
>> 1
>> 2017-05-02 19:55:59: netdata: FATAL: Cannot listen on any socket. Exiting... 
>> # : Success
>> 
>> 2017-05-02 19:55:59: netdata: INFO: Saving database...
>> 2017-05-02 19:55:59: netdata: INFO: netdata exiting. Bye bye...
>> failed.
>> 
>> Running `service netdata stop` results in the following output:
>> [ ok ] Stopping the netdata daemon...done (not running - there is no 
>> /var/run/netdata/netdata.pid).
>> 
>> A netdata instance is running normally in the background in both cases.
>> Running `service netdata start` works as expected.
>> 
>> -- System Information:
>> Debian Release: 8.7
>> APT prefers stable-updates
>> APT policy: (500, 'stable-updates'), (500, 'stable')
>> Architecture: i386 (i686)
>> 
>> Kernel: Linux 3.16.0-4-686-pae (SMP w/1 CPU core)
>> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
>> Shell: /bin/sh linked to /bin/dash
>> Init: sysvinit (via /sbin/init)
>> 
>> Versions of packages netdata depends on:
>> ii adduser 3.113+nmu3
>> ii init-system-helpers 1.22
>> ii libc6 2.19-18+deb8u7
>> ii libcap2-bin 1:2.24-8
>> ii libuuid1 2.25.2-6
>> ii lsb-base 4.1+Debian13+nmu1
>> ii netdata-data 1.5.0+dfsg-4
>> ii python 2.7.9-1
>> ii python-yaml 3.11-2
>> ii zlib1g 1:1.2.8.dfsg-2+b1
>> 
>> Versions of packages netdata recommends:
>> pn nodejs 
>> 
>> netdata suggests no packages.
>> 
>> -- Configuration Files:
>> /etc/netdata/netdata.conf changed [not included]
>> 
>> -- no debconf information

Bug#861713: netdata: `service netdata restart` fails due to missing pidfile

[Lennart Weller]

What init do you use on your system?
The creation of the pid file should have been done by the init.

May 3, 2017 5:09 AM, "Daniel Ring"  wrote:

> Package: netdata
> Version: 1.5.0+dfsg-4
> Severity: normal
> 
> Dear Maintainer,
> 
> The init scripts provided with this package do not seem to work properly.
> I reported this bug upstream at 
> https://github.com/firehol/netdata/issues/2135, but the init
> scripts provided with this package have been modified for Debian so I'm not 
> sure where the issue
> first arose.
> The directory "/var/run/netdata" is not created by default on my system. 
> Creating it and chowning
> to netdata:netdata had no effect.
> 
> Running `service netdata restart` results in the following output:
> [ ok ] Stopping the netdata daemon...done (not running - there is no 
> /var/run/netdata/netdata.pid).
> [] Starting the netdata daemon...2017-05-02 19:55:59: netdata: ERROR: 
> IPv4 bind() on ip
> '127.0.0.1' port 1 failed. (errno 98, Address already in use)
> 2017-05-02 19:55:59: netdata: ERROR: Cannot bind to ip '127.0.0.1', port 1
> 2017-05-02 19:55:59: netdata: FATAL: Cannot listen on any socket. Exiting... 
> # : Success
> 
> 2017-05-02 19:55:59: netdata: INFO: Saving database...
> 2017-05-02 19:55:59: netdata: INFO: netdata exiting. Bye bye...
> failed.
> 
> Running `service netdata stop` results in the following output:
> [ ok ] Stopping the netdata daemon...done (not running - there is no 
> /var/run/netdata/netdata.pid).
> 
> A netdata instance is running normally in the background in both cases.
> Running `service netdata start` works as expected.
> 
> -- System Information:
> Debian Release: 8.7
> APT prefers stable-updates
> APT policy: (500, 'stable-updates'), (500, 'stable')
> Architecture: i386 (i686)
> 
> Kernel: Linux 3.16.0-4-686-pae (SMP w/1 CPU core)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: sysvinit (via /sbin/init)
> 
> Versions of packages netdata depends on:
> ii adduser 3.113+nmu3
> ii init-system-helpers 1.22
> ii libc6 2.19-18+deb8u7
> ii libcap2-bin 1:2.24-8
> ii libuuid1 2.25.2-6
> ii lsb-base 4.1+Debian13+nmu1
> ii netdata-data 1.5.0+dfsg-4
> ii python 2.7.9-1
> ii python-yaml 3.11-2
> ii zlib1g 1:1.2.8.dfsg-2+b1
> 
> Versions of packages netdata recommends:
> pn nodejs 
> 
> netdata suggests no packages.
> 
> -- Configuration Files:
> /etc/netdata/netdata.conf changed [not included]
> 
> -- no debconf information

Bug#861713: netdata: `service netdata restart` fails due to missing pidfile

[Daniel Ring]

Package: netdata
Version: 1.5.0+dfsg-4
Severity: normal

Dear Maintainer,

The init scripts provided with this package do not seem to work properly.
I reported this bug upstream at https://github.com/firehol/netdata/issues/2135, 
but the init scripts provided with this package have been modified for Debian 
so I'm not sure where the issue first arose.
The directory "/var/run/netdata" is not created by default on my system. 
Creating it and chowning to netdata:netdata had no effect.


Running `service netdata restart` results in the following output:
[ ok ] Stopping the netdata daemon...done (not running - there is no 
/var/run/netdata/netdata.pid).
[] Starting the netdata daemon...2017-05-02 19:55:59: netdata: ERROR: IPv4 
bind() on ip '127.0.0.1' port 1 failed. (errno 98, Address already in use)
2017-05-02 19:55:59: netdata: ERROR: Cannot bind to ip '127.0.0.1', port 1
2017-05-02 19:55:59: netdata: FATAL: Cannot listen on any socket. Exiting... # 
: Success

2017-05-02 19:55:59: netdata: INFO: Saving database...
2017-05-02 19:55:59: netdata: INFO: netdata exiting. Bye bye...
failed.

Running `service netdata stop` results in the following output:
[ ok ] Stopping the netdata daemon...done (not running - there is no 
/var/run/netdata/netdata.pid).


A netdata instance is running normally in the background in both cases.
Running `service netdata start` works as expected.


-- System Information:
Debian Release: 8.7
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 3.16.0-4-686-pae (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages netdata depends on:
ii  adduser  3.113+nmu3
ii  init-system-helpers  1.22
ii  libc62.19-18+deb8u7
ii  libcap2-bin  1:2.24-8
ii  libuuid1 2.25.2-6
ii  lsb-base 4.1+Debian13+nmu1
ii  netdata-data 1.5.0+dfsg-4
ii  python   2.7.9-1
ii  python-yaml  3.11-2
ii  zlib1g   1:1.2.8.dfsg-2+b1

Versions of packages netdata recommends:
pn  nodejs  

netdata suggests no packages.

-- Configuration Files:
/etc/netdata/netdata.conf changed [not included]

-- no debconf information