Bug#862875: RFS: libzc/0.3.1-1 [ITP] -- fast zip cracking library
On Sun, Oct 15, 2017 at 9:12 PM, Adam Borowskiwrote: > > On Fri, Sep 15, 2017 at 10:47:29PM -0400, Marc Ferland wrote: > > On Mon, Sep 11, 2017 at 4:09 PM, Andrey Rahmatullin wrote: > > > d/copyright says "License: GPL-3" instead of GPL-3+. > > > lib/pthread_barrier.h and m4/ax_pthread.m4 should have separate entries in > > > d/copyright. > > > Otherwise the package looks good. > > > > Fixed d/copyright and other warnings reported by 'scan-copyright' with > > latest version: > > > > https://mentors.debian.net/debian/pool/main/libz/libzc/libzc_0.3.5-1.dsc > > The package fails to build on most architectures, with a timeout in the > testsuite: > ... > Running suite(s): reduce > 66%: Checks: 3, Failures: 0, Errors: 1 > check_reduce.c:60:E:Core:test_can_generate_next_array_from_plaintext:0: > (after this point) Test timeout expired > FAIL reduce (exit status: 1) Some tests can take quite some time to finish. I've excluded those from running when doing an 'ordinary' make check. This fix and other small fixes are available in the latest version: https://mentors.debian.net/debian/pool/main/libz/libzc/libzc_0.3.6-1.dsc Regards, Marc
Bug#862875: RFS: libzc/0.3.1-1 [ITP] -- fast zip cracking library
On Fri, Sep 15, 2017 at 10:47:29PM -0400, Marc Ferland wrote: > On Mon, Sep 11, 2017 at 4:09 PM, Andrey Rahmatullinwrote: > > d/copyright says "License: GPL-3" instead of GPL-3+. > > lib/pthread_barrier.h and m4/ax_pthread.m4 should have separate entries in > > d/copyright. > > Otherwise the package looks good. > > Fixed d/copyright and other warnings reported by 'scan-copyright' with > latest version: > > https://mentors.debian.net/debian/pool/main/libz/libzc/libzc_0.3.5-1.dsc The package fails to build on most architectures, with a timeout in the testsuite: PASS: pwstream PASS: file PASS: basic PASS: dictionary PASS: plaintext PASS: plaintext_password FAIL: reduce PASS: bruteforce zc 0.3.5: tests/test-suite.log # TOTAL: 8 # PASS: 7 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: reduce Running suite(s): reduce 66%: Checks: 3, Failures: 0, Errors: 1 check_reduce.c:60:E:Core:test_can_generate_next_array_from_plaintext:0: (after this point) Test timeout expired FAIL reduce (exit status: 1) Testsuite summary for zc 0.3.5 # TOTAL: 8 # PASS: 7 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 -- ⢀⣴⠾⠻⢶⣦⠀ Meow! ⣾⠁⢰⠒⠀⣿⡁ ⢿⡄⠘⠷⠚⠋⠀ I was born a dumb, ugly and work-loving kid, then I got swapped on ⠈⠳⣄ the maternity ward.
Bug#862875: RFS: libzc/0.3.1-1 [ITP] -- fast zip cracking library
On Mon, Sep 11, 2017 at 4:09 PM, Andrey Rahmatullinwrote: > d/copyright says "License: GPL-3" instead of GPL-3+. > lib/pthread_barrier.h and m4/ax_pthread.m4 should have separate entries in > d/copyright. > Otherwise the package looks good. Fixed d/copyright and other warnings reported by 'scan-copyright' with latest version: https://mentors.debian.net/debian/pool/main/libz/libzc/libzc_0.3.5-1.dsc Regards, Marc
Bug#862875: RFS: libzc/0.3.1-1 [ITP] -- fast zip cracking library
On Tuesday, 12 September 2017 01:09:23 CEST Andrey Rahmatullin wrote: > d/copyright says "License: GPL-3" instead of GPL-3+. > lib/pthread_barrier.h and m4/ax_pthread.m4 should have separate entries in > d/copyright. > Otherwise the package looks good. For what it's worth, the issues you reported are not present in the output of scan-copyright (the little brother of 'cme update dpkg-copyright'): Files: * Copyright: 2012-2017, Marc Ferland License: GPL-3+ Files: INSTALL Copyright: 1994-1996, 1999-2002, 2004-2013, Free Software Foundation License: All or FSF or Permissive Files: lib/pthread_barrier.c lib/pthread_barrier.h Copyright: 2015, Aleksey Demakov License: BSD-2-clause Files: lib/qsort.h Copyright: 1991, 1992, 1996, 1997, 1999, Free Software Foundation, Inc. License: LGPL-2.1+ Files: m4/* Copyright: 2011, Daniel Richard G.2008, Steven G. Johnson License: GPL On the other hand, the license reported for INSTALL file is lackluster. This should be fixed by #872350 HTH HTH -- https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/ http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
Bug#862875: RFS: libzc/0.3.1-1 [ITP] -- fast zip cracking library
d/copyright says "License: GPL-3" instead of GPL-3+. lib/pthread_barrier.h and m4/ax_pthread.m4 should have separate entries in d/copyright. Otherwise the package looks good. -- WBR, wRAR signature.asc Description: PGP signature
Bug#862875: RFS: libzc/0.3.1-1 [ITP] -- fast zip cracking library
On Sat, Sep 2, 2017 at 8:43 AM, Andrey Rahmatullinwrote: > > On Fri, Sep 01, 2017 at 09:43:54PM -0400, Marc Ferland wrote: > > > Please switch to the debhelper compat level 10. > Not fixed. My bad. > > > Please update Standards-Version to the current version. > Not fixed. Updated to 4.1.0. Based on https://tracker.debian.org/pkg/debian-policy > Please remove unneeded comments and sample lines from d/rules. > uscan says "Newest version of libzc on remote site is 0.3.2, local version > is 0.3.3". > All .dirs files are not needed. > The package FTBFS in a clean sid chroot. > Please install README.md. Should all be OK now. https://mentors.debian.net/debian/pool/main/libz/libzc/libzc_0.3.4-1.dsc Marc
Bug#862875: RFS: libzc/0.3.1-1 [ITP] -- fast zip cracking library
On Fri, Sep 01, 2017 at 09:43:54PM -0400, Marc Ferland wrote: > > Please switch to the debhelper compat level 10. Not fixed. > > Please update Standards-Version to the current version. Not fixed. Please remove unneeded comments and sample lines from d/rules. uscan says "Newest version of libzc on remote site is 0.3.2, local version is 0.3.3". All .dirs files are not needed. The package FTBFS in a clean sid chroot. Please install README.md. -- WBR, wRAR signature.asc Description: PGP signature
Bug#862875: RFS: libzc/0.3.1-1 [ITP] -- fast zip cracking library
On Mon, Jul 24, 2017 at 3:24 PM, Andrey Rahmatullinwrote: > > Control: tags -1 + moreinfo > > Please either add check to B-D to enable tests or explicitly disable them > in debian/rules. > I don't think yazc should be in the libs section. > Explicit Depends: libzc3 in yazc is not needed. > Please switch to the debhelper compat level 10. > Please update Standards-Version to the current version. > lib/qsort.h is not described in debian/copyright as having a different > license. > All done. Thanks for the review. Please use: dget -x https://mentors.debian.net/debian/pool/main/libz/libzc/libzc_0.3.3-1.dsc to get the new version. Marc
Bug#862875: RFS: libzc/0.3.1-1 [ITP] -- fast zip cracking library
Control: tags -1 + moreinfo Please either add check to B-D to enable tests or explicitly disable them in debian/rules. I don't think yazc should be in the libs section. Explicit Depends: libzc3 in yazc is not needed. Please switch to the debhelper compat level 10. Please update Standards-Version to the current version. lib/qsort.h is not described in debian/copyright as having a different license. -- WBR, wRAR signature.asc Description: PGP signature
Bug#862875: RFS: libzc/0.3.1-1 [ITP] -- fast zip cracking library
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "libzc". Package name: libzc Version : 0.3.1-1 Upstream Author : Marc FerlandURL : https://github.com/mferland/libzc License : GPL-3 Section : libs It builds those binary packages: libzc-dev - fast password cracking library and client for zip archives - development headers libzc3 - fast password cracking library and client for zip archives To access further information about this package, please visit the following URL: https://mentors.debian.net/package/libzc Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/libz/libzc/libzc_0.3.1-1.dsc More information about libzc can be obtained from https://github.com/mferland/libzc Regards, Marc Ferland