Bug#865531: lintian: description of testsuite-autopkgtest-missing is unhelpful/incorrect

2017-07-29 Thread Chris Lamb 
tags 865531 + pending
thanks

Fixed in Git:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=ce7942a08681a6e67a1a8449effa61fe612e3769

I've also added a `unnecessary-testsuite-header` in

 
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=7c1a32e91b5f9ad674a6f3f66a6a374028942556


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb, Debian Project Leader
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#865531: lintian: description of testsuite-autopkgtest-missing is unhelpful/incorrect

2017-07-28 Thread Niels Thykier 
Chris Lamb:
> Hi,
> 
>> lintian: description of testsuite-autopkgtest-missing is
>> unhelpful/incorrect
> 
> I had a look at this earlier but in the code I can't seem to
> differentiate between:
> 
>   $info->field('testsuite')
> 
> … returning the value from the *dsc* and the value set in the
> debian/control file. :)
> 
> I think I need this to work out whether we have a pointless value
> set in debian/control and the one automatically added by dpkg (since
> 1.17.11, if anyone is curious).
> 
> 
> Regards,
> 

Hi,

Here goes. :)

On a L::Collect::Source:

 * $info->field=> .dsc
 * $info->source_field => d/control

There is usually an overlap as dpkg-source copies most fields from
d/control into the .dsc.

Related, there is also $source_info->binary_field vs.
$binary_info->field (i.e. L::Collect::Binary).  More or less same case,
except here you can also see unexpected substvars in the binary_field case.

Thanks,
~Niels

Bug#865531: lintian: description of testsuite-autopkgtest-missing is unhelpful/incorrect

2017-07-28 Thread Chris Lamb 
Hi,

> lintian: description of testsuite-autopkgtest-missing is
> unhelpful/incorrect

I had a look at this earlier but in the code I can't seem to
differentiate between:

  $info->field('testsuite')

… returning the value from the *dsc* and the value set in the
debian/control file. :)

I think I need this to work out whether we have a pointless value
set in debian/control and the one automatically added by dpkg (since
1.17.11, if anyone is curious).


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-