Bug#866353: rsync: wrong Architecture field in cross built binary package

[Boyuan Yang]

Hi Paul,

Five months have passed and this problem hasn't been fixed yet. Is there any 
progress on your side?


Thanks,
Boyuan Yang

在 2017年11月2日星期四 CST 上午4:45:41，您写道：
> 2017-11-01 10:02 GMT+01:00 Paul Slootman :
> > On Tue 31 Oct 2017, Manuel A. Fernandez Montecelo wrote:
> >> Many packages build-depend on rsync, and this patch seems like a net
> >> gain to apply even in the absence of more benefits.
> >> 
> >> What do you think about applying it, Paul?
> > 
> > Yes, you're right.
> > I have prepared a new package, however uploading may be delayed a couple
> > of days due to another issue. Please be patient.

signature.asc
Description: This is a digitally signed message part.

Bug#866353: rsync: wrong Architecture field in cross built binary package

[Manuel A. Fernandez Montecelo]

2017-11-01 10:02 GMT+01:00 Paul Slootman :
> On Tue 31 Oct 2017, Manuel A. Fernandez Montecelo wrote:
>
>> Many packages build-depend on rsync, and this patch seems like a net
>> gain to apply even in the absence of more benefits.
>>
>> What do you think about applying it, Paul?
>
> Yes, you're right.
> I have prepared a new package, however uploading may be delayed a couple
> of days due to another issue. Please be patient.

That's great, thanks!

-- 
Manuel A. Fernandez Montecelo 

Bug#866353: rsync: wrong Architecture field in cross built binary package

[Paul Slootman]

On Tue 31 Oct 2017, Manuel A. Fernandez Montecelo wrote:

> Many packages build-depend on rsync, and this patch seems like a net
> gain to apply even in the absence of more benefits.
> 
> What do you think about applying it, Paul?

Yes, you're right.
I have prepared a new package, however uploading may be delayed a couple
of days due to another issue. Please be patient.

Thanks for reminding me of this.


Paul

Bug#866353: rsync: wrong Architecture field in cross built binary package

[Manuel A. Fernandez Montecelo]

Hi,

2017-06-29 06:41 Helmut Grohne:

Source: rsync
Version: 3.1.2-2
Severity: important
User: helm...@debian.org
Usertags: rebootstrap

I noticed that when building rsync, it sometimes ends up with the wrong
Architecture field in the binary package. When I built rsync for arm64,
it could still end up as "Architecture: amd64". It turns out the
debian/rules assigns DEB_HOST_ARCH=$(DEB_BUILD_ARCH). Since
DEB_HOST_ARCH usually is an exported variable, subprocesses (e.g.
dpkg-gencontrol) see the assignment and use the wrong value. Simply
removing that line (as it is otherwise unused) fixes the build. Please
consider applying the attached patch.


Many packages build-depend on rsync, and this patch seems like a net
gain to apply even in the absence of more benefits.

What do you think about applying it, Paul?

Is it of any help if we offer to NMU, if you happen to be busy but are
otherwise OK with the patch?


Cheers.
--
Manuel A. Fernandez Montecelo 

Bug#866353: rsync: wrong Architecture field in cross built binary package

[Helmut Grohne]

Source: rsync
Version: 3.1.2-2
Severity: important
User: helm...@debian.org
Usertags: rebootstrap

I noticed that when building rsync, it sometimes ends up with the wrong
Architecture field in the binary package. When I built rsync for arm64,
it could still end up as "Architecture: amd64". It turns out the
debian/rules assigns DEB_HOST_ARCH=$(DEB_BUILD_ARCH). Since
DEB_HOST_ARCH usually is an exported variable, subprocesses (e.g.
dpkg-gencontrol) see the assignment and use the wrong value. Simply
removing that line (as it is otherwise unused) fixes the build. Please
consider applying the attached patch.

Helmut
diff --minimal -Nru rsync-3.1.2/debian/changelog rsync-3.1.2/debian/changelog
--- rsync-3.1.2/debian/changelog2017-03-17 15:02:00.0 +0100
+++ rsync-3.1.2/debian/changelog2017-06-29 06:30:39.0 +0200
@@ -1,3 +1,11 @@
+rsync (3.1.2-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix Architecture field of cross built packages.
+closes: #-1
+
+ -- Helmut Grohne   Thu, 29 Jun 2017 06:30:39 +0200
+
 rsync (3.1.2-2) unstable; urgency=medium
 
   * Added patch from upstream git to resolve temporary lines in --progress
diff --minimal -Nru rsync-3.1.2/debian/rules rsync-3.1.2/debian/rules
--- rsync-3.1.2/debian/rules2016-10-07 15:51:56.0 +0200
+++ rsync-3.1.2/debian/rules2017-06-29 06:30:36.0 +0200
@@ -25,21 +25,6 @@
 CFLAGS   := -Wall  $(shell $(dpkg_buildflags) --get CFLAGS)
 LDFLAGS  :=$(shell $(dpkg_buildflags) --get LDFLAGS)
 
-# backwards compatibility stuff, from dpkg-architecture manpage
-DEB_BUILD_ARCH := $(shell dpkg --print-architecture)
-DEB_BUILD_GNU_CPU := $(patsubst hurd-%,%,$(DEB_BUILD_ARCH))
-ifeq ($(filter-out hurd-%,$(DEB_BUILD_ARCH)),)
-DEB_BUILD_GNU_SYSTEM := gnu
-else
-DEB_BUILD_GNU_SYSTEM := linux
-endif
-DEB_BUILD_GNU_TYPE=$(DEB_BUILD_GNU_CPU)-$(DEB_BUILD_GNU_SYSTEM)
-
-DEB_HOST_ARCH=$(DEB_BUILD_ARCH)
-DEB_HOST_GNU_CPU=$(DEB_BUILD_GNU_CPU)
-DEB_HOST_GNU_SYSTEM=$(DEB_BUILD_GNU_SYSTEM)
-DEB_HOST_GNU_TYPE=$(DEB_BUILD_GNU_TYPE)
-
 DEB_BUILD_GNU_TYPE := $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
 DEB_HOST_GNU_TYPE := $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)