Bug#867192: [Pkg-dns-devel] Bug#867192: Bug#867192: Bug#867192: Bug#867192: let systemd know about the pid file
On Fri 2017-07-14 14:19:01 -0400, Robert Edmonds wrote: > Hm, that could work (but then we have to carry around "-p" in the > service unit forever). I was thinking of a command-line parameter that > takes an argument to the pidfile path (like "-p /run/unbound.pid") that > takes precedence over the 'pidfile' value from the config file and the > compiled in 'pidfile' default value. And then we set the default value > for 'pidfile' to "" so that Unbound doesn't make a pidfile by default, > and append "-p /run/unbound.pid" to $DAEMON_OPTS in /etc/init.d/unbound. I figured if we went that way we'd get complaints about changing the expected interface/contract with existing users of unbound -- you upgrade the main binary on a system that *doesn't* have a sensible/modern process manager, and then all of a sudden you don't get the pidfile protections by default! But i'd be fine with the change you propose, personally :) > BTW, I don't think upstream really monitors that GitHub repository, it's > a git-svn mirror. Posting patches to the mailing list or bugzilla seems > to be their thing. ok, fine: https://www.nlnetlabs.nl/bugs-script/show_bug.cgi?id=1349 feel free to submit an alternate patch there that implements the variant you prefer. Regards, --dkg
Bug#867192: [Pkg-dns-devel] Bug#867192: Bug#867192: Bug#867192: Bug#867192: let systemd know about the pid file
Daniel Kahn Gillmor wrote: > On Fri 2017-07-14 12:32:57 -0400, Robert Edmonds wrote: > > So we either need to configure systemd to delete Unbound's pidfile, or > > we could develop and contribute a patch upstream that allows overriding > > the pidfile via the command-line. > > ok, how about something like this: > > https://github.com/NLnetLabs/unbound/pull/1 Hm, that could work (but then we have to carry around "-p" in the service unit forever). I was thinking of a command-line parameter that takes an argument to the pidfile path (like "-p /run/unbound.pid") that takes precedence over the 'pidfile' value from the config file and the compiled in 'pidfile' default value. And then we set the default value for 'pidfile' to "" so that Unbound doesn't make a pidfile by default, and append "-p /run/unbound.pid" to $DAEMON_OPTS in /etc/init.d/unbound. BTW, I don't think upstream really monitors that GitHub repository, it's a git-svn mirror. Posting patches to the mailing list or bugzilla seems to be their thing. -- Robert Edmonds edmo...@debian.org
