Bug#867545: Fails with confusing message when tarball target is a unresolved symlink
Hi Tomasz, On Fri, Jul 07, 2017 at 10:07:14PM +0200, Tomasz Buchert wrote: > retitle 867545 Fails with cryptic message when given paths do not exist > thanks > > On 07/07/17 09:57, Guido Günther wrote: > > Package: pristine-tar > > Version: 1.39 > > Severity: minor > > > > pristine-tar fails when the target it want's to reproduce is a symlink > > that points nowhere. That by itself is o.k. but the error message is > > confusing: > > > > $ /usr/bin/pristine-tar checkout > > /var/scratch/src/krb5-auth-dialog/krb5-auth-dialog_3.20.0.orig.tar.xz > > Use of uninitialized value $tarball in -e at /usr/bin/pristine-tar line > > 454. > > Use of uninitialized value $_[0] in substitution (s///) at > > /usr/share/perl/5.24/File/Basename.pm line 180. > > fileparse(): need a valid pathname at /usr/bin/pristine-tar line 469. > > pristine-tar: failed to generate tarball > > > > Steps to reproduce: > > > > ln -s /doesnotexist krb5-auth-dialog_3.20.0.orig.tar.xz > > gbp clone vcsgit:krb5-auth-dialog > > /usr/bin/pristine-tar checkout > > /var/scratch/src/krb5-auth-dialog/krb5-auth-dialog_3.20.0.orig.tar.xz > > > > Hey Guido, > thanks for this info, but I think the issue has nothing to do with the > symbolic link, but rather with the fact that the destination directory > does not exist (also in steps above you have to 'cd' into the cloned > repo). > > I've committed a change [1] that will verify better what is given from > the command line to all pristine-tar commands. Thanks for fixing this so quickly! -- Guido > > Thanks, > Tomasz > > [1] > https://anonscm.debian.org/cgit/collab-maint/pristine-tar.git/commit/?id=9265d0c0eea1620370a7261e0a6ee20eb86426fd
Bug#867545: Fails with confusing message when tarball target is a unresolved symlink
retitle 867545 Fails with cryptic message when given paths do not exist thanks On 07/07/17 09:57, Guido Günther wrote: > Package: pristine-tar > Version: 1.39 > Severity: minor > > pristine-tar fails when the target it want's to reproduce is a symlink > that points nowhere. That by itself is o.k. but the error message is > confusing: > > $ /usr/bin/pristine-tar checkout > /var/scratch/src/krb5-auth-dialog/krb5-auth-dialog_3.20.0.orig.tar.xz > Use of uninitialized value $tarball in -e at /usr/bin/pristine-tar line > 454. > Use of uninitialized value $_[0] in substitution (s///) at > /usr/share/perl/5.24/File/Basename.pm line 180. > fileparse(): need a valid pathname at /usr/bin/pristine-tar line 469. > pristine-tar: failed to generate tarball > > Steps to reproduce: > > ln -s /doesnotexist krb5-auth-dialog_3.20.0.orig.tar.xz > gbp clone vcsgit:krb5-auth-dialog > /usr/bin/pristine-tar checkout > /var/scratch/src/krb5-auth-dialog/krb5-auth-dialog_3.20.0.orig.tar.xz > Hey Guido, thanks for this info, but I think the issue has nothing to do with the symbolic link, but rather with the fact that the destination directory does not exist (also in steps above you have to 'cd' into the cloned repo). I've committed a change [1] that will verify better what is given from the command line to all pristine-tar commands. Thanks, Tomasz [1] https://anonscm.debian.org/cgit/collab-maint/pristine-tar.git/commit/?id=9265d0c0eea1620370a7261e0a6ee20eb86426fd signature.asc Description: PGP signature
Bug#867545: Fails with confusing message when tarball target is a unresolved symlink
Package: pristine-tar Version: 1.39 Severity: minor pristine-tar fails when the target it want's to reproduce is a symlink that points nowhere. That by itself is o.k. but the error message is confusing: $ /usr/bin/pristine-tar checkout /var/scratch/src/krb5-auth-dialog/krb5-auth-dialog_3.20.0.orig.tar.xz Use of uninitialized value $tarball in -e at /usr/bin/pristine-tar line 454. Use of uninitialized value $_[0] in substitution (s///) at /usr/share/perl/5.24/File/Basename.pm line 180. fileparse(): need a valid pathname at /usr/bin/pristine-tar line 469. pristine-tar: failed to generate tarball Steps to reproduce: ln -s /doesnotexist krb5-auth-dialog_3.20.0.orig.tar.xz gbp clone vcsgit:krb5-auth-dialog /usr/bin/pristine-tar checkout /var/scratch/src/krb5-auth-dialog/krb5-auth-dialog_3.20.0.orig.tar.xz Cheers, -- Guido -- System Information: Debian Release: buster/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'oldoldstable'), (500, 'unstable'), (500, 'stable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages pristine-tar depends on: ii libbz2-1.0 1.0.6-8.1 ii libc6 2.24-12 ii perl5.24.1-4 ii tar 1.29b-1.1 ii xdelta 1.1.3-9.1+b1 ii xdelta3 3.0.11-dfsg-1+b1 ii zlib1g 1:1.2.8.dfsg-5 Versions of packages pristine-tar recommends: ii bzip2 1.0.6-8.1 ii pbzip21.1.9-1+b1 ii xz-utils 5.2.2-1.2+b1 pristine-tar suggests no packages. -- no debconf information
