Bug#868408: xnee: Please drop the (build-)dependency against gnome-vfs

[Henrik Sandklef]

On 2018-01-02 02:02, Andreas Henriksson wrote:

Hej Henrik, Vincent,

On Tue, Jan 02, 2018 at 12:11:16AM +0100, Henrik Sandklef wrote:

I have removed deps to gnomeui (gconf had already been removed) from Xnee
sources.


Vincent, please see the attached debdiff that incorporates Henriks
change as a patch in debian/patches/ for your convenience.
(You might also want to look into upgrading to a non-deprecated
debhelper compat level (apparently 5 is currently used while anything
before 9 is deprecated), etc. See also other lintian warnings.)



Can I assist you in any way?


Thanks for the offer! From my point of view it's really up to Vincent
how he wants to handle this - I just wanted to remind and point out
the urgency of this issue being resolved in any way.
Hopefully Vincent will get in touch with you if he has something
to discuss.

While poking around I noticed a couple of things which I'm just
mentioning in case it'll interest you:
- Is it true CVS is still used? (Or else I've probably looked at the
wrong upstream location)


Yes. I do not have time to maintain Xnee as I should. Switching VCS is 
not prio #1.



- I guess $(libgnomeui_LIBS) and $(libgnomeui_CFLAGS) can now also
   be dropped from gnee/src/Makefile.am (and possibly other places?)


Thanks a lot.


- Apparently configure(.in) has no check for pkg-config modules actually
   exiting (which I ran into while having pkg-config itself, but not
   gtk+-2.0.pc since the libgtk2.0-dev build-dependency was missing in
   the debian xnee package). A more obvious error message could have
   been produced by explicitly checking
   if ! $PKGCONF --exists $GTK2_MODULE >= GTK2_VERSION and erroring out.
   Even better though... (see below).



- directly invoking pkg-config is not cross compilation safe (as lintian
   points out). It would probably be better to replace all pkg-config
   usage with PKG_CHECK_MODULES macro usage instead. (And gtk-config is
   long gone so you can probably retire that code path while at it.)
   This should also give a more modern and fool-proof configure process.


See if I can squeeze these in.


The lintian report might also give you useful information:
https://lintian.debian.org/maintainer/ber...@debian.org.html#xnee_3.19-1

Med vänlig hälsning,
Andreas Henriksson


Tusen tack och gott nytt år
/henrik

Bug#868408: xnee: Please drop the (build-)dependency against gnome-vfs

[Vincent Bernat]

 ❦  2 janvier 2018 02:02 +0100, Andreas Henriksson  :

>> I have removed deps to gnomeui (gconf had already been removed) from Xnee
>> sources.
>
> Vincent, please see the attached debdiff that incorporates Henriks
> change as a patch in debian/patches/ for your convenience.
> (You might also want to look into upgrading to a non-deprecated
> debhelper compat level (apparently 5 is currently used while anything
> before 9 is deprecated), etc. See also other lintian warnings.)

I'll do an upload shortly with your patch.
-- 
Use the fundamental control flow constructs.
- The Elements of Programming Style (Kernighan & Plauger)


signature.asc
Description: PGP signature

Bug#868408: xnee: Please drop the (build-)dependency against gnome-vfs

[Andreas Henriksson]

Hej Henrik, Vincent,

On Tue, Jan 02, 2018 at 12:11:16AM +0100, Henrik Sandklef wrote:
> I have removed deps to gnomeui (gconf had already been removed) from Xnee
> sources.

Vincent, please see the attached debdiff that incorporates Henriks
change as a patch in debian/patches/ for your convenience.
(You might also want to look into upgrading to a non-deprecated
debhelper compat level (apparently 5 is currently used while anything
before 9 is deprecated), etc. See also other lintian warnings.)

> 
> Can I assist you in any way?

Thanks for the offer! From my point of view it's really up to Vincent
how he wants to handle this - I just wanted to remind and point out
the urgency of this issue being resolved in any way.
Hopefully Vincent will get in touch with you if he has something
to discuss.

While poking around I noticed a couple of things which I'm just
mentioning in case it'll interest you:
- Is it true CVS is still used? (Or else I've probably looked at the
wrong upstream location)
- I guess $(libgnomeui_LIBS) and $(libgnomeui_CFLAGS) can now also
  be dropped from gnee/src/Makefile.am (and possibly other places?)
- Apparently configure(.in) has no check for pkg-config modules actually
  exiting (which I ran into while having pkg-config itself, but not
  gtk+-2.0.pc since the libgtk2.0-dev build-dependency was missing in
  the debian xnee package). A more obvious error message could have
  been produced by explicitly checking
  if ! $PKGCONF --exists $GTK2_MODULE >= GTK2_VERSION and erroring out.
  Even better though... (see below).
- directly invoking pkg-config is not cross compilation safe (as lintian
  points out). It would probably be better to replace all pkg-config
  usage with PKG_CHECK_MODULES macro usage instead. (And gtk-config is
  long gone so you can probably retire that code path while at it.)
  This should also give a more modern and fool-proof configure process.

The lintian report might also give you useful information:
https://lintian.debian.org/maintainer/ber...@debian.org.html#xnee_3.19-1

Med vänlig hälsning,
Andreas Henriksson
diff -Nru xnee-3.19/debian/changelog xnee-3.19/debian/changelog
--- xnee-3.19/debian/changelog	2014-05-23 01:33:06.0 +0200
+++ xnee-3.19/debian/changelog	2018-01-02 01:14:24.0 +0100
@@ -1,3 +1,15 @@
+xnee (3.19-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Add debian/patches/upstream_libgnomui-only-for-applets.patch
+- upstream commit/revision 1.134->1.135 to not require
+  libgnomeui unless building applets (which is disabled here).
+  * Drop libgnomeui-dev build-dependency. (Closes: #885738)
+  * Add missing build-dependencies on pkg-config and libgtk2.0-dev
+- previously implicitly pulled in via libgnomeui-dev
+
+ -- Andreas Henriksson   Tue, 02 Jan 2018 01:14:24 +0100
+
 xnee (3.19-1) unstable; urgency=medium
 
   * New upstream version.
diff -Nru xnee-3.19/debian/control xnee-3.19/debian/control
--- xnee-3.19/debian/control	2014-05-23 01:33:06.0 +0200
+++ xnee-3.19/debian/control	2018-01-02 01:14:24.0 +0100
@@ -7,9 +7,10 @@
 debhelper (>= 5),
 cdbs,
 dh-autoreconf,
+pkg-config,
+libgtk2.0-dev,
 libxtst-dev,
 imagemagick,
-libgnomeui-dev,
 dia,
 texi2html,
 texlive-base,
diff -Nru xnee-3.19/debian/patches/series xnee-3.19/debian/patches/series
--- xnee-3.19/debian/patches/series	2014-05-23 01:33:06.0 +0200
+++ xnee-3.19/debian/patches/series	2018-01-02 01:13:16.0 +0100
@@ -2,3 +2,4 @@
 manpages-fix.patch
 fix-docdir.patch
 dont-compile-dvi.patch
+upstream_libgnomui-only-for-applets.patch
diff -Nru xnee-3.19/debian/patches/upstream_libgnomui-only-for-applets.patch xnee-3.19/debian/patches/upstream_libgnomui-only-for-applets.patch
--- xnee-3.19/debian/patches/upstream_libgnomui-only-for-applets.patch	1970-01-01 01:00:00.0 +0100
+++ xnee-3.19/debian/patches/upstream_libgnomui-only-for-applets.patch	2018-01-02 01:14:24.0 +0100
@@ -0,0 +1,117 @@
+--- a/configure.in	2014/05/06 14:13:59	1.134
 b/configure.in	2018/01/01 23:06:56	1.135
+@@ -382,62 +382,63 @@
+ fi
+ 
+ 
+-GNOMEUI2_MODULE="libgnomeui-2.0"
+-GNOMEUI2_VERSION="2.0.0"
+-
+-
+-if `$PKGCFG --exists  $GNOMEUI2_MODULE >= $GNOMEUI2_VERSION`
+-then	
+-	GTK_MODULES="$GTK_MODULES $GNOMEUI2_MODULE" 
+-	GTK_ERR=1
+-fi
+-
+-libgnomeui_CFLAGS=`$PKGCFG --cflags $GNOMEUI2_MODULE `
+-libgnomeui_LIBS=`$PKGCFG --libs $GNOMEUI2_MODULE `
+-
+-
+-AC_SUBST(libgnomeui_CFLAGS)
+-AC_SUBST(libgnomeui_LIBS)
+-
+ PIXMAP_DIR=pixmap
+ 
+-
+-if test x$buildgapplet = xtrue ; 
++if test x$buildgapplet = xtrue; 
+ then   
+-
+-  if test x$GTKCONF = x ; 
+-  then
+-  	echo "  "
+-  	echo " * WARNING, missing program: gtk-config *"
+-  	echo "  "
+-  	echo ""
+-  	echo " On Debian 

Bug#868408: xnee: Please drop the (build-)dependency against gnome-vfs

[Henrik Sandklef]

I have removed deps to gnomeui (gconf had already been removed) from 
Xnee sources.


Can I assist you in any way?

/henrik - GNU Xnee maintainer

On 2017-12-31 14:28, Andreas Henriksson wrote:

Hello Vincent Bernat,

On Sat, Jul 15, 2017 at 11:04:51PM +0200, Vincent Bernat wrote:
[...]

As far as xnee is concerned, I can drop the Gnome frontend if it relies
on deprecated libs.


Please do this A.S.A.P!

The time is near when all the remaining unmaintained packages will
removed, and by leaving this issue unfixed xnee risks going out
with the rest.


Regards,
Andreas Henriksson

Bug#868408: xnee: Please drop the (build-)dependency against gnome-vfs

[Andreas Henriksson]

Hello Vincent Bernat,

On Sat, Jul 15, 2017 at 11:04:51PM +0200, Vincent Bernat wrote:
[...]
> As far as xnee is concerned, I can drop the Gnome frontend if it relies
> on deprecated libs.

Please do this A.S.A.P!

The time is near when all the remaining unmaintained packages will
removed, and by leaving this issue unfixed xnee risks going out
with the rest.


Regards,
Andreas Henriksson

Bug#868408: xnee: Please drop the (build-)dependency against gnome-vfs

[Vincent Bernat]

 ❦ 15 juillet 2017 22:50 +0200, Laurent Bigonville  :

>>> Your package is {build-}depending against gnome-vfs which is
>>> deprecated for quite some times now and has been replaced by gvfs.
>>>
>>> We are thinking about removing gnome-vfs for Buster if possible.
>>>
>>> Could you please verify that this dependency is mandatory and if it's
>>> not the case, could you please remove it?
>> xnee build-depends on libgnomeui-dev, is it deprecated too? It seems the
>> binary dependency (libgnomevfs2-0) comes from here. Just rebuilding
>> gives the same result.
> Hello,
>
> Yes, libgnome* is also deprecated and we are also trying to remove it
> from debian, but there are still quite some rdeps ATM so I was hoping
> to be able to remove some other deprecated libs, but apparently it's
> more complex than expected

As far as xnee is concerned, I can drop the Gnome frontend if it relies
on deprecated libs.
-- 
10.0 times 0.1 is hardly ever 1.0.
- The Elements of Programming Style (Kernighan & Plauger)


signature.asc
Description: PGP signature

Bug#868408: xnee: Please drop the (build-)dependency against gnome-vfs

[Laurent Bigonville]

Le 15/07/17 à 13:53, Vincent Bernat a écrit :

  ❦ 15 juillet 2017 13:40 +0200, bi...@debian.org :


Your package is {build-}depending against gnome-vfs which is
deprecated for quite some times now and has been replaced by gvfs.

We are thinking about removing gnome-vfs for Buster if possible.

Could you please verify that this dependency is mandatory and if it's
not the case, could you please remove it?

xnee build-depends on libgnomeui-dev, is it deprecated too? It seems the
binary dependency (libgnomevfs2-0) comes from here. Just rebuilding
gives the same result.

Hello,

Yes, libgnome* is also deprecated and we are also trying to remove it 
from debian, but there are still quite some rdeps ATM so I was hoping to 
be able to remove some other deprecated libs, but apparently it's more 
complex than expected

Bug#868408: xnee: Please drop the (build-)dependency against gnome-vfs

[Vincent Bernat]

 ❦ 15 juillet 2017 13:40 +0200, bi...@debian.org :

> Your package is {build-}depending against gnome-vfs which is
> deprecated for quite some times now and has been replaced by gvfs.
>
> We are thinking about removing gnome-vfs for Buster if possible.
>
> Could you please verify that this dependency is mandatory and if it's
> not the case, could you please remove it?

xnee build-depends on libgnomeui-dev, is it deprecated too? It seems the
binary dependency (libgnomevfs2-0) comes from here. Just rebuilding
gives the same result.
-- 
Make sure comments and code agree.
- The Elements of Programming Style (Kernighan & Plauger)


signature.asc
Description: PGP signature