Bug#869667: stretch-pu: package xkeyboard-config/2.19-1

[Adam D. Barratt]

Control: tags -1 + pending

On Thu, 2017-09-21 at 19:03 +0100, Adam D. Barratt wrote:
> On Sat, 2017-09-09 at 14:35 +0200, Julien Cristau wrote:
> > Feel free to upload with the debian/files issue fixed.
> > 
> 
> Apologies for none of us having spotted this earlier, but:
> 
> +xkeyboard-config (2.19-1.1+deb9u1) stretch; urgency=medium
> 
> Unstable and testing currently have 2.19-1.1, which means that the
> upload for stable needs to be either 2.19-1+deb9u1 or 2.19-
> 1.1~deb9u1,
> in order to have a lower version.
> 
> I've flagged the existing upload for rejection. Please feel free to
> re-
> upload with a fixed version number.
> 

That happened and I've flagged the new upload for acceptance.

Regards,

Adam

Bug#869667: stretch-pu: package xkeyboard-config/2.19-1

[Adam D. Barratt]

On Sat, 2017-09-09 at 14:35 +0200, Julien Cristau wrote:
> Feel free to upload with the debian/files issue fixed.
> 

Apologies for none of us having spotted this earlier, but:

+xkeyboard-config (2.19-1.1+deb9u1) stretch; urgency=medium

Unstable and testing currently have 2.19-1.1, which means that the
upload for stable needs to be either 2.19-1+deb9u1 or 2.19-1.1~deb9u1,
in order to have a lower version.

I've flagged the existing upload for rejection. Please feel free to re-
upload with a fixed version number.

Regards,

Adam

Bug#869667: stretch-pu: package xkeyboard-config/2.19-1

[Julien Cristau]

Control: tags -1 = stretch d-i confirmed

On Sat, Sep  9, 2017 at 14:12:38 +0200, Cyril Brulebois wrote:

> Adam D. Barratt  (2017-07-30):
> > Control: tags -1 + moreinfo d-i
> > 
> > On Tue, 2017-07-25 at 19:20 +0530, Pirate Praveen wrote:
> > > This fixes serious bug #865316 (all Indic language users were unable to
> > > select their keyboard layouts in stretch introducing a regression. This
> > > was caused by an earlier commit upstream which blacklisted Indic
> > > keyboard layouts, upstream was convinced it was a mistake and reverted
> > > the blacklist. This update applies that patch to debian package so
> > > stretch users can type using Indic language keyboards again).
> > 
> > This looks okay to me, other than this noise in the diff:
> > 
> > --- xkeyboard-config-2.19.orig/debian/files
> > +++ xkeyboard-config-2.19/debian/files
> > @@ -0,0 +1 @@
> > +xkeyboard-config_2.19-1.1_source.buildinfo x11 extra
> > 
> > As the package produces a udeb, this will need an ack from the d-i RM as
> > well; CCing appropriately.
> 
> No objections, thanks.
> 
Feel free to upload with the debian/files issue fixed.

Cheers,
Julien

Bug#869667: stretch-pu: package xkeyboard-config/2.19-1

[Cyril Brulebois]

Adam D. Barratt  (2017-07-30):
> Control: tags -1 + moreinfo d-i
> 
> On Tue, 2017-07-25 at 19:20 +0530, Pirate Praveen wrote:
> > This fixes serious bug #865316 (all Indic language users were unable to
> > select their keyboard layouts in stretch introducing a regression. This
> > was caused by an earlier commit upstream which blacklisted Indic
> > keyboard layouts, upstream was convinced it was a mistake and reverted
> > the blacklist. This update applies that patch to debian package so
> > stretch users can type using Indic language keyboards again).
> 
> This looks okay to me, other than this noise in the diff:
> 
> --- xkeyboard-config-2.19.orig/debian/files
> +++ xkeyboard-config-2.19/debian/files
> @@ -0,0 +1 @@
> +xkeyboard-config_2.19-1.1_source.buildinfo x11 extra
> 
> As the package produces a udeb, this will need an ack from the d-i RM as
> well; CCing appropriately.

No objections, thanks.


KiBi.


signature.asc
Description: PGP signature

Bug#869667: stretch-pu: package xkeyboard-config/2.19-1

[Pirate Praveen]

On വ്യാഴം 24 ആഗസ്റ്റ് 2017 11:36 വൈകു, Adam D. Barratt wrote:
> There appears to be some confusion here.
> 
> stretch/updates is in the security archive and therefore irrelevant to
> this discussion.
> 
> Before the point release, your upload will be in proposed-updates.
> Packages in proposed-updates are available once a member of the Release
> Team has accepted them from the stable-new queue. That still requires
> users consuming proposed-updates, which most don't.
> 
> Finally, stretch-updates is a special distribution which the Release
> Team can push packages from proposed-updates to under some
> circumstances. That still requires the package to have been accepted
> into proposed-updates first as per the above, and I'm not convinced that
> this upload would meet the criteria for such a release.

Sorry for the confusion and thanks for clarifying. I was hoping for
stretch-updates, but I'll have to live with a point release. In that
case, I understand the delay.



signature.asc
Description: OpenPGP digital signature

Bug#869667: stretch-pu: package xkeyboard-config/2.19-1

[Adam D. Barratt]

On Thu, 2017-08-24 at 22:59 +0530, Pirate Praveen wrote:
> On വ്യാഴം 24 ആഗസ്റ്റ് 2017 09:46 വൈകു, Cyril Brulebois wrote:
> > Great thing that point releases usually happen once every 3 months, right?
> > 
> > Anyway: right now, D-I Buster Alpha 1 has the priority; point release
> > material can definitely wait.
> 
> But it is blocking everyone, as it can't go into updates without your
> ack. Packages in stretch/updates are available immediately to users once
> it enters the archive.

There appears to be some confusion here.

stretch/updates is in the security archive and therefore irrelevant to
this discussion.

Before the point release, your upload will be in proposed-updates.
Packages in proposed-updates are available once a member of the Release
Team has accepted them from the stable-new queue. That still requires
users consuming proposed-updates, which most don't.

Finally, stretch-updates is a special distribution which the Release
Team can push packages from proposed-updates to under some
circumstances. That still requires the package to have been accepted
into proposed-updates first as per the above, and I'm not convinced that
this upload would meet the criteria for such a release.

Regards,

Adam

Bug#869667: stretch-pu: package xkeyboard-config/2.19-1

[Cyril Brulebois]

Pirate Praveen  (2017-08-24):
> On വ്യാഴം 24 ആഗസ്റ്റ് 2017 09:46 വൈകു, Cyril Brulebois wrote:
> > Great thing that point releases usually happen once every 3 months, right?
> > 
> > Anyway: right now, D-I Buster Alpha 1 has the priority; point release
> > material can definitely wait.
> 
> But it is blocking everyone, as it can't go into updates without your
> ack. Packages in stretch/updates are available immediately to users once
> it enters the archive.

You seem to be confused:
 - stretch/updates is a security suite.
 - stretch-proposed-updates is what this stretch-pu request is about;
   the package is available in this extra suite which users may have
   configured, then merged during point releases into stretch.
 - stretch-updates is for immediate bug fixes, through an extra suite as
   well, even if it's more likely to be configured on user systems.

I haven't seen anything in the bug report that indicates you were
requesting that your package goes to stretch-updates as opposed to the
default stretch-proposed-updates, so your claim above seems rather
incorrect to me.


KiBi.


signature.asc
Description: Digital signature

Bug#869667: stretch-pu: package xkeyboard-config/2.19-1

[Pirate Praveen]

On വ്യാഴം 24 ആഗസ്റ്റ് 2017 09:46 വൈകു, Cyril Brulebois wrote:
> Great thing that point releases usually happen once every 3 months, right?
> 
> Anyway: right now, D-I Buster Alpha 1 has the priority; point release
> material can definitely wait.

But it is blocking everyone, as it can't go into updates without your
ack. Packages in stretch/updates are available immediately to users once
it enters the archive.



signature.asc
Description: OpenPGP digital signature

Bug#869667: stretch-pu: package xkeyboard-config/2.19-1

[Cyril Brulebois]

Pirate Praveen  (2017-08-24):
> On Sun, 30 Jul 2017 23:10:45 +0100 "Adam D. Barratt"
>  wrote:> As the package produces a udeb, this
> will need an ack from the d-i RM as
> > well; CCing appropriately.
> 
> Its already 3 weeks without a response. I tried pinging them on irc as well.

Great thing that point releases usually happen once every 3 months, right?

Anyway: right now, D-I Buster Alpha 1 has the priority; point release
material can definitely wait.


KiBi.


signature.asc
Description: Digital signature

Bug#869667: stretch-pu: package xkeyboard-config/2.19-1

[Pirate Praveen]

On Sun, 30 Jul 2017 23:10:45 +0100 "Adam D. Barratt"
 wrote:> As the package produces a udeb, this
will need an ack from the d-i RM as
> well; CCing appropriately.

Its already 3 weeks without a response. I tried pinging them on irc as well.



signature.asc
Description: OpenPGP digital signature

Bug#869667: stretch-pu: package xkeyboard-config/2.19-1

[Adam D. Barratt]

Control: tags -1 + moreinfo d-i

On Tue, 2017-07-25 at 19:20 +0530, Pirate Praveen wrote:
> This fixes serious bug #865316 (all Indic language users were unable to
> select their keyboard layouts in stretch introducing a regression. This
> was caused by an earlier commit upstream which blacklisted Indic
> keyboard layouts, upstream was convinced it was a mistake and reverted
> the blacklist. This update applies that patch to debian package so
> stretch users can type using Indic language keyboards again).

This looks okay to me, other than this noise in the diff:

--- xkeyboard-config-2.19.orig/debian/files
+++ xkeyboard-config-2.19/debian/files
@@ -0,0 +1 @@
+xkeyboard-config_2.19-1.1_source.buildinfo x11 extra

As the package produces a udeb, this will need an ack from the d-i RM as
well; CCing appropriately.

Regards,

Adam

Bug#869667: stretch-pu: package xkeyboard-config/2.19-1

[Pirate Praveen]

Control: tags -1 - moreinfo

On ചൊവ്വ 25 ജൂലൈ 2017 08:31 വൈകു, Adam D. Barratt wrote:
> The metadata for that bug is rather confused, not least because its
> found and fixed lists apply to completely separate packages. Please fix
> it so that it's clear which versions of which source packages are
> actually affected by the issue.

Updated the bug metadata. It is found in 2.19-1 and fixed in 2.19-1.1



signature.asc
Description: OpenPGP digital signature

Bug#869667: stretch-pu: package xkeyboard-config/2.19-1

[Adam D. Barratt]

Control: tags -1 + moreinfo

On 2017-07-25 14:50, Pirate Praveen wrote:

This fixes serious bug #865316 (all Indic language users were unable to


The metadata for that bug is rather confused, not least because its 
found and fixed lists apply to completely separate packages. Please fix 
it so that it's clear which versions of which source packages are 
actually affected by the issue.


Regards,

Adam

Bug#869667: stretch-pu: package xkeyboard-config/2.19-1

[Pirate Praveen]

Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu

This fixes serious bug #865316 (all Indic language users were unable to
select their keyboard layouts in stretch introducing a regression. This
was caused by an earlier commit upstream which blacklisted Indic
keyboard layouts, upstream was convinced it was a mistake and reverted
the blacklist. This update applies that patch to debian package so
stretch users can type using Indic language keyboards again).

debdiff attached.

-- System Information:
Debian Release: 9.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=ml_IN.UTF-8, LC_CTYPE=ml_IN.UTF-8 (charmap=UTF-8),
LANGUAGE=ml_IN.UTF-8 (charmap=UTF-8)
Init: systemd (via /run/systemd/system)
diff -u xkeyboard-config-2.19/debian/changelog 
xkeyboard-config-2.19/debian/changelog
--- xkeyboard-config-2.19/debian/changelog
+++ xkeyboard-config-2.19/debian/changelog
@@ -1,3 +1,12 @@
+xkeyboard-config (2.19-1.1+deb9u1) stretch; urgency=medium
+
+  * Non-maintainer upload.
+  * Revert blacklisting of Indic layouts (Closes: #865316)
+Now Indic keyboards can be selected from list of available keyboard layouts
+like in previous stable releases. This was reverted upstream as well.
+
+ -- Pirate Praveen   Tue, 18 Jul 2017 13:08:55 +0530
+
 xkeyboard-config (2.19-1) unstable; urgency=medium
 
   * New upstream release.
diff -u xkeyboard-config-2.19/debian/patches/series 
xkeyboard-config-2.19/debian/patches/series
--- xkeyboard-config-2.19/debian/patches/series
+++ xkeyboard-config-2.19/debian/patches/series
@@ -2,0 +3 @@
+revert-indic-blacklist.diff
only in patch2:
unchanged:
--- xkeyboard-config-2.19.orig/debian/files
+++ xkeyboard-config-2.19/debian/files
@@ -0,0 +1 @@
+xkeyboard-config_2.19-1.1_source.buildinfo x11 extra
only in patch2:
unchanged:
--- xkeyboard-config-2.19.orig/debian/patches/revert-indic-blacklist.diff
+++ xkeyboard-config-2.19/debian/patches/revert-indic-blacklist.diff
@@ -0,0 +1,756 @@
+From bba001a451ae79a983b3ecac40ff86c4121c83c8 Mon Sep 17 00:00:00 2001
+From: Akshay S Dinesh 
+Date: Wed, 21 Jun 2017 18:19:18 +0530
+Subject: Whitelist Indian keyboard layouts. #101532
+
+Indian keyboard layouts were moved into extras in #96418.
+This was not necessary as it was indeed possible to type complex
+characters of Indian scripts using these layouts.
+
+Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=101532
+
+Signed-off-by: Akshay S Dinesh 
+
+--- a/rules/base.xml.in
 b/rules/base.xml.in
+@@ -1805,6 +1805,27 @@
+ 
+ 
+   
++bd
++
++<_shortDescription>bn
++<_description>Bangla
++
++  ben
++  
++  sat
++
++  
++  
++
++  
++probhat
++<_description>Bangla (Probhat)
++  
++
++  
++
++
++  
+ in
+ 
+ <_shortDescription>in
+@@ -1813,6 +1834,286 @@
+   
+ 
+   
++ben
++
++<_shortDescription>bn
++<_description>Bangla (India)
++
++  ben
++  
++  sat
++
++  
++
++
++  
++ben_probhat
++
++<_shortDescription>bn
++<_description>Bangla (India, Probhat)
++
++  ben
++  
++  sat
++
++  
++
++
++  
++ben_baishakhi
++<_description>Bangla (India, Baishakhi)
++
++  ben
++  
++  sat
++
++  
++
++
++  
++ben_bornona
++<_description>Bangla (India, Bornona)
++
++  ben
++  
++  sat
++
++  
++
++ 
++  
++ben_gitanjali
++<_description>Bangla (India, Uni Gitanjali)
++
++  ben
++  
++  sat
++
++  
++
++
++  
++ben_inscript
++<_description>Bangla (India, Baishakhi Inscript)
++
++  ben
++  
++  sat
++
++  
++
++
++  
++eeyek
++<_description>Manipuri (Eeyek)
++
++  mni
++
++  
++
++
++  
++guj
++
++<_shortDescription>gu
++<_description>Gujarati
++
++  guj
++
++  
++
++
++  
++guru
++
++