Bug#872355: ITP: node-is-module -- Node.js code to check if a string is an ES6 module

[Julien Puydt]

Hi,

Le 17/09/2017 à 20:37, Juhani Numminen a écrit :
> Julien Puydt kirjoitti 16.08.2017 klo 19:37:
>>    Description : Node.js code to check if a string is an ES6 module
>>   This simple code checks whether a string is the source of an ES6
>> module. It
>>   doesn't actually execute the code and doesn't check other module
>> types and
>>   doesn't check other module types, so source strings without module
>> loaders
>>   aren't recognized as modules.
> 
> The phrase "and doesn't check other module types" is repeated in the
> description. It made it into the uploaded package:
> https://ftp-master.debian.org/new/node-is-module_1.0.0-1.html

Then either 1.0.0-1 is rejected as-is and I'll provide a fixed 1.0.0-1.

Or 1.0.0-1 goes in like this and I'll provide a fixed 1.0.0-2.

Tell me what you prefer.

Snark on #debian-js

Bug#872355: ITP: node-is-module -- Node.js code to check if a string is an ES6 module

[Juhani Numminen]

Julien Puydt kirjoitti 16.08.2017 klo 19:37:

   Description : Node.js code to check if a string is an ES6 module
  This simple code checks whether a string is the source of an ES6 module. It
  doesn't actually execute the code and doesn't check other module types and
  doesn't check other module types, so source strings without module loaders
  aren't recognized as modules.


The phrase "and doesn't check other module types" is repeated in the 
description. It made it into the uploaded package:

https://ftp-master.debian.org/new/node-is-module_1.0.0-1.html

Cheers,
Juhani

Bug#872355: ITP: node-is-module -- Node.js code to check if a string is an ES6 module

[Julien Puydt]

Hi,

Le 16/08/2017 à 19:26, Philip Hands a écrit :
> Julien Puydt  writes:
>> * URL : https://github.com/component/is-module
> 
> That URL is not correct.
> 
> Did you perhaps mean:  https://github.com/timaschew/is-module
> 

It's annoying:
   https://www.npmjs.com/package/is-module
points to:
   https://github.com/component/is-module
so what I packaged is what people using npm to get their javascript
chunk actually use. But indeed, that link is a 404.

The link you point to gives the same license with the same copyright,
but it doesn't look like it's the same author, so I don't know what
I'm supposed to do.

Snark on #debian-js

Bug#872355: ITP: node-is-module -- Node.js code to check if a string is an ES6 module

[Philip Hands]

Julien Puydt  writes:

> Hi,
>
> Le 16/08/2017 à 19:26, Philip Hands a écrit :
>> Julien Puydt  writes:
>>> * URL : https://github.com/component/is-module
>> 
>> That URL is not correct.
>> 
>> Did you perhaps mean:  https://github.com/timaschew/is-module
>> 
>
> It's annoying:
>https://www.npmjs.com/package/is-module
> points to:
>https://github.com/component/is-module
> so what I packaged is what people using npm to get their javascript
> chunk actually use. But indeed, that link is a 404.
>
> The link you point to gives the same license with the same copyright,
> but it doesn't look like it's the same author, so I don't know what
> I'm supposed to do.

Sorry, I've no idea -- the link I came up with is just the result of
putting 'is-module' into github's search -- I have no information about
how that might relate to whatever was at the other link, or why it's not
there now.

I do note that timaschew's version includes a comment:

  // no idea what these regular expressions do,
  ...

  ( https://github.com/timaschew/is-module/blob/master/index.js#L2 )

which strikes me as a little worrying, given that the regular
expressions constitute pretty-much everything that this package does, so
if you can find a version of this by someone that knows what they are
doing, that might be a bonus ;-)

I guess that the way to make that better would be to get the person
responsible for the original version of the regexps to factor that bit
out into a separate library, and then rely on that in their code, at
which point you'd have a maintained version of the regexps to use, but I
can understand that that might not be the path of least resistance.

Cheers, Phil.
-- 
|)|  Philip Hands  [+44 (0)20 8530 9560]  HANDS.COM Ltd.
|-|  http://www.hands.com/http://ftp.uk.debian.org/
|(|  Hugo-Klemm-Strasse 34,   21075 Hamburg,GERMANY


signature.asc
Description: PGP signature

Bug#872355: ITP: node-is-module -- Node.js code to check if a string is an ES6 module

[Philip Hands]

Julien Puydt  writes:

> Package: wnpp
> Severity: wishlist
> Owner: Julien Puydt 
> X-Debbugs-CC: debian-de...@lists.debian.org
>
> * Package name: node-is-module
>   Version : 1.0.0
>   Upstream Author : Jonathan Ong 
> (http://jongleberry.com)
> * URL : https://github.com/component/is-module

That URL is not correct.

Did you perhaps mean:  https://github.com/timaschew/is-module

Cheers, Phil.
-- 
|)|  Philip Hands  [+44 (0)20 8530 9560]  HANDS.COM Ltd.
|-|  http://www.hands.com/http://ftp.uk.debian.org/
|(|  Hugo-Klemm-Strasse 34,   21075 Hamburg,GERMANY


signature.asc
Description: PGP signature

Bug#872355: ITP: node-is-module -- Node.js code to check if a string is an ES6 module

[Julien Puydt]

Package: wnpp
Severity: wishlist
Owner: Julien Puydt 
X-Debbugs-CC: debian-de...@lists.debian.org

* Package name: node-is-module
  Version : 1.0.0
  Upstream Author : Jonathan Ong 
(http://jongleberry.com)
* URL : https://github.com/component/is-module
* License : Expat
  Programming Lang: JavaScript
  Description : Node.js code to check if a string is an ES6 module
 This simple code checks whether a string is the source of an ES6 module. It
 doesn't actually execute the code and doesn't check other module types and
 doesn't check other module types, so source strings without module loaders
 aren't recognized as modules.
 .
 Node.js is an event-based server-side JavaScript engine.

I plan to maintain it within the Debian Javascript Maintainer team with
all my other javascript packages. I need this one because it is a depend
of rollup-plugin-node-resolve, which is a dep of rollup, which I need to
update some of my existing packages.

Cheers,

Snark on #debian-js