Bug#872779: Bug #872779: open-vm-tools unable to manage resolution with wayland

[Raphael Hertzog]

Hi Bernd,

On Fri, 25 Aug 2017, Bernd Zeimetz wrote:
> > In the mean time, it would be great to have this in Debian. I included
> > it in Kali already. Note that you have to add "libudev-dev" and
> > "libdrm-dev" to the Build-Depends to satisfy the requirements of the
> > new plugin.
> 
> a pull request on github would be appreciated then - guess its rather
> easy as you've done the work in kali already.

Done: https://github.com/bzed/pkg-open-vm-tools/pull/11

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

Bug#872779: Bug #872779: open-vm-tools unable to manage resolution with wayland

[Bernd Zeimetz]

Hi,

> In the mean time, it would be great to have this in Debian. I included
> it in Kali already. Note that you have to add "libudev-dev" and
> "libdrm-dev" to the Build-Depends to satisfy the requirements of the
> new plugin.

a pull request on github would be appreciated then - guess its rather
easy as you've done the work in kali already.

https://github.com/bzed/pkg-open-vm-tools/

thanks,

bernd

-- 
 Bernd ZeimetzDebian GNU/Linux Developer
 http://bzed.dehttp://www.debian.org
 GPG Fingerprint: ECA1 E3F2 8E11 2432 D485  DD95 EB36 171A 6FF9 435F

Bug#872779: Bug #872779: open-vm-tools unable to manage resolution with wayland

[Raphael Hertzog]

On Thu, 24 Aug 2017, Raphael Hertzog wrote:
> I retire this as it's not true. I tested Xorg by mistake. I have not yet
> found why the patch is not working properly. This is tracked here:
> https://bugs.kali.org/view.php?id=4159

After a bit of debugging with the help of Thomas Hellstrom
, I have an updated patch that works well.

It's attached and he told me that this will be part of open-vm-tools
10.2.

In the mean time, it would be great to have this in Debian. I included
it in Kali already. Note that you have to add "libudev-dev" and
"libdrm-dev" to the Build-Depends to satisfy the requirements of the
new plugin.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/
>From c1ed3d3b50b79f10a28ace07f6339635a0bc4cbd Mon Sep 17 00:00:00 2001
From: Thomas Hellstrom 
Date: Fri, 9 Jun 2017 08:27:38 +0200
Subject: [PATCH] Add a ResolutionKMS plugin for kernel-based resolution
 switching.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Authored by:

Thomas Hellström
Deepak Singh Rawat
Ravindra Kumar

Signed-off-by: Thomas Hellstrom 
---
 open-vm-tools/configure.ac |  29 ++
 open-vm-tools/services/plugins/Makefile.am |   8 +
 .../services/plugins/resolutionKMS/COPYING | 502 +
 .../services/plugins/resolutionKMS/Makefile.am |  37 ++
 .../services/plugins/resolutionKMS/resolutionKMS.c | 493 
 .../plugins/resolutionKMS/resolutionKMS.c.orig | 465 +++
 .../services/plugins/resolutionSet/Makefile.am |  20 +
 .../plugins/resolutionSet/resolutionCommon.c   | 447 ++
 .../plugins/resolutionSet/resolutionCommon.h   |  53 +++
 .../services/plugins/resolutionSet/resolutionDL.c  | 208 +
 .../services/plugins/resolutionSet/resolutionDL.h  | 223 +
 .../services/plugins/resolutionSet/resolutionInt.h |  14 +-
 .../plugins/resolutionSet/resolutionRandR12.c  |   2 +-
 .../services/plugins/resolutionSet/resolutionSet.c |   8 +-
 .../services/plugins/resolutionSet/resolutionX11.c | 137 +++---
 15 files changed, 2552 insertions(+), 94 deletions(-)
 create mode 100644 open-vm-tools/services/plugins/resolutionKMS/COPYING
 create mode 100644 open-vm-tools/services/plugins/resolutionKMS/Makefile.am
 create mode 100644 open-vm-tools/services/plugins/resolutionKMS/resolutionKMS.c
 create mode 100644 open-vm-tools/services/plugins/resolutionKMS/resolutionKMS.c.orig
 create mode 100644 open-vm-tools/services/plugins/resolutionSet/resolutionCommon.c
 create mode 100644 open-vm-tools/services/plugins/resolutionSet/resolutionCommon.h
 create mode 100644 open-vm-tools/services/plugins/resolutionSet/resolutionDL.c
 create mode 100644 open-vm-tools/services/plugins/resolutionSet/resolutionDL.h

diff --git a/open-vm-tools/configure.ac b/open-vm-tools/configure.ac
index 7610f55..acc1e4e 100644
--- a/open-vm-tools/configure.ac
+++ b/open-vm-tools/configure.ac
@@ -235,6 +235,14 @@ AC_ARG_ENABLE(
[enable_tests="$enableval"],
[enable_tests="auto"])
 
+AC_ARG_ENABLE(
+   resolutionkms,
+   AS_HELP_STRING(
+  [--enable-resolutionkms],
+  [build the linux / unix resolutionkms module.]),
+   [],
+   [enable_resolutionkms="auto"])
+
 AM_INIT_AUTOMAKE
 
 ###
@@ -792,6 +800,7 @@ AC_CHECK_FUNCS(
   [VIX_LIBADD="$VIX_LIBADD -ldl"
LIBVMTOOLS_LIBADD="$LIBVMTOOLS_LIBADD -ldl"
VGAUTH_LIBADD="$VGAUTH_LIBADD -ldl"
+   RESOLUTIONSET_LIBADD="$RESOLUTIONSET_LIBADD -ldl"
   ],
   [AC_MSG_ERROR(
  [dlopen was not found, but is required for open-vm-tools to function properly. Please contact your OS vendor.])])])
@@ -1265,6 +1274,15 @@ if test "$os" = "linux"; then
   MODULES="$MODULES vmblock vmsync"
fi
buildHgfsmounter=yes
+   if test "x$enable_resolutionkms" != "xno"; then
+  PKG_CHECK_MODULES(
+ [LIBUDEV],
+ libdrm libudev,
+ [LIBUDEV_CFLAGS="$LIBUDEV_CFLAGS -DHAVE_LIBUDEV"],
+ [AC_MSG_WARN(
+	[Missing libdrm or libudev. The resolutionKMS plugin will search for them at run-time.])])
+  enable_resolutionkms="yes"
+   fi
 fi
 
 if test "$os" = "freebsd" || test "$os" = "kfreebsd-gnu"; then
@@ -1352,6 +1370,14 @@ else
 UDEVRULESDIR=""
 fi
 
+if test "x$enable_resolutionkms" = "xauto"; then
+   enable_resolutionkms="no"
+fi
+
+if test "x$enable_resolutionkms" = "xyes"; then
+   CPPFLAGS="$CPPFLAGS -DENABLE_RESOLUTIONKMS"
+fi
+
 AM_CONDITIONAL(BUILD_HGFSMOUNTER, test "$buildHgfsmounter" = "yes")
 AM_CONDITIONAL(LINUX, test "$os" = "linux")
 AM_CONDITIONAL(SOLARIS, test "$os" = "solaris")
@@ -1382,6 +1408,7 @@ AM_CONDITIONAL(ENABLE_CAF, test "$enable_caf" = "yes")
 AM_CONDITIONAL(HAVE_VSOCK, test "$os" = "linux")
 AM_CONDITIONAL(HAVE_MKDTEMP, test "$have_mkdtemp" = "yes")
 

Bug#872779: your mail

[Raphael Hertzog]

On Thu, 24 Aug 2017, Raphael Hertzog wrote:
> On Wed, 23 Aug 2017, Chris Cheney wrote:
> > Fedora has had this patch for ~ 4 months and OpenSUSE also has applied
> > this patch. Its doesn't appear to be clear why its not in the official
> > open-vm-tools.
> 
> I also tested in Kali and it does work fine there.

I retire this as it's not true. I tested Xorg by mistake. I have not yet
found why the patch is not working properly. This is tracked here:
https://bugs.kali.org/view.php?id=4159

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

Bug#872779: your mail

[Raphael Hertzog]

Hello,

On Wed, 23 Aug 2017, Chris Cheney wrote:
> Fedora has had this patch for ~ 4 months and OpenSUSE also has applied
> this patch. Its doesn't appear to be clear why its not in the official
> open-vm-tools.

I also tested in Kali and it does work fine there.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

Bug#872779:

[Chris Cheney]

Fedora has had this patch for ~ 4 months and OpenSUSE also has applied
this patch. Its doesn't appear to be clear why its not in the official
open-vm-tools.

- Chris

Bug#872779: open-vm-tools unable to manage resolution with wayland

[Raphaël Hertzog]

Source: open-vm-tools
Version: 2:10.1.10-1
Severity: important
Tags: upstream patch
User: de...@kali.org
Usertags: origin-kali
Control: forwarded -1 https://github.com/vmware/open-vm-tools/issues/22

With GNOME now defaulting to Wayland, this limitation is now very annoying
for VMWare users.

Apparently Fedora has a patch for this:
https://src.fedoraproject.org/rpms/open-vm-tools/blob/master/f/resolutionKMS-wayland.patch

I pinged upstream a few minutes. Would you be willing to carry this patch
until it's properly fixed upstream?

The patch is rather invasive (~ 2000 lines!). I'm going to test it in Kali
I think.

-- System Information:
Debian Release: buster/sid
  APT prefers oldoldstable
  APT policy: (500, 'oldoldstable'), (500, 'unstable'), (500, 'stable'), (500, 
'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.11.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)