Bug#873894: libsml: FTBFS on hurd-i386: O_NDELAY undeclared

2017-09-16 Thread Andreas Moog
Control: tags -1 patch

On Thu, Aug 31, 2017 at 11:00:30PM -0400, Aaron M. Ucko wrote:

> The build of libsml for hurd-i386 (admittedly not a release
> architecture) failed:
> 
>   sml_server.c: In function 'serial_port_open':
>   sml_server.c:36:44: error: 'O_NDELAY' undeclared (first use in this 
> function); did you mean 'VTDELAY'?
> int fd = open(device, O_RDWR | O_NOCTTY | O_NDELAY);
> 
> Could you please take a look?  Perhaps you can make do without
> O_NDELAY on platforms that don't define it.

Hi Aaron,

I have a patch that uses O_NONBLOCK instead, falling back to O_NDELAY when the 
first isn't available. That and the fix for #873895 allows building on hurd. 
I'll do some last polishing and will then upload a fix.

Thanks again for reporting the bug.

-- 
PGP-encrypted mails preferred
PGP Fingerprint: 74CD D9FE 5BCB FE0D 13EE 8EEA 61F3 4426 74DE 6624


signature.asc
Description: PGP signature


Bug#873894: libsml: FTBFS on hurd-i386: O_NDELAY undeclared

2017-08-31 Thread Aaron M. Ucko
Source: libsml
Version: 0.1.1+git20170608-1
Severity: important
Tags: upstream
Justification: fails to build from source

The build of libsml for hurd-i386 (admittedly not a release
architecture) failed:

  sml_server.c: In function 'serial_port_open':
  sml_server.c:36:44: error: 'O_NDELAY' undeclared (first use in this 
function); did you mean 'VTDELAY'?
int fd = open(device, O_RDWR | O_NOCTTY | O_NDELAY);

Could you please take a look?  Perhaps you can make do without
O_NDELAY on platforms that don't define it.

Thanks!

-- 
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?a...@monk.mit.edu