Bug#875605: [Piuparts-devel] Bug#875605: piuparts: esac missing in post_purge_exception script (develop branch) and yields error
On Wed, Sep 13, 2017 at 01:19:59AM +0200, Andreas Beckmann wrote: > Holger, you missed the second half of Boud's fix, so add another ;; > 23722fb34 really fix 42acc54048 aaarggg :( /me hits himself, this happens if one does too many things at once… thanks! > 4743d4aef p-r: make verbose messages more consistent also picked, thanks. > PS: I don't know if we need such a verbose changelog for a feature just > introduced in the previous patch series ... since the bug has never been > in a release I rather have too many changelog entries than too few. > PPS: I don't know why this got mismerged and lost some lines when > extracting that patch from my private devel tree - it's correct in my > production HEAD hmpf. :) deploying and once again, cleaning up the mess… -- cheers, Holger signature.asc Description: Digital signature
Bug#875605: piuparts: esac missing in post_purge_exception script (develop branch) and yields error
On 2017-09-12 17:23, Holger Levsen wrote: > On Tue, Sep 12, 2017 at 04:52:22PM +0200, Boud Roukema wrote: >> It seems to me that the problem is a missing "esac\n;;" (earlier than >> line 62). I've attached a patch that works for me on a dummy file. > > thanks a lot for this nice bug report, I've now deployed the fix and > rescheduled > 19126 affected packages in 49 suites, which translates to 1007 in stretch, > 171 in buster, 1201 in sid and me being to lazy to do stats for those 46 other > suites. Holger, you missed the second half of Boud's fix, so add another ;; 23722fb34 really fix 42acc54048 4743d4aef p-r: make verbose messages more consistent Andreas PS: I don't know if we need such a verbose changelog for a feature just introduced in the previous patch series ... since the bug has never been in a release PPS: I don't know why this got mismerged and lost some lines when extracting that patch from my private devel tree - it's correct in my production HEAD
Bug#875605: [Piuparts-devel] Bug#875605: piuparts: esac missing in post_purge_exception script (develop branch) and yields error
control: tags -1 + pending thanks On Tue, Sep 12, 2017 at 04:52:22PM +0200, Boud Roukema wrote: > This inhomog build log: > https://piuparts.debian.org/sid/fail/libinhomog0_0.1.6.1-1.log includes > the piupart version: [...] > It seems to me that the problem is a missing "esac\n;;" (earlier than > line 62). I've attached a patch that works for me on a dummy file. thanks a lot for this nice bug report, I've now deployed the fix and rescheduled 19126 affected packages in 49 suites, which translates to 1007 in stretch, 171 in buster, 1201 in sid and me being to lazy to do stats for those 46 other suites. -- cheers, Holger signature.asc Description: Digital signature
Bug#875605: piuparts: esac missing in post_purge_exception script (develop branch) and yields error
Source: piuparts Version: 0.81~201709101403~0.80-7-g42acc540 Severity: normal Tags: patch upstream Dear Maintainer, This inhomog build log: https://piuparts.debian.org/sid/fail/libinhomog0_0.1.6.1-1.log includes the piupart version: 0m0.0s INFO: piuparts version 0.81~201709101403~0.80-7-g42acc540 starting up. and the piupart error: 0m27.8s INFO: Running scripts post_purge 0m27.8s DEBUG: Starting command: ['chroot', '/srv/piuparts.debian.org/tmp/tmpYXIehL', 'tmp/scripts/post_purge_exceptions'] 0m27.8s DUMP: tmp/scripts/post_purge_exceptions: 62: tmp/scripts/post_purge_exceptions: Syntax error: end of file unexpected (expecting ";;") 0m27.8s ERROR: Command failed (status=2): ['chroot', '/srv/piuparts.debian.org/tmp/tmpYXIehL', 'tmp/scripts/post_purge_exceptions'] tmp/scripts/post_purge_exceptions: 62: tmp/scripts/post_purge_exceptions: Syntax error: end of file unexpected (expecting ";;") The bug can be reproduced with ./post_purge_exceptions dummy where dummy is a file with the five bytes '\n'. This looks like it's from a recent modification in the "develop" branch of piuparts: https://anonscm.debian.org/cgit/piuparts/piuparts.git/tree/custom-scripts/scripts/post_purge_exceptions?h=develop It seems to me that the problem is a missing "esac\n;;" (earlier than line 62). I've attached a patch that works for me on a dummy file. -- System Information: This is from the build log above: 0m20.9s DUMP: Package files: 100 /var/lib/dpkg/status release a=now 500 http://mirror.bm.debian.org/debian sid/main amd64 Packages release o=Debian,a=unstable,n=sid,l=Debian,c=main,b=amd64 origin mirror.bm.debian.org Pinned packages: 0m20.9s DEBUG: Command ok: ['chroot', '/srv/piuparts.debian.org/tmp/tmpYXIehL', 'apt-cache', 'policy'] 0m20.9s DEBUG: Starting command: ['chroot', '/srv/piuparts.debian.org/tmp/tmpYXIehL', 'apt-cache', 'policy', 'libinhomog0'] 0m21.0s DUMP: libinhomog0: Installed: (none) Candidate: 0.1.6.1-1 Version table: 0.1.6.1-1 500 500 http://mirror.bm.debian.org/debian sid/main amd64 Packages
