Bug#876093: openvas-libraries FTBFS on amd64: override_dh_auto_configure failed

[Gianfranco Costamagna]

>is due to Debian specific changes to the pcap-config tool.  This
>starting space in the output might also break other projects using
>libpcap and cmake.
>
>What do you think?  If you want I can take care of filing that bug.


yes please, I think this is worth a bug

G.

Bug#876093: openvas-libraries FTBFS on amd64: override_dh_auto_configure failed

[Lukas Schwaighofer]

Hi,

while I'm not against introducing the patch, in my opinion we should
file a bug against libpcap0.8-dev instead (or at least in addition).
The starting space in the output of
pcap-config --libs
is due to Debian specific changes to the pcap-config tool.  This
starting space in the output might also break other projects using
libpcap and cmake.

What do you think?  If you want I can take care of filing that bug.

Regards
Lukas

Bug#876093: openvas-libraries FTBFS on amd64: override_dh_auto_configure failed

[Raphael Hertzog]

Control: tag -1 + patch

Hello,

On Mon, 18 Sep 2017, SZ Lin wrote:
> CMake Error at nasl/CMakeLists.txt:147 (add_library):
> Target "openvas_nasl_shared" links to item " -lpcap" which has leading or
> trailing whitespace. This is now an error according to policy CMP0004.
> 
> This issue is caused by libpcap-dev [1], and the following patch could
> solve this issue.
> [1] 
> https://anonscm.debian.org/cgit/users/rfrancoise/libpcap.git/commit/?id=95f3623920effd288b7add3e8d2f0092c5bb46a6
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 033d122..71deefc 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -212,6 +212,7 @@ if (NOT OPENVAS_OMP_ONLY)
>  execute_process (COMMAND pcap-config --cflags
>OUTPUT_VARIABLE PCAP_CFLAGS
>OUTPUT_STRIP_TRAILING_WHITESPACE)
> +string(STRIP "${PCAP_LDFLAGS}" PCAP_LDFLAGS)
>else (PCAP_CONFIG)
>  message (STATUS "pcap-config not found, using defaults...")
>  set (PCAP_LDFLAGS "-L/usr/lib -lpcap")
> 
> Any feedback on it?

No, looks good. Feel free to push the fix to git and to submit it
upstream.

Thank you.
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

Bug#876093: openvas-libraries FTBFS on amd64: override_dh_auto_configure failed

[林上智]

I have took some time to investigate this issue

--
CMake Error at misc/CMakeLists.txt:125 (add_library):
Target "openvas_misc_shared" links to item " -lpcap" which has leading or
trailing whitespace. This is now an error according to policy CMP0004.


CMake Error at nasl/CMakeLists.txt:147 (add_library):
Target "openvas_nasl_shared" links to item " -lpcap" which has leading or
trailing whitespace. This is now an error according to policy CMP0004.


CMake Error at nasl/CMakeLists.txt:147 (add_library):
Target "openvas_nasl_shared" links to item " -lpcap" which has leading or
trailing whitespace. This is now an error according to policy CMP0004.


CMake Error at nasl/CMakeLists.txt:147 (add_library):
Target "openvas_nasl_shared" links to item " -lpcap" which has leading or
trailing whitespace. This is now an error according to policy CMP0004.

--

This issue is caused by libpcap-dev [1], and the following patch could
solve this issue.


diff --git a/CMakeLists.txt b/CMakeLists.txt
index 033d122..71deefc 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -212,6 +212,7 @@ if (NOT OPENVAS_OMP_ONLY)
 execute_process (COMMAND pcap-config --cflags
   OUTPUT_VARIABLE PCAP_CFLAGS
   OUTPUT_STRIP_TRAILING_WHITESPACE)
+string(STRIP "${PCAP_LDFLAGS}" PCAP_LDFLAGS)
   else (PCAP_CONFIG)
 message (STATUS "pcap-config not found, using defaults...")
 set (PCAP_LDFLAGS "-L/usr/lib -lpcap")

Any feedback on it?

ref:
[1]:
https://anonscm.debian.org/cgit/users/rfrancoise/libpcap.git/commit/?id=95f3623920effd288b7add3e8d2f0092c5bb46a6

--

SZ Lin (林上智) , *http://people.debian.org/~szlin
*

*Debian Developer*, debian.org.tw Administrator

4096R/ 178F 8338 B314 01E3 04FC 44BA A959 B38A 9561 F3F9


2017-09-18 19:42 GMT+08:00 SZ Lin :

> Source: openvas-libraries
> Version: 9.0.1-3
> Severity: serious
>
> https://tests.reproducible-builds.org/debian/rbuild/
> unstable/amd64/openvas-libraries_9.0.1-3.rbuild.log
>
> ...
> dh_auto_configure: cmake .. -DCMAKE_INSTALL_PREFIX=/usr
> -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=None
> -DCMAKE_INSTALL_SYSCONFDIR=/etc -DCMAKE_INSTALL_LOCALSTATEDIR=/var
> -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON 
> -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON
> -DSYSCONFDIR=/etc -DLOCALSTATEDIR=/var -DLIBDIR=/usr/lib/x86_64-linux-gnu
> -DBUILD_WITH_LDAP=ON -DCMAKE_BUILD_TYPE=release -DBUILD_WITH_RADIUS=no
> returned exit code 1
>
> debian/rules:10: recipe for target 'override_dh_auto_configure' failed
> make[1]: *** [override_dh_auto_configure] Error 2
> make[1]: Leaving directory '/build/1st/openvas-libraries-9.0.1'
> debian/rules:7: recipe for target 'build' failed
> make: *** [build] Error 2
> dpkg-buildpackage: error: debian/rules build gave error exit status 2
>
>
>
>
> --
>
> SZ Lin (林上智) , *http://people.debian.org/~szlin 
> *
>
> *Debian Developer*, debian.org.tw Administrator
>
> 4096R/ 178F 8338 B314 01E3 04FC 44BA A959 B38A 9561 F3F9
>
>
>
>
>

Bug#876093: openvas-libraries FTBFS on amd64: override_dh_auto_configure failed

[林上智]

Source: openvas-libraries
Version: 9.0.1-3
Severity: serious

https://tests.reproducible-builds.org/debian/rbuild/unstable/amd64/openvas-libraries_9.0.1-3.rbuild.log

...
dh_auto_configure: cmake .. -DCMAKE_INSTALL_PREFIX=/usr
-DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=None
-DCMAKE_INSTALL_SYSCONFDIR=/etc -DCMAKE_INSTALL_LOCALSTATEDIR=/var
-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON
-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DSYSCONFDIR=/etc
-DLOCALSTATEDIR=/var -DLIBDIR=/usr/lib/x86_64-linux-gnu
-DBUILD_WITH_LDAP=ON -DCMAKE_BUILD_TYPE=release -DBUILD_WITH_RADIUS=no
returned exit code 1

debian/rules:10: recipe for target 'override_dh_auto_configure' failed
make[1]: *** [override_dh_auto_configure] Error 2
make[1]: Leaving directory '/build/1st/openvas-libraries-9.0.1'
debian/rules:7: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2




--

SZ Lin (林上智) , *http://people.debian.org/~szlin
*

*Debian Developer*, debian.org.tw Administrator

4096R/ 178F 8338 B314 01E3 04FC 44BA A959 B38A 9561 F3F9