Bug#876321: game-data-packager: Space Quest 5 (gog) fails to build package, could not find 119.scr

[Alexandre Detiste]

control: tag -1 +pending

This is now fixed,
I've also added support for the official patch.

(but it doesn't include the "version" file,
maybe ScummVM doens't need this)

2017-11-28 11:17 GMT+01:00 Simon McVittie :
> On Fri, 22 Sep 2017 at 09:34:41 +0200, Alexandre Detiste wrote:
>> There's indeed some regression in the handling of [119.scr];
>> I have a blind guess on how to fix it;
>> but I don't have the setup_*.exe + the version 1.03 at hand to check it,
>> I'll come back at this this week-end.
>
> Did you get anywhere with this?

Bug#876321: game-data-packager: Space Quest 5 (gog) fails to build package, could not find 119.scr

[Simon McVittie]

On Fri, 22 Sep 2017 at 09:34:41 +0200, Alexandre Detiste wrote:
> There's indeed some regression in the handling of [119.scr];
> I have a blind guess on how to fix it;
> but I don't have the setup_*.exe + the version 1.03 at hand to check it,
> I'll come back at this this week-end.

Did you get anywhere with this?

Looking at the git history, spacequest5-en-data has tried to install
119.scr (it would perhaps be better to call it 119.scr?en to disambiguate)
since commit 564f051 "SpaceQuest V: add description of original
PKZIP1.0 archives", which also claimed that setup_space_quest.exe
(the omnibus GOG archive containing the whole SQ series?) contains that
file where it didn't before.

Do you have access to setup_space_quest.exe and
setup_space_quest5_2.1.0.15.exe, or complete file lists for them?

Thanks,
smcv

Bug#876321: game-data-packager: Space Quest 5 (gog) fails to build package, could not find 119.scr

[Alexandre Detiste]

tag: -1 +moreinfo

Hi,

I can't reproduce this bug.

I packaged several time from an already downloaded setup.exe &

I also simulated Lgogdownloader code path many times and it worked in all cases.
(see tools/fake_lgog.py, this is a tool to avoid nagging GoG servers all the 
time)

I don't know, maybe you are running out of space on /tmp ?

Please enable debugging by preprending DEBUG=1 in front of 
game-data-packager-command.
--verbose will also make innoextract be more verbose about it's operation.

Then --no-search can make a difference if GDP find somewhere an unexpected, 
invalid 119.scr.

In short: please provide a reproducible test case.

Thank you,

Greets,

Alexandre

Le mercredi 20 septembre 2017, 19 h 50 min 30 s CEST Charles L a écrit :
> Package: game-data-packager
> Version: 53
> Severity: normal
> 
> Dear Maintainer,
> 
> Space Quest 5 fails to build from gog sources. It downloads a fresh copy from 
> gog but something is amiss. 
> I tested the same commands in a stretch VM which has version 49.1, and that 
> was sucessful. Please let me
> know if I can be of furthar assistance.
> 
> 
> NFO:game_data_packager.build:spacequest5-en-data can be downloaded with 
> lgogdownloader
> Getting game names (1/1) 40 / 40
> Getting game info 1 / 1
> 2017-Sep-20 19:44:30 [Thread #0] Begin download: 
> setup_space_quest5_2.1.0.15.exe
> 2017-Sep-20 19:44:36 [Thread #0] Download complete: 
> setup_space_quest5_2.1.0.15.exe (@ 4.94MB/s)
> 2017-Sep-20 19:44:36 [Thread #0] Finished all tasks
> #0: Finished
> identifying 
> /tmp/gdptmp.fe17qb1t/space_quest_5_the_next_mutation/setup_space_quest5_2.1.0.15.exe
> ERROR:game_data_packager.build:could not find 119.scr:
>   expected:
> size:   13036 bytes
> md5:479163131da6d18adcf2960a993aa841
> sha1:   None
> sha256: None
> ERROR:game_data_packager.build:Unable to complete any packages because 
> downloads failed.
> 
> 

Bug#876321: game-data-packager: Space Quest 5 (gog) fails to build package, could not find 119.scr

[Charles L]

Package: game-data-packager
Version: 53
Severity: normal

Dear Maintainer,

Space Quest 5 fails to build from gog sources. It downloads a fresh copy from 
gog but something is amiss. 
I tested the same commands in a stretch VM which has version 49.1, and that was 
sucessful. Please let me
know if I can be of furthar assistance.



NFO:game_data_packager.build:spacequest5-en-data can be downloaded with 
lgogdownloader
Getting game names (1/1) 40 / 40
Getting game info 1 / 1
2017-Sep-20 19:44:30 [Thread #0] Begin download: setup_space_quest5_2.1.0.15.exe
2017-Sep-20 19:44:36 [Thread #0] Download complete: 
setup_space_quest5_2.1.0.15.exe (@ 4.94MB/s)
2017-Sep-20 19:44:36 [Thread #0] Finished all tasks
#0: Finished
identifying 
/tmp/gdptmp.fe17qb1t/space_quest_5_the_next_mutation/setup_space_quest5_2.1.0.15.exe
ERROR:game_data_packager.build:could not find 119.scr:
  expected:
size:   13036 bytes
md5:479163131da6d18adcf2960a993aa841
sha1:   None
sha256: None
ERROR:game_data_packager.build:Unable to complete any packages because 
downloads failed.


-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.12.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE= 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages game-data-packager depends on:
ii  fakeroot1.22-1
ii  python3 3.5.3-3
ii  python3-debian  0.1.30
ii  python3-yaml3.12-1+b1

Versions of packages game-data-packager recommends:
ii  game-data-packager-runtime  53

Versions of packages game-data-packager suggests:
pn  arj
ii  binutils   2.29.1-1
ii  cabextract 1.6-1+b1
ii  cdparanoia 3.10.2+debian-11+b2
pn  dynamite   
ii  gcc4:7.2.0-1d1
pn  gdebi | gdebi-kde  
ii  gir1.2-gdkpixbuf-2.0   2.36.10-1
ii  innoextract1.6-1+b2
pn  lgc-pg 
ii  lgogdownloader 3.2-1+b1
pn  lhasa | jlha-utils | lzh-archiver  
ii  make   4.1-9.1
ii  p7zip-full 16.02+dfsg-4
ii  steam  1.0.0.54-2
pn  steamcmd   
pn  unace-nonfree  
ii  unar   1.10.1-2
ii  unrar  1:5.5.8-1
pn  unshield   
ii  unzip  6.0-21
ii  vorbis-tools   1.4.0-10+b1
pn  xdelta 

-- no debconf information