Bug#878685: stretch-pu: package udftools/1.3-2
On Monday 20 November 2017 08:48:40 Adam D. Barratt wrote: > On 2017-11-20 8:39, Pali Rohár wrote: > > On Saturday 18 November 2017 20:13:14 Adam D. Barratt wrote: > > > Control: tags -1 + pending > > > > > > On Fri, 2017-11-10 at 17:59 +, Adam D. Barratt wrote: > [...] > > > > Particularly, I'd have pointed out that the changelog is illogical - > > > > it should either be 1.3-1, then the 1.3-2 unstable changes, then 1.3- > > > > 2~deb9u1, or 1.3-1 then 1.3-1+deb9u1. > > > > > > I'm not going to bother with a reject-and-reupload cycle this time, > > > but > > > please don't assume that won't happen in future. This: > > > > > > +udftools (1.3-2~deb9u1) stretch; urgency=low > > > + > > > + * Fix path to pktsetup in udftools init script > > > + > > > + -- Pali Rohár Tue, 03 Oct 2017 21:41:57 > > > +0200 > > > + > > > udftools (1.3-1) unstable; urgency=low > > > > > > is simply wrong. > > > > Ok, I would like to ask, which version to choose if uploaded package is > > exactly same as version X in unstable? As in unstable is version 1.3-2 I > > chose that suffix ~deb9u1. But I have not found any details about this > > situation in any debian manual. > > The version number is fine. The problem is that the changelog should have > included the unstable stanza for 1.3-2, with the ~deb9u1 stanza then simply > being "rebuild for stable" or something similar. This is the same as I'd > expect if you were uploading the package to stretch-backports. Ok, thanks for information! I though problem is with version string. Do you want to reupload it with fix in changelog? -- Pali Rohár pali.ro...@gmail.com
Bug#878685: stretch-pu: package udftools/1.3-2
On 2017-11-20 8:39, Pali Rohár wrote: On Saturday 18 November 2017 20:13:14 Adam D. Barratt wrote: Control: tags -1 + pending On Fri, 2017-11-10 at 17:59 +, Adam D. Barratt wrote: [...] > Particularly, I'd have pointed out that the changelog is illogical - > it should either be 1.3-1, then the 1.3-2 unstable changes, then 1.3- > 2~deb9u1, or 1.3-1 then 1.3-1+deb9u1. I'm not going to bother with a reject-and-reupload cycle this time, but please don't assume that won't happen in future. This: +udftools (1.3-2~deb9u1) stretch; urgency=low + + * Fix path to pktsetup in udftools init script + + -- Pali Rohár Tue, 03 Oct 2017 21:41:57 +0200 + udftools (1.3-1) unstable; urgency=low is simply wrong. Ok, I would like to ask, which version to choose if uploaded package is exactly same as version X in unstable? As in unstable is version 1.3-2 I chose that suffix ~deb9u1. But I have not found any details about this situation in any debian manual. The version number is fine. The problem is that the changelog should have included the unstable stanza for 1.3-2, with the ~deb9u1 stanza then simply being "rebuild for stable" or something similar. This is the same as I'd expect if you were uploading the package to stretch-backports. Regards, Adam
Bug#878685: stretch-pu: package udftools/1.3-2
On Saturday 18 November 2017 20:13:14 Adam D. Barratt wrote: > Control: tags -1 + pending > > On Fri, 2017-11-10 at 17:59 +, Adam D. Barratt wrote: > > On Fri, 2017-11-10 at 12:17 +0100, Pali Rohár wrote: > > > On Thursday 02 November 2017 21:55:54 Pali Rohár wrote: > > > > On Sunday 29 October 2017 18:19:53 Adam D. Barratt wrote: > > > > > Please prepare an upload built and tested on stable, using > > > > > "stretch" as > > > > > the changelog distribution, and versioned as either 1.3- > > > > > 1+deb9u1 > > > > > or > > > > > 1.3-2~deb9u1, depending on how the changelog is structured, and > > > > > attach > > > > > the debdiff to this bug log. > > > > > > > > Ok. I uploaded package version 1.3-2~deb9u1 to mentors, it is > > > > there: > > > > https://mentors.debian.net/package/udftools > > > > > > > > debdiff between current version in stretch and 1.3-2~deb9u1 is > > > > attached. > > > > > > Can you review it? > > > > It will be, when someone next goes through the stable-new queue. > > > > > According to highvoltage comment, Package has been uploaded to > > > Debian, > > > > Correct. However, it preferably shouldn't have been, because the > > upload wasn't agreed yet; CCing the uploader. > > I was hoping there'd have been a follow-up there. Ho hum. CCed Jonathan have not responded. I was waiting too... > > Particularly, I'd have pointed out that the changelog is illogical - > > it should either be 1.3-1, then the 1.3-2 unstable changes, then 1.3- > > 2~deb9u1, or 1.3-1 then 1.3-1+deb9u1. > > I'm not going to bother with a reject-and-reupload cycle this time, but > please don't assume that won't happen in future. This: > > +udftools (1.3-2~deb9u1) stretch; urgency=low > + > + * Fix path to pktsetup in udftools init script > + > + -- Pali Rohár Tue, 03 Oct 2017 21:41:57 +0200 > + > udftools (1.3-1) unstable; urgency=low > > is simply wrong. Ok, I would like to ask, which version to choose if uploaded package is exactly same as version X in unstable? As in unstable is version 1.3-2 I chose that suffix ~deb9u1. But I have not found any details about this situation in any debian manual. > Flagged for acceptance. > > Regards, > > Adam -- Pali Rohár pali.ro...@gmail.com
Bug#878685: stretch-pu: package udftools/1.3-2
Control: tags -1 + pending On Fri, 2017-11-10 at 17:59 +, Adam D. Barratt wrote: > On Fri, 2017-11-10 at 12:17 +0100, Pali Rohár wrote: > > On Thursday 02 November 2017 21:55:54 Pali Rohár wrote: > > > On Sunday 29 October 2017 18:19:53 Adam D. Barratt wrote: > > > > Please prepare an upload built and tested on stable, using > > > > "stretch" as > > > > the changelog distribution, and versioned as either 1.3- > > > > 1+deb9u1 > > > > or > > > > 1.3-2~deb9u1, depending on how the changelog is structured, and > > > > attach > > > > the debdiff to this bug log. > > > > > > Ok. I uploaded package version 1.3-2~deb9u1 to mentors, it is > > > there: > > > https://mentors.debian.net/package/udftools > > > > > > debdiff between current version in stretch and 1.3-2~deb9u1 is > > > attached. > > > > Can you review it? > > It will be, when someone next goes through the stable-new queue. > > > According to highvoltage comment, Package has been uploaded to > > Debian, > > Correct. However, it preferably shouldn't have been, because the > upload wasn't agreed yet; CCing the uploader. I was hoping there'd have been a follow-up there. Ho hum. > Particularly, I'd have pointed out that the changelog is illogical - > it should either be 1.3-1, then the 1.3-2 unstable changes, then 1.3- > 2~deb9u1, or 1.3-1 then 1.3-1+deb9u1. I'm not going to bother with a reject-and-reupload cycle this time, but please don't assume that won't happen in future. This: +udftools (1.3-2~deb9u1) stretch; urgency=low + + * Fix path to pktsetup in udftools init script + + -- Pali Rohár Tue, 03 Oct 2017 21:41:57 +0200 + udftools (1.3-1) unstable; urgency=low is simply wrong. Flagged for acceptance. Regards, Adam
Bug#878685: stretch-pu: package udftools/1.3-2
On Fri, 2017-11-10 at 12:17 +0100, Pali Rohár wrote: > On Thursday 02 November 2017 21:55:54 Pali Rohár wrote: > > On Sunday 29 October 2017 18:19:53 Adam D. Barratt wrote: > > > Please prepare an upload built and tested on stable, using > > > "stretch" as > > > the changelog distribution, and versioned as either 1.3-1+deb9u1 > > > or > > > 1.3-2~deb9u1, depending on how the changelog is structured, and > > > attach > > > the debdiff to this bug log. > > > > Ok. I uploaded package version 1.3-2~deb9u1 to mentors, it is > > there: > > https://mentors.debian.net/package/udftools > > > > debdiff between current version in stretch and 1.3-2~deb9u1 is > > attached. > > Can you review it? It will be, when someone next goes through the stable-new queue. > According to highvoltage comment, Package has been uploaded to > Debian, Correct. However, it preferably shouldn't have been, because the upload wasn't agreed yet; CCing the uploader. Particularly, I'd have pointed out that the changelog is illogical - it should either be 1.3-1, then the 1.3-2 unstable changes, then 1.3- 2~deb9u1, or 1.3-1 then 1.3-1+deb9u1. > but still is not available in the stable Also correct. Packages only get added to stable during point releases, and there hasn't been one of those since before you filed the request. > and link to the new queue > "stable-new: 1.3-2~deb9u1" on package > https://qa.debian.org/developer.php?login=pali.rohar%40gmail.com > generate just 404 Not Found. > > Was package lost that it generates 404? No, the link on the QA side is broken, so it's not surprising that it generates a 404. Specifically, it points to the NEW queue managed by ftp-master, which is not related to stable-new (which is a holding queue in front of proposed-updates and managed by the Release Team). Regards, Adam
Bug#878685: stretch-pu: package udftools/1.3-2
On Thursday 02 November 2017 21:55:54 Pali Rohár wrote: > On Sunday 29 October 2017 18:19:53 Adam D. Barratt wrote: > > Please prepare an upload built and tested on stable, using "stretch" as > > the changelog distribution, and versioned as either 1.3-1+deb9u1 or > > 1.3-2~deb9u1, depending on how the changelog is structured, and attach > > the debdiff to this bug log. > > Ok. I uploaded package version 1.3-2~deb9u1 to mentors, it is there: > https://mentors.debian.net/package/udftools > > debdiff between current version in stretch and 1.3-2~deb9u1 is attached. Can you review it? According to highvoltage comment, Package has been uploaded to Debian, but still is not available in the stable and link to the new queue "stable-new: 1.3-2~deb9u1" on package https://qa.debian.org/developer.php?login=pali.rohar%40gmail.com generate just 404 Not Found. Was package lost that it generates 404? -- Pali Rohár pali.ro...@gmail.com
Bug#878685: stretch-pu: package udftools/1.3-2
On Sunday 29 October 2017 18:19:53 Adam D. Barratt wrote: > Please prepare an upload built and tested on stable, using "stretch" as > the changelog distribution, and versioned as either 1.3-1+deb9u1 or > 1.3-2~deb9u1, depending on how the changelog is structured, and attach > the debdiff to this bug log. Ok. I uploaded package version 1.3-2~deb9u1 to mentors, it is there: https://mentors.debian.net/package/udftools debdiff between current version in stretch and 1.3-2~deb9u1 is attached. -- Pali Rohár pali.ro...@gmail.com diff -Nru udftools-1.3/debian/changelog udftools-1.3/debian/changelog --- udftools-1.3/debian/changelog 2017-01-24 00:28:05.0 +0100 +++ udftools-1.3/debian/changelog 2017-10-03 21:41:57.0 +0200 @@ -1,3 +1,9 @@ +udftools (1.3-2~deb9u1) stretch; urgency=low + + * Fix path to pktsetup in udftools init script + + -- Pali Rohár Tue, 03 Oct 2017 21:41:57 +0200 + udftools (1.3-1) unstable; urgency=low * New upstream release diff -Nru udftools-1.3/debian/udftools.init udftools-1.3/debian/udftools.init --- udftools-1.3/debian/udftools.init 2017-01-24 00:26:46.0 +0100 +++ udftools-1.3/debian/udftools.init 2017-10-03 21:40:26.0 +0200 @@ -30,7 +30,7 @@ PATH=/sbin:/bin:/usr/sbin:/usr/bin DESC="udftools packet writing" -PKTSETUP=/usr/bin/pktsetup +PKTSETUP=/usr/sbin/pktsetup DEFAULTFILE=/etc/default/udftools DEVICES="" NEWINTNAMES="0 1 2 3"
Bug#878685: stretch-pu: package udftools/1.3-2
Control: tags -1 + moreinfo On Sun, 2017-10-15 at 21:58 +0200, Pali Rohár wrote: > Package udftools in version 1.3-1 has specified incorrect path to the > pktsetup binary in the /etc/init.d/udftools init script which cause > that > init script does not work at all. Binary path was changed from bin to > sbin in upstream between 1.2 and 1.3 period. > > It leads to the reported bug: > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878180 > > This problem is fixed in the udftools version 1.3-2 which is now > available in the sid and buster. Diff between versions 1.3-1 and 1.3- > 2 > is attached and contains just fix for this problem. Please update > udftools to version 1.3-2 also for stretch to make > /etc/init.d/udftools init script working again in stretch. > We can't simply take the package from unstable, and the Release Team don't update packages directly. Please prepare an upload built and tested on stable, using "stretch" as the changelog distribution, and versioned as either 1.3-1+deb9u1 or 1.3-2~deb9u1, depending on how the changelog is structured, and attach the debdiff to this bug log. Regards, Adam
Bug#878685: stretch-pu: package udftools/1.3-2
Hi, On Sun Oct 15, 2017 at 21:58:16 +0200, Pali Rohár wrote: > diff -Nru udftools-1.3/debian/changelog udftools-1.3/debian/changelog > --- udftools-1.3/debian/changelog 2017-01-24 00:28:05.0 +0100 > +++ udftools-1.3/debian/changelog 2017-10-03 21:41:57.0 +0200 > @@ -1,3 +1,9 @@ > +udftools (1.3-2) unstable; urgency=low > + > + * Fix path to pktsetup in udftools init script > + > + -- Pali Rohár Tue, 03 Oct 2017 21:41:57 +0200 > + > udftools (1.3-1) unstable; urgency=low > >* New upstream release > diff -Nru udftools-1.3/debian/udftools.init udftools-1.3/debian/udftools.init > --- udftools-1.3/debian/udftools.init 2017-01-24 00:26:46.0 +0100 > +++ udftools-1.3/debian/udftools.init 2017-10-03 21:40:26.0 +0200 > @@ -30,7 +30,7 @@ > > PATH=/sbin:/bin:/usr/sbin:/usr/bin > DESC="udftools packet writing" > -PKTSETUP=/usr/bin/pktsetup > +PKTSETUP=/usr/sbin/pktsetup > DEFAULTFILE=/etc/default/udftools > DEVICES="" > NEWINTNAMES="0 1 2 3" LGTM, beside that for the upload to stable you want a different version number and suite changed. Cheers, Martin -- Martin Zobel-Helas Debian System Administrator Debian & GNU/Linux Developer Debian Listmaster http://about.me/zobel Debian Webmaster GPG Fingerprint: 6B18 5642 8E41 EC89 3D5D BDBB 53B1 AC6D B11B 627B
Bug#878685: stretch-pu: package udftools/1.3-2
Package: release.debian.org Severity: normal Tags: stretch User: release.debian@packages.debian.org Usertags: pu Package udftools in version 1.3-1 has specified incorrect path to the pktsetup binary in the /etc/init.d/udftools init script which cause that init script does not work at all. Binary path was changed from bin to sbin in upstream between 1.2 and 1.3 period. It leads to the reported bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878180 This problem is fixed in the udftools version 1.3-2 which is now available in the sid and buster. Diff between versions 1.3-1 and 1.3-2 is attached and contains just fix for this problem. Please update udftools to version 1.3-2 also for stretch to make /etc/init.d/udftools init script working again in stretch. -- System Information: Debian Release: 9.2 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 4.9.0-4-amd64 (SMP w/1 CPU core) Locale: LANG=sk_SK.UTF-8, LC_CTYPE=sk_SK.UTF-8 (charmap=UTF-8), LANGUAGE=sk_SK (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: sysvinit (via /sbin/init) diff -Nru udftools-1.3/debian/changelog udftools-1.3/debian/changelog --- udftools-1.3/debian/changelog 2017-01-24 00:28:05.0 +0100 +++ udftools-1.3/debian/changelog 2017-10-03 21:41:57.0 +0200 @@ -1,3 +1,9 @@ +udftools (1.3-2) unstable; urgency=low + + * Fix path to pktsetup in udftools init script + + -- Pali Rohár Tue, 03 Oct 2017 21:41:57 +0200 + udftools (1.3-1) unstable; urgency=low * New upstream release diff -Nru udftools-1.3/debian/udftools.init udftools-1.3/debian/udftools.init --- udftools-1.3/debian/udftools.init 2017-01-24 00:26:46.0 +0100 +++ udftools-1.3/debian/udftools.init 2017-10-03 21:40:26.0 +0200 @@ -30,7 +30,7 @@ PATH=/sbin:/bin:/usr/sbin:/usr/bin DESC="udftools packet writing" -PKTSETUP=/usr/bin/pktsetup +PKTSETUP=/usr/sbin/pktsetup DEFAULTFILE=/etc/default/udftools DEVICES="" NEWINTNAMES="0 1 2 3"
