Bug#879063: ipmitool FTBFS with debhelper 10.9.2

2017-11-01 Thread Sebastiaan Couwenberg 
Hi Jörg,

On 10/30/2017 10:33 PM, Sebastiaan Couwenberg wrote:
> On Sat, 28 Oct 2017 13:38:32 +0200 Jörg Frings-Fürst wrote:
>> here the FTBFS isn't reproducible.
>
> I can also reproduce the issue, and the patch to fix the issue is attached.
> 
> From dh_systemd_enable(1):
> 
> "
>  --name=name
>  Install the service file as name.service instead of the default
>  filename, which is the package.service. When this parameter is
>  used, dh_systemd_enable looks for and installs files named
>  debian/package.name.service instead of the usual
>  debian/package.service.
> "
> 
> Please apply upload a new ipmitool revision to fix the last remaing
> package in the freeipmi transition.

Since your package is in collab-maint, I took the liberty to push my
patch to the repo on Alioth.

Do you also want me to do an NMU, or will you upload the fixed package?

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1

Bug#879063: ipmitool FTBFS with debhelper 10.9.2

2017-10-31 Thread Niels Thykier 
Control: reassign -1 ipmitool

On Mon, 30 Oct 2017 22:57:22 +0100
=?ISO-8859-1?Q?J=F6rg_Frings-F=FCrst?=  wrote:
> reassign 879063 debhelper 10.10.5
> retitle 879063 [dh_system_enable] don't notice the debhelper naming convention
> thanks
> 
> Hi,
> 
> this is not a ipitool bug.
> 
> Fakts: 
> 
> - the service file is debian/ipmitool.ipmievd.service.
>   This fulfill the debhelper naming convention[1].
> 
> - without "dh_systemd_enable --no-enable ipmievd.service" and / or with
>   "dh_systemd_start ipmievd.service" the service file is installed[2]. 
>   This will find the service file.
> 
> Result:
> 
> Its looks like dh_systemd_enable do not notice the debhelper naming
> convention. So I reassign this bug to debhelper.
> 
> CU
> Jörg
> 
> [...]

Hi,

Sorry, but I disagree with your assertion.  :)

While the facts as such are correct, there are two facts missing:

 * When "dh_systemd_enable --no-enable ipmievd.service" is called,
   the service is *not* present in the package directory[1].
   Accordingly, you get that error.

 * The service is currently installed by dh_installinit (see the first
   three lines of [2]).  By design, dh_systemd_enable is run *before*
   dh_installinit (and dh_systemd_start is run after dh_installinit).
   - I admit that this interaction between dh_installinit and
 dh_systemd_* is way more complex than it has to be and we are
 cleaning it up for compat 11. :)

Previously, dh_systemd_enable had a behaviour depending on whether it
could read the service file.  This lead to silent "fail-to-fail"
behaviour where you could end up with a service not being enabled
instead of the build failing.  I can see that ipmitool unfortunately
relied on this "failure to fail" in the build log for stable[3].

The consequences for ipmitool:
If I am reading dh_systemd_enable correctly, it will fail to deliver a
shell snippet for notifying the system that a new service file has been
installed (and re-enable on reinstall if it was enabled prior to
uninstall).

 * While this may sound scary, I /think/ dh_installinit happens to do
  that for you in compat 10.  (Did not check too deeply though)

 * Although, it is not clear to me that your --no-enable is respected at
   all.  If it is, then it is not because of something dh_systemd_enable
   does.

Thanks,
~Niels

[1]
"""
make[1]: Leaving directory '/ipmitool-1.8.18'
   dh_installdocs
   dh_installchangelogs
   dh_installman
   debian/rules override_dh_systemd_enable
make[1]: Entering directory '/ipmitool-1.8.18'
dh_systemd_enable -v --no-enable ipmievd.service
dh_systemd_enable: Requested unit "ipmievd.service" but it was not found
in any package acted on.
dh_systemd_enable: Could not handle all of the requested services
debian/rules:36: recipe for target 'override_dh_systemd_enable' failed
make[1]: *** [override_dh_systemd_enable] Error 2
make[1]: Leaving directory 'ipmitool-1.8.18'
debian/rules:24: recipe for target 'binary' failed
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess
returned exit status 2
/ipmitool-1.8.18$ find debian/ipmitool -type f
debian/ipmitool/usr/bin/ipmitool
debian/ipmitool/usr/sbin/ipmievd
debian/ipmitool/usr/share/man/man1/ipmitool.1
debian/ipmitool/usr/share/man/man8/ipmievd.8
debian/ipmitool/usr/share/ipmitool/oem_ibm_sel_map
debian/ipmitool/usr/share/doc/ipmitool/README
debian/ipmitool/usr/share/doc/ipmitool/AUTHORS
debian/ipmitool/usr/share/doc/ipmitool/copyright
debian/ipmitool/usr/share/doc/ipmitool/changelog.Debian
debian/ipmitool/usr/share/doc/ipmitool/changelog
"""

[2]

"""
$ dh_installinit -v  --name ipmievd --error-handler=ipmievd_initd_failed
install -d debian/ipmitool/lib/systemd/system
install -p -m0644 debian/ipmitool.ipmievd.service
debian/ipmitool/lib/systemd/system/ipmievd.service
install -d debian/ipmitool/etc/default
install -p -m0644 debian/ipmitool.ipmievd.default
debian/ipmitool/etc/default/ipmievd
install -d debian/ipmitool/etc/init.d
install -p -m0755 debian/ipmitool.ipmievd.init
debian/ipmitool/etc/init.d/ipmievd
echo "# Automatically added by dh_installinit/10.10.5">>
debian/ipmitool.postinst.debhelper
sed
"s/#SCRIPT#/ipmievd/g;s/#INITPARMS#/defaults/g;s/#ERROR_HANDLER#/ipmievd_initd_failed/g"
/usr/share/debhelper/autoscripts/postinst-init-restart >>
debian/ipmitool.postinst.debhelper
echo '# End automatically added section' >>
debian/ipmitool.postinst.debhelper
echo "# Automatically added by dh_installinit/10.10.5">>
debian/ipmitool.prerm.debhelper
sed
"s/#SCRIPT#/ipmievd/g;s/#INITPARMS#/defaults/g;s/#ERROR_HANDLER#/ipmievd_initd_failed/g"
/usr/share/debhelper/autoscripts/prerm-init-norestart >>
debian/ipmitool.prerm.debhelper
echo '# End automatically added section' >>
debian/ipmitool.prerm.debhelper
echo "# Automatically added by dh_installinit/10.10.5">>
debian/ipmitool.postrm.debhelper
sed

Bug#879063: ipmitool FTBFS with debhelper 10.9.2

2017-10-30 Thread Jörg Frings-Fürst 
reassign 879063 debhelper 10.10.5
retitle 879063 [dh_system_enable] don't notice the debhelper naming convention
thanks

Hi,

this is not a ipitool bug.

Fakts: 

- the service file is debian/ipmitool.ipmievd.service.
  This fulfill the debhelper naming convention[1].

- without "dh_systemd_enable --no-enable ipmievd.service" and / or with
  "dh_systemd_start ipmievd.service" the service file is installed[2]. 
  This will find the service file.

Result:

Its looks like dh_systemd_enable do not notice the debhelper naming
convention. So I reassign this bug to debhelper.

CU
Jörg



[1] From debhelper(7):
Many debhelper commands make use of files in debian/ to control what
they do. Besides the common debian/changelog and debian/control, which
are in all packages, not just those using debhelper, some additional
files can be used to configure the behavior of specific debhelper
commands. These files are typically named debian/ package.foo (where
package of course, is replaced with the package that is being acted
on). 


[2] $ dpkg -c ipmitool_1.8.18-5_amd64.deb 
drwxr-xr-x root/root 0 2017-10-14 13:47 ./
drwxr-xr-x root/root 0 2017-10-14 13:47 ./etc/
drwxr-xr-x root/root 0 2017-10-14 13:47 ./etc/default/
-rw-r--r-- root/root   198 2014-06-01 08:41 ./etc/default/ipmievd
drwxr-xr-x root/root 0 2017-10-14 13:47 ./etc/init.d/
-rwxr-xr-x root/root  3081 2015-01-05 14:39 ./etc/init.d/ipmievd
drwxr-xr-x root/root 0 2017-10-14 13:47 ./lib/
drwxr-xr-x root/root 0 2017-10-14 13:47 ./lib/systemd/
drwxr-xr-x root/root 0 2017-10-14 13:47 ./lib/systemd/system/
-rw-r--r-- root/root   201 2014-06-01 08:45 
./lib/systemd/system/ipmievd.service
drwxr-xr-x root/root 0 2017-10-14 13:47 ./usr/
drwxr-xr-x root/root 0 2017-10-14 13:47 ./usr/bin/
-rwxr-xr-x root/root949120 2017-10-14 13:47 ./usr/bin/ipmitool
drwxr-xr-x root/root 0 2017-10-14 13:47 ./usr/sbin/
-rwxr-xr-x root/root499872 2017-10-14 13:47 ./usr/sbin/ipmievd
drwxr-xr-x root/root 0 2017-10-14 13:47 ./usr/share/
drwxr-xr-x root/root 0 2017-10-14 13:47 ./usr/share/doc/
drwxr-xr-x root/root 0 2017-10-14 13:47 ./usr/share/doc/ipmitool/
-rw-r--r-- root/root   188 2015-07-25 08:34 ./usr/share/doc/ipmitool/AUTHORS
-rw-r--r-- root/root  6239 2016-02-27 10:02 
./usr/share/doc/ipmitool/README.gz
-rw-r--r-- root/root  8215 2017-10-14 13:47 
./usr/share/doc/ipmitool/changelog.Debian.gz
-rw-r--r-- root/root 17336 2016-10-08 10:08 
./usr/share/doc/ipmitool/changelog.gz
-rw-r--r-- root/root  3129 2017-01-03 07:04 
./usr/share/doc/ipmitool/copyright
drwxr-xr-x root/root 0 2017-10-14 13:47 ./usr/share/ipmitool/
-rw-r--r-- root/root 44550 2017-10-14 13:47 
./usr/share/ipmitool/oem_ibm_sel_map
drwxr-xr-x root/root 0 2017-10-14 13:47 ./usr/share/man/
drwxr-xr-x root/root 0 2017-10-14 13:47 ./usr/share/man/man1/
-rw-r--r-- root/root 26522 2017-10-14 13:47 
./usr/share/man/man1/ipmitool.1.gz
drwxr-xr-x root/root 0 2017-10-14 13:47 ./usr/share/man/man8/
-rw-r--r-- root/root  2969 2017-10-14 13:47 
./usr/share/man/man8/ipmievd.8.gz


-- 
New:
GPG Fingerprint: 63E0 075F C8D4 3ABB 35AB  30EE 09F8 9F3C 8CA1 D25D
GPG key (long) : 09F89F3C8CA1D25D
GPG Key: 8CA1D25D
CAcert Key S/N : 0E:D4:56

Old pgp Key: BE581B6E (revoked since 2014-12-31).

Jörg Frings-Fürst
D-54470 Lieser

Threema: SYR8SJXB
Wire:  @joergfringsfuerst
Skype: joergpenguin
Ring:  jff

IRC: j_...@freenode.net
 j_...@oftc.net

My wish list: 
 - Please send me a picture from the nature at your home.


signature.asc
Description: This is a digitally signed message part

Bug#879063: ipmitool FTBFS with debhelper 10.9.2

2017-10-30 Thread Sebastiaan Couwenberg 
Control: tags -1 patch

Hi Jörg,

On Sat, 28 Oct 2017 13:38:32 +0200 Jörg Frings-Fürst wrote:
> here the FTBFS isn't reproducible.
I can also reproduce the issue, and the patch to fix the issue is attached.

>From dh_systemd_enable(1):

"
 --name=name
 Install the service file as name.service instead of the default
 filename, which is the package.service. When this parameter is
 used, dh_systemd_enable looks for and installs files named
 debian/package.name.service instead of the usual
 debian/package.service.
"

Please apply upload a new ipmitool revision to fix the last remaing
package in the freeipmi transition.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1
>From f26d0f96e0d31aed9b5420f25da92e6a663362be Mon Sep 17 00:00:00 2001
From: Bas Couwenberg 
Date: Mon, 30 Oct 2017 22:20:40 +0100
Subject: [PATCH] Use dh_systemd_enable --name to install
 ipmitool.ipmievd.service. (closes: #879063)

---
 debian/changelog | 8 
 debian/rules | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index 8d860cb..a245b8f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+ipmitool (1.8.18-4.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Use dh_systemd_enable --name to install ipmitool.ipmievd.service.
+(closes: #879063)
+
+ -- Bas Couwenberg   Mon, 30 Oct 2017 22:19:35 +0100
+
 ipmitool (1.8.18-4) unstable; urgency=medium
 
   * Migrate to OpenSSL1.1 (Closes_# 853782):
diff --git a/debian/rules b/debian/rules
index 7aa7d87..2862de5 100755
--- a/debian/rules
+++ b/debian/rules
@@ -33,7 +33,7 @@ override_dh_installinit:
 	dh_installinit --name ipmievd --error-handler=ipmievd_initd_failed
 
 override_dh_systemd_enable:
-	dh_systemd_enable --no-enable ipmievd.service
+	dh_systemd_enable --no-enable --name=ipmievd
 
 override_dh_auto_configure:
 	dh_auto_configure -- --prefix=/usr --with-kerneldir --mandir=/usr/share/man --enable-intf-dummy $(extra_config_opts)
-- 
2.11.0

Bug#879063: ipmitool FTBFS with debhelper 10.9.2

2017-10-30 Thread Adrian Bunk 
Control: reopen -1

On Mon, Oct 30, 2017 at 08:35:20PM +0100, Jörg Frings-Fürst wrote:
> Hi Adrian,
> 
> I use debhelper 10.10.5.
> 
> The bug looks like[1]. Debhelper is fixed since 10.10.
> 
> So I close this bug too.

Which part of my statement
  It is still 100% reproducible both for me and in reproducible builds.
was unclear?

> CU
> Jörg
>...

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

Bug#879063: ipmitool FTBFS with debhelper 10.9.2

2017-10-30 Thread Jörg Frings-Fürst 
Hi Adrian,

I use debhelper 10.10.5.

The bug looks like[1]. Debhelper is fixed since 10.10.

So I close this bug too.

CU
Jörg

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878911



-- 
New:
GPG Fingerprint: 63E0 075F C8D4 3ABB 35AB  30EE 09F8 9F3C 8CA1 D25D
GPG key (long) : 09F89F3C8CA1D25D
GPG Key: 8CA1D25D
CAcert Key S/N : 0E:D4:56

Old pgp Key: BE581B6E (revoked since 2014-12-31).

Jörg Frings-Fürst
D-54470 Lieser

Threema: SYR8SJXB
Wire:  @joergfringsfuerst
Skype: joergpenguin
Ring:  jff

IRC: j_...@freenode.net
 j_...@oftc.net

My wish list: 
 - Please send me a picture from the nature at your home.


signature.asc
Description: This is a digitally signed message part

Bug#879063: ipmitool FTBFS with debhelper 10.9.2

2017-10-29 Thread Adrian Bunk 
On Sat, Oct 28, 2017 at 01:38:32PM +0200, Jörg Frings-Fürst wrote:
> tags 879063 + unreproducible
> 
> Hi,
> 
> here the FTBFS isn't reproducible.

It is still 100% reproducible both for me and in reproducible builds.

Which debhelper version are you using?

> CU
> Jörg

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

Bug#879063: ipmitool FTBFS with debhelper 10.9.2

2017-10-28 Thread Jörg Frings-Fürst 
tags 879063 + unreproducible


Hi,

here the FTBFS isn't reproducible.

CU
Jörg

-- 
New:
GPG Fingerprint: 63E0 075F C8D4 3ABB 35AB  30EE 09F8 9F3C 8CA1 D25D
GPG key (long) : 09F89F3C8CA1D25D
GPG Key: 8CA1D25D
CAcert Key S/N : 0E:D4:56

Old pgp Key: BE581B6E (revoked since 2014-12-31).

Jörg Frings-Fürst
D-54470 Lieser

Threema: SYR8SJXB
Wire:  @joergfringsfuerst
Skype: joergpenguin
Ring:  jff

IRC: j_...@freenode.net
 j_...@oftc.net

My wish list: 
 - Please send me a picture from the nature at your home.


signature.asc
Description: This is a digitally signed message part

Bug#879063: ipmitool FTBFS with debhelper 10.9.2

2017-10-18 Thread Adrian Bunk 
Source: ipmitool
Version: 1.8.18-4
Severity: serious

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/ipmitool.html

...
   debian/rules override_dh_systemd_enable
make[1]: Entering directory '/build/1st/ipmitool-1.8.18'
dh_systemd_enable --no-enable ipmievd.service
dh_systemd_enable: Could not find "ipmievd.service" in the /lib/systemd/system 
directory of ipmitool. This could be a typo, or using Also= with a service file 
from another package. Please check carefully that this message is harmless.
dh_systemd_enable: Cannot open(ipmievd.service) to check for [Install]
debian/rules:36: recipe for target 'override_dh_systemd_enable' failed
make[1]: *** [override_dh_systemd_enable] Error 2