Bug#879599: stretch-pu: package charmtimetracker/1.11.4-1

[Sandro Knauß]

Hey,

> You definitely can't re-upload +deb9u1, no. It's up to you whether you
> consider it worth a new upload now, or just want to correct it in your
> VCS ready for whenever you next need to upload. (I'd generally suggest
> the latter.)

me also thinks it is not worth uploading again a version with only these 
changes. Fixed them in VCS already.
 
> The above output is from running lintian (on the ftp-master mirror)
> against the package you uploaded. If it didn't tell you when running it
> locally, maybe you somehow didn't run it against all the files? (Or have
> an old version?)

okay running against sources.changes excludes the changelog. when running 
against a amd64.changes I see the issues, too.

Best Reagrds,

sandro

signature.asc
Description: This is a digitally signed message part.

Bug#879599: stretch-pu: package charmtimetracker/1.11.4-1

[Adam D. Barratt]

On 2017-11-28 17:10, Sandro Knauß wrote:

Hey,

Apologies for not having spotted them pre-upload, but for reference 
our

QA checks spotted a couple of typoes in the changelog:

+W: spelling-error-in-changelog discription description
+W: spelling-error-in-changelog pacakge package


okay thx. So I need to fix those and upload a debian/1.11.4-1+deb9u2? 
or can i

reupload deb9u1?


You definitely can't re-upload +deb9u1, no. It's up to you whether you 
consider it worth a new upload now, or just want to correct it in your 
VCS ready for whenever you next need to upload. (I'd generally suggest 
the latter.)



Are those automated testes? Why doesn't have linitian told me those? It
already warns me about many other typos...


The above output is from running lintian (on the ftp-master mirror) 
against the package you uploaded. If it didn't tell you when running it 
locally, maybe you somehow didn't run it against all the files? (Or have 
an old version?)


Regards,

Adam

Bug#879599: stretch-pu: package charmtimetracker/1.11.4-1

[Sandro Knauß]

Hey,

> Apologies for not having spotted them pre-upload, but for reference our
> QA checks spotted a couple of typoes in the changelog:
> 
> +W: spelling-error-in-changelog discription description
> +W: spelling-error-in-changelog pacakge package

okay thx. So I need to fix those and upload a debian/1.11.4-1+deb9u2? or can i 
reupload deb9u1?

Are those automated testes? Why doesn't have linitian told me those? It 
already warns me about many other typos...

Best Regrads,

sandro




signature.asc
Description: This is a digitally signed message part.

Bug#879599: stretch-pu: package charmtimetracker/1.11.4-1

[Adam D. Barratt]

On Sun, 2017-11-19 at 22:38 +, Adam D. Barratt wrote:
> Uploaded and flagged for acceptance.

Apologies for not having spotted them pre-upload, but for reference our
QA checks spotted a couple of typoes in the changelog:

+W: spelling-error-in-changelog discription description
+W: spelling-error-in-changelog pacakge package

Regards,

Adam

Bug#879599: stretch-pu: package charmtimetracker/1.11.4-1

[Adam D. Barratt]

Control: tags -1 + pending

On Sat, 2017-11-18 at 17:54 +, Adam D. Barratt wrote:
> Control: tags -1 + confirmed
> 
> On Sun, 2017-11-05 at 15:35 +0100, Sandro Knauß wrote:
> > Control: tags -1 - moreinfo
> > > 
> > > You also introduced a new issue in the short description:
> > > 
> > > -Description: Cross-Platform Time Tracker
> > > +Description: a task based Time Tracker
> > > 
> > > The convention is that the description can finish the sentence
> > > "$package (is a|contains)".
> > 
> >  
> > > I note that #873917 isn't fixed in unstable currently. I realise
> > > it's a
> > > trivial change, but we should still ensure that such things are
> > > fixed
> > > in unstable, so as not to regress between releases.
> > 
> > Well because  #873917 is quite trivial i don't want to push a new
> > version with 
> > only this patch to unstable. I have nothing more to fix for
> > charmtimetracker 
> > at my list at the moment for unstable.
> 
> [...]
> > Should I rework the description for unstable and pu? And/or remove
> > it
> > from the 
> > pu? If you want me first to upload the fix to unstable, I'll do
> > this.
> > 
> 
> Feel free to upload, but the fix should land in unstable asap.

Uploaded and flagged for acceptance.

Regards,

Adam

Bug#879599: stretch-pu: package charmtimetracker/1.11.4-1

[Adam D. Barratt]

Control: tags -1 + confirmed

On Sun, 2017-11-05 at 15:35 +0100, Sandro Knauß wrote:
> Control: tags -1 - moreinfo
> > 
> > You also introduced a new issue in the short description:
> > 
> > -Description: Cross-Platform Time Tracker
> > +Description: a task based Time Tracker
> > 
> > The convention is that the description can finish the sentence
> > "$package (is a|contains)".
> 
>  
> > I note that #873917 isn't fixed in unstable currently. I realise
> > it's a
> > trivial change, but we should still ensure that such things are
> > fixed
> > in unstable, so as not to regress between releases.
> 
> Well because  #873917 is quite trivial i don't want to push a new
> version with 
> only this patch to unstable. I have nothing more to fix for
> charmtimetracker 
> at my list at the moment for unstable.
[...]
> Should I rework the description for unstable and pu? And/or remove it
> from the 
> pu? If you want me first to upload the fix to unstable, I'll do this.
> 

Feel free to upload, but the fix should land in unstable asap.

Regards,

Adam

Bug#879599: stretch-pu: package charmtimetracker/1.11.4-1

[Sandro Knauß]

Control: tags -1 - moreinfo
> 
> You also introduced a new issue in the short description:
> 
> -Description: Cross-Platform Time Tracker
> +Description: a task based Time Tracker
> 
> The convention is that the description can finish the sentence
> "$package (is a|contains)".
 
> I note that #873917 isn't fixed in unstable currently. I realise it's a
> trivial change, but we should still ensure that such things are fixed
> in unstable, so as not to regress between releases.

Well because  #873917 is quite trivial i don't want to push a new version with 
only this patch to unstable. I have nothing more to fix for charmtimetracker 
at my list at the moment for unstable.

I thought it also makes sense to fix the description in pu, but if this adds 
more issues than solving it, than maybe remove it from pu. I was also 
wondering:  if I change the description then the translations needs to be 
updated. Does the system behind the translations can handle this? Or are the 
translations fixed for stretch?

Should I rework the description for unstable and pu? And/or remove it from the 
pu? If you want me first to upload the fix to unstable, I'll do this.

I'm happy with all ways :)

Best Regards,

sandro

signature.asc
Description: This is a digitally signed message part.

Bug#879599: stretch-pu: package charmtimetracker/1.11.4-1

[Adam D. Barratt]

Control: tags -1 + moreinfo

On Mon, 2017-10-23 at 11:36 +0200, Sandro Knauß wrote:
> charmtimetracker is currently not installable in stable (#873918),
> this
> pu fixes this. Additionally I also fixed #873917, to have a better
> wording in the short discription. I made sure, that it still builds
> for stable on amd64.
> 

You also introduced a new issue in the short description:

-Description: Cross-Platform Time Tracker
+Description: a task based Time Tracker

The convention is that the description can finish the sentence
"$package (is a|contains)".

I note that #873917 isn't fixed in unstable currently. I realise it's a
trivial change, but we should still ensure that such things are fixed
in unstable, so as not to regress between releases.

Regards,

Adam

Bug#879599: stretch-pu: package charmtimetracker/1.11.4-1

[Sandro Knauß]

Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu

Hey,

charmtimetracker is currently not installable in stable (#873918), this
pu fixes this. Additionally I also fixed #873917, to have a better
wording in the short discription. I made sure, that it still builds for stable 
on amd64.

Best Regards,

sandro

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'stable-updates'), (500, 
'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.13.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=en_US 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru charmtimetracker-1.11.4/debian/changelog 
charmtimetracker-1.11.4/debian/changelog
--- charmtimetracker-1.11.4/debian/changelog2016-11-10 09:33:30.0 
+0100
+++ charmtimetracker-1.11.4/debian/changelog2017-10-23 11:20:46.0 
+0200
@@ -1,3 +1,12 @@
+charmtimetracker (1.11.4-1+deb9u1) stretch; urgency=medium
+
+  * Fix "Missing binary dependency on libqt5sql5-sqlite" (Closes: #873918)
+- Adding libqt5sql5-sqlite to depends list of charmtimetracker.
+  * Fix "Please drop "Cross-Platform" from package description" rewrite
+discription for the pacakge (Closes: #873917)
+
+ -- Sandro Knauß   Mon, 23 Oct 2017 11:20:46 +0200
+
 charmtimetracker (1.11.4-1) unstable; urgency=medium
 
   [ Sandro Knauß ]
diff -Nru charmtimetracker-1.11.4/debian/control 
charmtimetracker-1.11.4/debian/control
--- charmtimetracker-1.11.4/debian/control  2016-11-10 09:27:15.0 
+0100
+++ charmtimetracker-1.11.4/debian/control  2017-10-23 11:20:46.0 
+0200
@@ -20,8 +20,8 @@
 
 Package: charmtimetracker
 Architecture: any
-Depends: ${misc:Depends}, ${shlibs:Depends}
-Description: Cross-Platform Time Tracker
+Depends: libqt5sql5-sqlite, ${misc:Depends}, ${shlibs:Depends}
+Description: a task based Time Tracker
  It is built around two major ideas - tasks and events.
  Tasks are the things time is spend on, repeatedly. Tasks
  are done in events.