Bug#879825: game-data-packager: Fails to build tyrian-data

[Simon McVittie]

Control: tags -1 - moreinfo
Control: clone -1 -2
Control: retitle -2 game-data-packager: Fails to build tyrian-data with 
fakeroot-ng providing fakeroot
Control: reassign -2 fakeroot-ng
Control: retitle -1 game-data-packager: Avoid using fakeroot if dpkg is new 
enough
Control: severity -1 wishlist
Control: tags -1 + pending

On Sat, 28 Oct 2017 at 14:45:16 +0300, Voker57 wrote:
> On Sat, Oct 28, 2017 at 01:30:57PM +0200, Alexandre Detiste wrote:
> > I can't reproduce [game-data-packager hanging indefinitely while
> > running fakeroot dpkg-deb -b].
> > 
> > I see you are using "pseudo" instead of the regular fakeroot,
> > can you try again with fakeroot ?
> 
> In fact I'm using fakeroot-ng. Command finishes successfully with
> fakeroot-pseudo, as well as with real root.

I can reproduce this. Steps to reproduce, which require Internet access
and willingness to enable contrib, but do not require buying any
particular commercial games:

apt install game-data-packager=53
update-alternatives --config fakeroot# and select fakeroot-sysv
game-data-packager -d . -n --debug tyrian# this works fine
update-alternatives --config fakeroot# and select fakeroot-ng
game-data-packager -d . -n --debug tyrian# this hangs at the last step

This seems like it's really a bug in fakeroot-ng: it provides an
alternative for fakeroot, but doesn't successfully do something that
can succeed under the original fakeroot or under pseudo.

Please use the newly cloned bug number to represent the fakeroot-ng bug.

On Sat, 28 Oct 2017 at 13:54:20 +0200, Alexandre Detiste wrote:
> Moreover: from dpkg 1.19.0 we can build the package without fakeroot:
> 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=291320
>* Add support to dpkg-deb for rootless builds, by setting the owner and
>  group for the control.tar entries to root:root, and making it possible to
>  do the same for the data.tar entries via the new --root-owner-group 
> option.

I'll use Bug#879825 to represent this. It seems to be fairly
straightforward, and I've pushed a patch to do so.

> This would reach testing today (maybe),
> so we'd still have to keep a depedency on "dpkg (>= 1.19.0) |
> fakeroot" for years on
> + check dpkg version it a run-time.

I think that would be fine.

smcv

Bug#879825: game-data-packager: Fails to build tyrian-data

[Voker57]

On Sat, Oct 28, 2017 at 01:54:20PM +0200, Alexandre Detiste wrote:
> 2017-10-28 13:45 GMT+02:00 Voker57 :
> > Command finishes successfully
> 
> So where's the bug ?

It still fails with fakeroot-ng set as alternative for fakeroot.

Bug#879825: game-data-packager: Fails to build tyrian-data

[Alexandre Detiste]

2017-10-28 13:45 GMT+02:00 Voker57 :
> Command finishes successfully

So where's the bug ?

---

Moreover: from dpkg 1.19.0 we can build the package without fakeroot:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=291320
   * Add support to dpkg-deb for rootless builds, by setting the owner and
 group for the control.tar entries to root:root, and making it possible to
 do the same for the data.tar entries via the new --root-owner-group option.
 Based on a patch by Niels Thykier . Closes: #291320

This would reach testing today (maybe),
so we'd still have to keep a depedency on "dpkg (>= 1.19.0) |
fakeroot" for years on
+ check dpkg version it a run-time.

Greets,

Bug#879825: game-data-packager: Fails to build tyrian-data

[Voker57]

On Sat, Oct 28, 2017 at 01:30:57PM +0200, Alexandre Detiste wrote:
> control: tag -1 +moreinfo
> 
> Hi,
> 
> I can't reproduce this.
> 
> I see you are using "pseudo" instead of the regular fakeroot,
> can you try again with fakeroot ?

In fact I'm using fakeroot-ng. Command finishes successfully with
fakeroot-pseudo, as well as with real root.

> 
> (switchable with update-alternatives, I guess)
> 
> dpkg-deb could benefit from a progress indicator, but no one is working on 
> this:
> 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=778451;msg=5
> 
> Greets,
> 

Bug#879825: game-data-packager: Fails to build tyrian-data

[Alexandre Detiste]

control: tag -1 +moreinfo

Hi,

I can't reproduce this.

I see you are using "pseudo" instead of the regular fakeroot,
can you try again with fakeroot ?

(switchable with update-alternatives, I guess)

dpkg-deb could benefit from a progress indicator, but no one is working on this:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=778451;msg=5

Greets,

2017-10-26 13:34 GMT+02:00 Voker57 :
>
> Package: game-data-packager
> Version: 53
> Severity: important
>
> Dear Maintainer,
>
> I ran `game-data-packager tyrian` to download Tyrian data, but it hang
> up on building package. Log is attached.
>
> -- System Information:
> Debian Release: buster/sid
>   APT prefers unstable
>   APT policy: (500, 'unstable'), (500, 'oldstable')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386, arm64
>
> Kernel: Linux 4.13.0-1-amd64 (SMP w/8 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
> LANGUAGE=en_US:en (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: sysvinit (via /sbin/init)
>
> Versions of packages game-data-packager depends on:
> ii  pseudo [fakeroot]  1.8.1+git20161012-2
> ii  python33.6.3-1
> ii  python3-debian 0.1.31
> ii  python3-yaml   3.12-1+b1
>
> Versions of packages game-data-packager recommends:
> pn  game-data-packager-runtime  
>
> Versions of packages game-data-packager suggests:
> pn  arj
> ii  binutils   2.29.1-6
> ii  cabextract 1.6-1+b1
> ii  cdparanoia 3.10.2+debian-11+b2
> pn  dynamite   
> ii  gcc4:7.2.0-1d1
> pn  gdebi | gdebi-kde  
> ii  gir1.2-gdkpixbuf-2.0   2.36.11-1
> pn  innoextract
> pn  lgc-pg 
> pn  lgogdownloader 
> pn  lhasa | jlha-utils | lzh-archiver  
> ii  make   4.1-9.1
> ii  p7zip-full 16.02+dfsg-4
> ii  steam  1.0.0.54-2
> ii  steamcmd   0~20130205-1
> pn  unace-nonfree  
> pn  unar   
> ii  unrar  1:5.5.8-1
> pn  unshield   
> ii  unzip  6.0-21
> ii  vorbis-tools   1.4.0-10+b1
> ii  xdelta 1.1.3-9.1+b1
>
> -- no debconf information

Bug#879825: game-data-packager: Fails to build tyrian-data

[Voker57]

Package: game-data-packager
Version: 53
Severity: important

Dear Maintainer,

I ran `game-data-packager tyrian` to download Tyrian data, but it hang
up on building package. Log is attached.

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, arm64

Kernel: Linux 4.13.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages game-data-packager depends on:
ii  pseudo [fakeroot]  1.8.1+git20161012-2
ii  python33.6.3-1
ii  python3-debian 0.1.31
ii  python3-yaml   3.12-1+b1

Versions of packages game-data-packager recommends:
pn  game-data-packager-runtime  

Versions of packages game-data-packager suggests:
pn  arj
ii  binutils   2.29.1-6
ii  cabextract 1.6-1+b1
ii  cdparanoia 3.10.2+debian-11+b2
pn  dynamite   
ii  gcc4:7.2.0-1d1
pn  gdebi | gdebi-kde  
ii  gir1.2-gdkpixbuf-2.0   2.36.11-1
pn  innoextract
pn  lgc-pg 
pn  lgogdownloader 
pn  lhasa | jlha-utils | lzh-archiver  
ii  make   4.1-9.1
ii  p7zip-full 16.02+dfsg-4
ii  steam  1.0.0.54-2
ii  steamcmd   0~20130205-1
pn  unace-nonfree  
pn  unar   
ii  unrar  1:5.5.8-1
pn  unshield   
ii  unzip  6.0-21
ii  vorbis-tools   1.4.0-10+b1
ii  xdelta 1.1.3-9.1+b1

-- no debconf information
DEBUG:game_data_packager:No special code for tyrian: No module named 
'game_data_packager.games.tyrian'
DEBUG:__main__:obeying PRESERVE=yes in configuration
DEBUG:__main__:parsed command-line arguments into: 
Namespace(binary_executables=False, compress=None, demo=False, destination='.', 
download=True, gain_root_command='', install=False, install_method='', 
packages=[], paths=[], save_downloads=None, search=True, shortname='tyrian', 
target_distro='generic', target_format='deb', verbose=True)
DEBUG:game_data_packager:loading full data
DEBUG:game_data_packager:... 
/usr/share/games/game-data-packager/vfs.zip/tyrian.groups
DEBUG:game_data_packager:Adding group: archive
DEBUG:game_data_packager:Adding group: wanted
DEBUG:game_data_packager:Adding file: tyrian21.zip
DEBUG:game_data_packager:Adding file: cubetxt1.dat
DEBUG:game_data_packager:Adding file: cubetxt2.dat
DEBUG:game_data_packager:Adding file: cubetxt3.dat
DEBUG:game_data_packager:Adding file: cubetxt4.dat
DEBUG:game_data_packager:Adding file: demo.1
DEBUG:game_data_packager:Adding file: demo.2
DEBUG:game_data_packager:Adding file: demo.3
DEBUG:game_data_packager:Adding file: demo.4
DEBUG:game_data_packager:Adding file: demo.5
DEBUG:game_data_packager:Adding file: estsc.shp
DEBUG:game_data_packager:Adding file: exitmsg.bin
DEBUG:game_data_packager:Adding file: levels1.dat
DEBUG:game_data_packager:Adding file: levels2.dat
DEBUG:game_data_packager:Adding file: levels3.dat
DEBUG:game_data_packager:Adding file: levels4.dat
DEBUG:game_data_packager:Adding file: loudness.awe
DEBUG:game_data_packager:Adding file: manual.doc
DEBUG:game_data_packager:Adding file: music.mus
DEBUG:game_data_packager:Adding file: netarena.pcx
DEBUG:game_data_packager:Adding file: netfont1.pcx
DEBUG:game_data_packager:Adding file: netfont2.pcx
DEBUG:game_data_packager:Adding file: netmega.pcx
DEBUG:game_data_packager:Adding file: netterm.int
DEBUG:game_data_packager:Adding file: newsh#.shp
DEBUG:game_data_packager:Adding file: newsh0.shp
DEBUG:game_data_packager:Adding file: newsh1.shp
DEBUG:game_data_packager:Adding file: newsh2.shp
DEBUG:game_data_packager:Adding file: newsh3.shp
DEBUG:game_data_packager:Adding file: newsh4.shp
DEBUG:game_data_packager:Adding file: newsh5.shp
DEBUG:game_data_packager:Adding file: newsh6.shp
DEBUG:game_data_packager:Adding file: newsh7.shp
DEBUG:game_data_packager:Adding file: newsh8.shp
DEBUG:game_data_packager:Adding file: newsh9.shp
DEBUG:game_data_packager:Adding file: newsh^.shp
DEBUG:game_data_packager:Adding file: newsha.shp
DEBUG:game_data_packager:Adding file: newshb.shp
DEBUG:game_data_packager:Adding file: newshc.shp
DEBUG:game_data_packager:Adding file: newshd.shp
DEBUG:game_data_packager:Adding file: newshe.shp
DEBUG:game_data_packager:Adding file: newshf.shp
DEBUG:game_data_packager:Adding file: newshg.shp
DEBUG:game_data_packager:Adding file: newshh.shp
DEBUG:game_data_packager:Adding file: newshi.shp
DEBUG:game_data_packager:Adding file: newshj.shp