Bug#879960: libqt5sql5-psql: [libqt5sql5-psql] basic support postgresql-10

2017-11-23 Thread Diederik de Haas 
On donderdag 23 november 2017 09:34:40 CET Dmitry Shachnev wrote:
> Thank you. The fix is applied in Git now, will be in the next upload.

\o/


signature.asc
Description: This is a digitally signed message part.

Bug#879960: libqt5sql5-psql: [libqt5sql5-psql] basic support postgresql-10

2017-11-23 Thread Dmitry Shachnev 
Control: tags -1 +pending

Hi Damir!

On Thu, Nov 23, 2017 at 08:23:47AM +0600, Damir Islamov wrote:
> Hi Dmitry,
>
> This has been fixed in Qt 5.9.3.
> See ChangeId: Ib19ae7ba426f262e80c52670e7ecb3532ff460a0
> https://codereview.qt-project.org/#/c/209141/

Thank you. The fix is applied in Git now, will be in the next upload.

I cannot do an upload right now, the release team asked us to wait until the
current upload migrates to testing first.

--
Dmitry Shachnev


signature.asc
Description: PGP signature

Bug#879960: libqt5sql5-psql: [libqt5sql5-psql] basic support postgresql-10

2017-11-22 Thread Damir Islamov 

Hi Dmitry,

This has been fixed in Qt 5.9.3.
See ChangeId: Ib19ae7ba426f262e80c52670e7ecb3532ff460a0 
https://codereview.qt-project.org/#/c/209141/
The patch: 
https://codereview.qt-project.org/gitweb?p=qt/qtbase.git;a=commitdiff;h=435c4b2ccbbb7284918dd2d4a14f8e44c3977d98;hp=ad36da8ff416501e249beb098e5b84eaa2fba43d


---
Sincerely yours/С уважением,
Damir Islamov/Дамир Исламов


0xB5653FEF.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature

Bug#879960: libqt5sql5-psql: [libqt5sql5-psql] basic support postgresql-10

2017-10-31 Thread Dmitry Shachnev 
Hi Damir!

On Fri, Oct 27, 2017 at 11:34:08PM +0700, Damir R. Islamov wrote:
> Dear Maintainer,
>
> * QT-5.9.[1,2] (and future QT-5.10?) in the upstream do not support
>   PostgreSQL 10.
> * Future Debian release (at least the current SID) includes PostgreSQL 10.
> * Users who use QPSQLDriver in there applications (e.g. who use
>   akonadi-backend-postgresql) are not able to work completely.
> * I suppose that a basic support of PostgreSQL 10 in QPSQLDriver will
>   provide (at least temporal) solution until QT team support in the
>   upstream.

Do you have any upstream bug link for this? If not, please create a bug
on https://bugreports.qt.io/ or, even better, submit your patch to
https://codereview.qt-project.org/ (see [1] for the instructions).

We usually do not add patches that are not approved upstream and are not
going to be merged upstream in near future.

[1]: http://wiki.qt.io/Setting_up_Gerrit

--
Dmitry Shachnev


signature.asc
Description: PGP signature

Bug#879960: libqt5sql5-psql: [libqt5sql5-psql] basic support postgresql-10

2017-10-29 Thread Damir Islamov 
It is the same issue


--
Sincerely yours
Damir Islamov
email: da...@trefle.ru
mobile: +7-903-904-6049

signature.asc
Description: This is a digitally signed message part.

Bug#879960: libqt5sql5-psql: [libqt5sql5-psql] basic support postgresql-10

2017-10-28 Thread Diederik de Haas 
On Friday, October 27, 2017 11:34:08 PM CEST Damir R. Islamov wrote:
> Tags: patch
> 
>* QT-5.9.[1,2] (and future QT-5.10?) in the upstram do not support
> PostgreSQL 10.

Thanks for this patch! 
I ran into this problem with https://bugs.debian.org/cgi-bin/bugreport.cgi?
bug=876421 and thus far hadn't received a reply to it.
As PostgreSQL 10 is now the version in both Sid and Testing/Buster, this means 
PostgreSQL can't be used with qt, which is a shame.

Bug#879960: libqt5sql5-psql: [libqt5sql5-psql] basic support postgresql-10

2017-10-27 Thread Damir R. Islamov 
Package: libqt5sql5-psql
Version: 5.9.1+dfsg-12
Severity: important
Tags: patch

Dear Maintainer,

   * QT-5.9.[1,2] (and future QT-5.10?) in the upstram do not support 
PostgreSQL 10.
   * Futire Debian release (at least the current SID) includes PostgreSQL 10.
   * Users who use QPSQLDriver in there applications (e.g. who use 
akonadi-backend-postgresql) are not able to work completely.
   * I suppose that a basic support of PostgreSQL 10 in QPSQLDriver will 
provide (at least temporal) solution until QT team support in the upstream.

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.13.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8), 
LANGUAGE=ru_RU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libqt5sql5-psql depends on:
ii  libc62.24-17
ii  libpq5   10.0-1+b1
ii  libqt5core5a [qtbase-abi-5-9-0]  5.9.1+dfsg-12.1
ii  libqt5sql5   5.9.1+dfsg-12.1
ii  libstdc++6   7.2.0-12

libqt5sql5-psql recommends no packages.

libqt5sql5-psql suggests no packages.

-- no debconf information
Description: support postgresql 10
 .
 qtbase-opensource-src (5.9.1+dfsg-12.1) UNRELEASED; urgency=medium
 .
   * Non-maintainer upload.
   * Add postgresql-10 support.
Author: Damir R. Islamov 
Last-Update: 2017-10-17

--- 
qtbase-opensource-src-5.9.1+dfsg.orig/src/plugins/sqldrivers/psql/qsql_psql.cpp
+++ qtbase-opensource-src-5.9.1+dfsg/src/plugins/sqldrivers/psql/qsql_psql.cpp
@@ -748,6 +748,9 @@ static QPSQLDriver::Protocol qMakePSQLVe
 case 9:
 return QPSQLDriver::Version9;
 break;
+case 10:
+return QPSQLDriver::Version10;
+break;
 default:
 break;
 }
@@ -993,7 +996,8 @@ bool QPSQLDriver::commitTransaction()
 d->pro == QPSQLDriver::Version82 ||
 d->pro == QPSQLDriver::Version83 ||
 d->pro == QPSQLDriver::Version84 ||
-d->pro == QPSQLDriver::Version9) {
+d->pro == QPSQLDriver::Version9 ||
+d->pro == QPSQLDriver::Version10) {
 transaction_failed = qstrcmp(PQcmdStatus(res), "ROLLBACK") == 0;
 }
 
@@ -1110,6 +1114,7 @@ QSqlIndex QPSQLDriver::primaryIndex(cons
 case QPSQLDriver::Version83:
 case QPSQLDriver::Version84:
 case QPSQLDriver::Version9:
+case QPSQLDriver::Version10:
 stmt = QLatin1String("SELECT pg_attribute.attname, 
pg_attribute.atttypid::int, "
 "pg_class.relname "
 "FROM pg_attribute, pg_class "
@@ -1200,6 +1205,7 @@ QSqlRecord QPSQLDriver::record(const QSt
 case QPSQLDriver::Version83:
 case QPSQLDriver::Version84:
 case QPSQLDriver::Version9:
+case QPSQLDriver::Version10:
 stmt = QLatin1String("select pg_attribute.attname, 
pg_attribute.atttypid::int, "
 "pg_attribute.attnotnull, pg_attribute.attlen, 
pg_attribute.atttypmod, "
 "pg_attrdef.adsrc "
--- 
qtbase-opensource-src-5.9.1+dfsg.orig/src/plugins/sqldrivers/psql/qsql_psql_p.h
+++ qtbase-opensource-src-5.9.1+dfsg/src/plugins/sqldrivers/psql/qsql_psql_p.h
@@ -84,7 +84,8 @@ public:
 Version82 = 13,
 Version83 = 14,
 Version84 = 15,
-Version9 = 16
+Version9 = 16,
+Version10 = 17
 };
 
 explicit QPSQLDriver(QObject *parent=0);