Bug#880037: stretch-pu: package dput-ng/1.13

2018-07-03 Thread Mattia Rizzolo
On Tue, Jul 03, 2018 at 08:46:30PM +0100, Adam D. Barratt wrote:
> +  * Add "olstable" to the "protected distributions".  Closes: #742136
> 
> s/olstable/oldstable/

Oops, thank you!

> Please go ahead.

Uploaded!

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature


Bug#880037: stretch-pu: package dput-ng/1.13

2018-07-03 Thread Adam D. Barratt
Control: tags -1 + confirmed

On Thu, 2018-05-24 at 11:09 +0200, Mattia Rizzolo wrote:
> Control: tag -1 - moreinfo
> 
> Hi!
> 
> On Sat, Nov 18, 2017 at 06:20:57PM +, Adam D. Barratt wrote:
> > Thanks for looking at fixing these bugs in stable. Unfortunately,
> > I'm
> > not happy to approve the diff as-is; specific comments below.
> 
> Please let me kindly hijack this pu request and propose a new
> debdiff, here attached.
> I included new commits, and stashed out stuff that was nack'ed in the
> first iteration.

+  * Add "olstable" to the "protected distributions".  Closes: #742136

s/olstable/oldstable/

Please go ahead.

Regards,

Adam



Bug#880037: stretch-pu: package dput-ng/1.13

2018-05-24 Thread Mattia Rizzolo
Control: tag -1 - moreinfo

Hi!

On Sat, Nov 18, 2017 at 06:20:57PM +, Adam D. Barratt wrote:
> Thanks for looking at fixing these bugs in stable. Unfortunately, I'm
> not happy to approve the diff as-is; specific comments below.

Please let me kindly hijack this pu request and propose a new debdiff,
here attached.
I included new commits, and stashed out stuff that was nack'ed in the
first iteration.

> What's this change about, which doesn't appear to be mentioned in the
> changelog?
> 
> --- dput-ng-1.13/tests/fake_package/fnord_1.0.dsc   2017-05-30 
> 17:41:14.0 +0100
> +++ dput-ng-1.15+deb9u1/tests/fake_package/fnord_1.0.dsc1970-01-01 
> 01:00:00.0 +0100
> ...
> --- dput-ng-1.13/tests/fake_package/fnord_1.0_source.changes2017-05-30 
> 17:41:14.0 +0100
> +++ dput-ng-1.15+deb9u1/tests/fake_package/fnord_1.0_source.changes 
> 1970-01-01 01:00:00.0 +0100
> ...
> --- dput-ng-1.13/tests/fake_package/fnord_1.0_source.test.upload
> 2017-05-30 17:41:14.0 +0100
> +++ dput-ng-1.15+deb9u1/tests/fake_package/fnord_1.0_source.test.upload 
> 1970-01-01 01:00:00.0 +0100
> 

FTR, these are temporary tests file that somehow got into 1.12 and I was
forced to retain for 1.13 (that was uploaded while in deep freeze) to
easy the review.  I forcefully retained them for 1.13+deb9u1 as well.


Please, check out the new attached debdiff.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
diffstat for dput-ng-1.13 dput-ng-1.13+deb9u1

 debian/changelog   |   21 +
 debian/control |6 +++---
 debian/gbp.conf|1 +
 docs/man/dcut.1.man|4 ++--
 docs/man/dput.5.man|2 +-
 dput/hooks/distribution.py |2 +-
 dput/uploaders/ftp.py  |   10 --
 skel/codenames/debian.json |6 ++
 skel/profiles/mentors.json |2 +-
 skel/profiles/ports-master.json|   12 
 tests/dputng/codenames/debian.json |6 ++
 11 files changed, 58 insertions(+), 14 deletions(-)

diff -Nru dput-ng-1.13/debian/changelog dput-ng-1.13+deb9u1/debian/changelog
--- dput-ng-1.13/debian/changelog   2017-05-30 18:41:14.0 +0200
+++ dput-ng-1.13+deb9u1/debian/changelog2018-05-24 10:55:38.0 
+0200
@@ -1,3 +1,24 @@
+dput-ng (1.13+deb9u1) stretch; urgency=medium
+
+  [ Mattia Rizzolo ]
+  * Add jessie-backports-sloppy and stretch-backports targets.  Closes: #878665
+  * Include 'testing' in the rm-managed suites.
+  * Fix some spelling errors in the manpages.
+  * Change the mentors.debian.net upload queue to the new recommended one.
+  * Move the git repository to salsa.debian.org.
+  * Add "olstable" to the "protected distributions".  Closes: #742136
+  * Change Maintainer email address to dput...@packages.debian.org.
+Closes: #899487
+
+  [ James Clarke ]
+  * Add ports-master profile.  Closes: #855154
+
+  [ Stephan Sürken ]
+  * dput/uploaders/ftp.py: Parse and use optional [:port] part for fqdn.
+Closes: #814440
+
+ -- Mattia Rizzolo   Thu, 24 May 2018 10:55:38 +0200
+
 dput-ng (1.13) unstable; urgency=medium
 
   * Team upload.
diff -Nru dput-ng-1.13/debian/control dput-ng-1.13+deb9u1/debian/control
--- dput-ng-1.13/debian/control 2017-05-30 18:39:07.0 +0200
+++ dput-ng-1.13+deb9u1/debian/control  2018-05-24 10:55:38.0 +0200
@@ -1,7 +1,7 @@
 Source: dput-ng
 Section: devel
 Priority: extra
-Maintainer: dput-ng Maintainers 
+Maintainer: dput-ng Maintainers 
 Uploaders: Arno Töll ,
  Paul Tagliamonte 
 Build-Depends: debhelper (>= 10),
@@ -23,8 +23,8 @@
  docbook-xsl-ns,
  xsltproc
 Standards-Version: 3.9.8
-Vcs-Browser: https://anonscm.debian.org/cgit/collab-maint/dputng.git
-Vcs-Git: https://anonscm.debian.org/git/collab-maint/dputng.git
+Vcs-Browser: https://salsa.debian.org/debian/dput-ng
+Vcs-Git: https://salsa.debian.org/debian/dput-ng.git -b stretch
 Homepage: http://dput-ng.debian.net/
 X-Python-Version: >= 2.7
 
diff -Nru dput-ng-1.13/debian/gbp.conf dput-ng-1.13+deb9u1/debian/gbp.conf
--- dput-ng-1.13/debian/gbp.conf2017-05-30 18:39:07.0 +0200
+++ dput-ng-1.13+deb9u1/debian/gbp.conf 2018-05-24 10:55:38.0 +0200
@@ -1,3 +1,4 @@
 [DEFAULT]
 pristine-tar = True
 debian-tag = %(version)s
+debian-branch = stretch
diff -Nru dput-ng-1.13/docs/man/dcut.1.man 
dput-ng-1.13+deb9u1/docs/man/dcut.1.man
--- dput-ng-1.13/docs/man/dcut.1.man2017-05-30 18:39:07.0 +0200
+++ dput-ng-1.13+deb9u1/docs/man/dcut.1.man 2018-05-24 10:46:04.0 
+0200
@@ -59,8 +59,8 @@
 *-O, --output*=FILENAME::
Write the resulting commands file to 'FILE

Bug#880037: stretch-pu: package dput-ng/1.13

2017-11-18 Thread Adam D. Barratt
Control: tags -1 + moreinfo

Thanks for looking at fixing these bugs in stable. Unfortunately, I'm
not happy to approve the diff as-is; specific comments below.

On Sat, 2017-10-28 at 19:36 +0100, Miguel Landaeta wrote:
> +dput-ng (1.15+deb9u1) stretch; urgency=medium

That would make the package version in stretch higher than the version
in unstable.

> +  [ Miguel Landaeta ]
> +  * Team upload.
> +  * New upstream stable release.
> +
> +  [ Mattia Rizzolo ]
> +  * Fix typo on the jessie-backports-sloppy target.  (Closes:
> #867245)

I'm not convinced that's actually relevant for the changelog of this
package, given that the typo was never included in a package in stable.

> +  * Include 'testing' in the rm-managed suites.
> +  * Add jessie-backports-sloppy and stretch-backports. (Closes:
> #878665)

These sound fine.

> +  * Mark dput-ng-doc as Multi-Arch:foreign.
> +  * wrap-and-sort.
> +  * Bump Standards-Version to 4.0.0, no changes needed.

These, however, do not. The first and last are not appropriate for a
stable update, and the wrap-and-sort produces more noise in the diff
than the actual changes.

> +  * doc/man: fix some spelling errors.
> +
> +  [ James Clarke ]
> +  * Add ports-master profile. (Closes: #855154)
> +
> +  [ Stephan Sürken ]
> +  * dput/uploaders/ftp.py: Parse and use optional [:port] part for
> fqdn.
> +(Closes: #814440)

Those look OK.

What's this change about, which doesn't appear to be mentioned in the
changelog?

--- dput-ng-1.13/tests/fake_package/fnord_1.0.dsc   2017-05-30 
17:41:14.0 +0100
+++ dput-ng-1.15+deb9u1/tests/fake_package/fnord_1.0.dsc1970-01-01 
01:00:00.0 +0100
...
--- dput-ng-1.13/tests/fake_package/fnord_1.0_source.changes2017-05-30 
17:41:14.0 +0100
+++ dput-ng-1.15+deb9u1/tests/fake_package/fnord_1.0_source.changes 
1970-01-01 01:00:00.0 +0100
...
--- dput-ng-1.13/tests/fake_package/fnord_1.0_source.test.upload
2017-05-30 17:41:14.0 +0100
+++ dput-ng-1.15+deb9u1/tests/fake_package/fnord_1.0_source.test.upload 
1970-01-01 01:00:00.0 +0100

Regards,

Adam