Bug#880584: [PATCH] auto_add_modules: add mfd in MODULES==most

[Ben Hutchings]

On Tue, 2017-12-12 at 09:09 +, Riku Voipio wrote:
> Hi Ben,
> 
> On Thu, Nov 02, 2017 at 02:46:47PM +, Riku Voipio wrote:
> > Package: initramfs-tools
> > Version: 0.130
> > Severity: normal
> > Tags: patch
> > 
> > Multi Function Devices may carry essential functions on arm/arm64
> > platforms. For example in 96boards HiKey mfd/hi655x-pmic has regulators,
> > causing MMC driver init fail.  when generating generic initrd on offline
> > with MODULES=most, update-initramfs doesn't pick mfd modules.
> > 
> > Since mfd is quite small (284K on arm64), just add them all to most. This
> > may also open the road to make some currently built-in CONFIG_MFD
> > drivers modules.
> 
> 
> Is this patch ok to commit?

I suppose so.

Please add a 'Closes:' tag to the commit message.

Ben.

> > Signed-off-by: Riku Voipio 
> > ---
> >  hook-functions | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/hook-functions b/hook-functions
> > index 679e11d..4b49391 100644
> > --- a/hook-functions
> > +++ b/hook-functions
> > @@ -537,6 +537,7 @@ auto_add_modules()
> > copy_modules_dir kernel/drivers/gpio
> > copy_modules_dir kernel/drivers/i2c/busses
> > copy_modules_dir kernel/drivers/i2c/muxes
> > +   copy_modules_dir kernel/drivers/mfd
> > copy_modules_dir kernel/drivers/phy
> > copy_modules_dir kernel/drivers/pinctrl
> > copy_modules_dir kernel/drivers/regulator
> > -- 
> > 2.14.2
> > 
> 
> 
-- 
Ben Hutchings
Unix is many things to many people,
but it's never been everything to anybody.



signature.asc
Description: This is a digitally signed message part

Bug#880584: [PATCH] auto_add_modules: add mfd in MODULES==most

[Riku Voipio]

Hi Ben,

On Thu, Nov 02, 2017 at 02:46:47PM +, Riku Voipio wrote:
> Package: initramfs-tools
> Version: 0.130
> Severity: normal
> Tags: patch
> 
> Multi Function Devices may carry essential functions on arm/arm64
> platforms. For example in 96boards HiKey mfd/hi655x-pmic has regulators,
> causing MMC driver init fail.  when generating generic initrd on offline
> with MODULES=most, update-initramfs doesn't pick mfd modules.
> 
> Since mfd is quite small (284K on arm64), just add them all to most. This
> may also open the road to make some currently built-in CONFIG_MFD
> drivers modules.


Is this patch ok to commit?
 
> Signed-off-by: Riku Voipio 
> ---
>  hook-functions | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hook-functions b/hook-functions
> index 679e11d..4b49391 100644
> --- a/hook-functions
> +++ b/hook-functions
> @@ -537,6 +537,7 @@ auto_add_modules()
>   copy_modules_dir kernel/drivers/gpio
>   copy_modules_dir kernel/drivers/i2c/busses
>   copy_modules_dir kernel/drivers/i2c/muxes
> + copy_modules_dir kernel/drivers/mfd
>   copy_modules_dir kernel/drivers/phy
>   copy_modules_dir kernel/drivers/pinctrl
>   copy_modules_dir kernel/drivers/regulator
> -- 
> 2.14.2
> 

Bug#880584: [PATCH] auto_add_modules: add mfd in MODULES==most

[Riku Voipio]

Package: initramfs-tools
Version: 0.130
Severity: normal
Tags: patch

Multi Function Devices may carry essential functions on arm/arm64
platforms. For example in 96boards HiKey mfd/hi655x-pmic has regulators,
causing MMC driver init fail.  when generating generic initrd on offline
with MODULES=most, update-initramfs doesn't pick mfd modules.

Since mfd is quite small (284K on arm64), just add them all to most. This
may also open the road to make some currently built-in CONFIG_MFD
drivers modules.

Signed-off-by: Riku Voipio 
---
 hook-functions | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hook-functions b/hook-functions
index 679e11d..4b49391 100644
--- a/hook-functions
+++ b/hook-functions
@@ -537,6 +537,7 @@ auto_add_modules()
copy_modules_dir kernel/drivers/gpio
copy_modules_dir kernel/drivers/i2c/busses
copy_modules_dir kernel/drivers/i2c/muxes
+   copy_modules_dir kernel/drivers/mfd
copy_modules_dir kernel/drivers/phy
copy_modules_dir kernel/drivers/pinctrl
copy_modules_dir kernel/drivers/regulator
-- 
2.14.2