Bug#880837: dh-dist-zilla no longer works with nonexisting $HOME

[Axel Beckert]

Control: tag -1 + pending

Hi Adrian,

Adrian Bunk wrote:
> Reverting the following change fixes it:

Yes, found it, too. Fixed in my local git repository. Will push and
upload a new, fixed release soon.

Thanks again for the bug report.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Bug#880837: dh-dist-zilla no longer works with nonexisting $HOME

[Adrian Bunk]

On Sun, Nov 05, 2017 at 04:34:18PM +0100, Axel Beckert wrote:
>...
> > dh clean --with dist_zilla
> >dh_dzil_clean
> > couldn't determine home directory at /usr/share/perl5/Dist/Zilla/App.pm 
> > line 37.
> > dh_dzil_clean: dzil clean returned exit code 2
> > debian/rules:5: recipe for target 'clean' failed
> > make: *** [clean] Error 25
> 
> Interesting. The 1.3.5 upload didn't change anything in dh_dzil_clean.
> Neither was there a libdist-zilla-perl upload in the past few months.
> (Last one was in July.)
> 
> Nevertheless downgrading to 1.3.4 fixes the issue.
> 
> So it's definitely a regression in 1.3.5.
>...

Reverting the following change fixes it:

--- dh-dist-zilla-1.3.4/dist_zilla.pm   2015-12-21 11:41:06.0 +0200
+++ dh-dist-zilla-1.3.5/dist_zilla.pm   2017-10-30 05:15:00.0 +0200
@@ -6,7 +6,7 @@
 my $build_root = ".build";
 my $build_dir = "$build_root/debian-build";
 # Override dzil's looking for $HOME
-$ENV{DZIL_GLOBAL_CONFIG_ROOT} = $build_root;
+local $ENV{DZIL_GLOBAL_CONFIG_ROOT} = $build_root;


cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

Bug#880837: dh-dist-zilla no longer works with nonexisting $HOME

[Axel Beckert]

Control: affects -1 + src:roary
Control: tag -1 + confirmed

Hi Adrian,

thanks for the bug report.

Adrian Bunk wrote:
> Control: affects -1 src:systray-mdstat src:librun-parts-perl 
> src:libcgi-github-webhook-perl
> 
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/systray-mdstat.html
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/librun-parts-perl.html
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libcgi-github-webhook-perl.html

it should also affect src:roary — added.

> ...
>  fakeroot debian/rules clean
> dh clean --with dist_zilla
>dh_dzil_clean
> couldn't determine home directory at /usr/share/perl5/Dist/Zilla/App.pm line 
> 37.
> dh_dzil_clean: dzil clean returned exit code 2
> debian/rules:5: recipe for target 'clean' failed
> make: *** [clean] Error 25

Interesting. The 1.3.5 upload didn't change anything in dh_dzil_clean.
Neither was there a libdist-zilla-perl upload in the past few months.
(Last one was in July.)

Nevertheless downgrading to 1.3.4 fixes the issue.

So it's definitely a regression in 1.3.5.

> I can reproduce this with
>   HOME=/does/not/exist dpkg-buildpackage -b

Thanks for that hint. I can reproduce it that way. An even more direct
way to show the issue is to call "HOME=/does/not/exist
dpkg-buildpackage -T clean".

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Bug#880837: dh-dist-zilla no longer works with nonexisting $HOME

[Adrian Bunk]

Package: dh-dist-zilla
Version: 1.3.5
Severity: serious
Control: affects -1 src:systray-mdstat src:librun-parts-perl 
src:libcgi-github-webhook-perl

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/systray-mdstat.html
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/librun-parts-perl.html
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libcgi-github-webhook-perl.html

...
 fakeroot debian/rules clean
dh clean --with dist_zilla
   dh_dzil_clean
couldn't determine home directory at /usr/share/perl5/Dist/Zilla/App.pm line 37.
dh_dzil_clean: dzil clean returned exit code 2
debian/rules:5: recipe for target 'clean' failed
make: *** [clean] Error 25


I can reproduce this with
  HOME=/does/not/exist dpkg-buildpackage -b