Bug#882104: debian-goodies: "checkrestart -n" throws TypeError: a bytes-like object is required, not 'str'

[RjY]

Great, thanks for the bug cloning magic + swift fixes :)

Bug#882104: debian-goodies: "checkrestart -n" throws TypeError: a bytes-like object is required, not 'str'

[Axel Beckert]

Control: tag -1 + pending

Hi,

Axel Beckert wrote:
> RjY wrote:
> > Just wanted to add I am also seeing this. Also wanted to note using
> > checkrestart with -n (I wondered if not using lsof might produce
> > different results) instead gave a python exception/backtrace.
> 
> Indeed, thanks for reporting it. But it's (very likely) a separate
> issue, hence I'm cloning this bug report into a second one with
> appropriate title, severity and submitter.

I've just pushed a fix for this issue.

It was a regression introduced in commit fa9a1e59 (debian-goodies
0.77). I've assumed that the submitter tested his patch and didn't
test the explicit code path the change was in. Sorry for that.

Interestingly, with regards to #882080, checkrestart properly reports
stuff with -n now. And there's a similar patch against the call of
lsof in 0.77, too. So maybe "git bisect" found another issue, but not
the real issue. At least so far I couldn't find any bad logic inside
the commit accused by "git bisect".

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE