Bug#882159: Fw: Bug #882159: duply: occasionally shows negative runtimes

2017-11-27 Thread edso
hey Jan,

On 11/27/2017 21:06, Jan Braun wrote:
> Hello,
> Joachim Wiedorn schrob:

i like your past tense of "schreiben"

>> Hello Jan, FYI:
>>  original message 
>> From: e...@users.sourceforge.net
>> Date: Sun, 26 Nov 2017 21:55:28 +0100
>> To: Joachim Wiedorn , cont...@bugs.debian.org,
>> 882...@bugs.debian.org
>>
>> can the reporter maybe test the current snapshot? it should fix the issue.
>>   http://duply.net/wiki/index.php/Duply-code#Latest_Development_Snapshot
> 
> The "2.0.4dev" version I downloaded just now from
> http://duply.net/tmp/duply.sh works for me, outputs times like
> | --- Finished state OK at 19:34:48.724 - Runtime 00:00:00.075 ---
> and takes the "date_fix %s%N" branch (verified via debug printf).
> The diff looks good to me as well.
> Thanks a lot for the quick fix!

you're welcome!
 
> I noticed two unrelated minor oddities:
> 1) On the first run (per profile) with the new version, duply would re-sync
>all the metadata. That's because of the bugfix for #117, which moved
>the metadata location from "$ARCH_DIR/duply_$profile" to
>"$ARCH_DIR/$profile". That leaves around the old, now-useless
>metadata folder. Not a big deal, but maybe it would have been better
>to adjust the comment to match the code instead of the other way
>around?

good argument, let confer w/ the bug reporter on this. on the other hand it is 
just resynching the archive dir not the volumes, so the traffic overhead should 
be manageable. the stale folder is unfortunate.

how about a backward compatibility hack, that uses it as long as it exists, but 
new backups will create it as it was documented all the time?
 
> 2) In line 2172,
> | # for sec�rity reasons, we url_encode username to protect special chars
>there's some (for me undisplayable) unicode (%EF%BF%BD) instead of
>the 'u' in "security". Funny, given the context. :D

finally somebody who get's it, see
  https://sourceforge.net/p/ftplicity/bugs/75/

have fun.. ede/duply.net



Bug#882159: Fw: Bug #882159: duply: occasionally shows negative runtimes

2017-11-27 Thread Jan Braun
Hello,
Joachim Wiedorn schrob:
> Hello Jan, FYI:
>  original message 
> From: e...@users.sourceforge.net
> Date: Sun, 26 Nov 2017 21:55:28 +0100
> To: Joachim Wiedorn , cont...@bugs.debian.org,
> 882...@bugs.debian.org
> 
> can the reporter maybe test the current snapshot? it should fix the issue.
>   http://duply.net/wiki/index.php/Duply-code#Latest_Development_Snapshot

The "2.0.4dev" version I downloaded just now from
http://duply.net/tmp/duply.sh works for me, outputs times like
| --- Finished state OK at 19:34:48.724 - Runtime 00:00:00.075 ---
and takes the "date_fix %s%N" branch (verified via debug printf).
The diff looks good to me as well.
Thanks a lot for the quick fix!

I noticed two unrelated minor oddities:
1) On the first run (per profile) with the new version, duply would re-sync
   all the metadata. That's because of the bugfix for #117, which moved
   the metadata location from "$ARCH_DIR/duply_$profile" to
   "$ARCH_DIR/$profile". That leaves around the old, now-useless
   metadata folder. Not a big deal, but maybe it would have been better
   to adjust the comment to match the code instead of the other way
   around?

2) In line 2172,
| # for sec�rity reasons, we url_encode username to protect special chars
   there's some (for me undisplayable) unicode (%EF%BF%BD) instead of
   the 'u' in "security". Funny, given the context. :D

HTH and thanks again,
Jan


signature.asc
Description: PGP signature