Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h
Hello, On Mon, Nov 27 2017, Joerg Jaspert wrote: > And what guarantees that they will always be together? On CDs, partial > mirrors (ok, not so important), when something gets removed? And our > download links (say, packages.d.o) dont tell you to also download file > X, y and z for getting all of the source you need. What I was thinking was that README.source would point to src:zxcvbn-c. But I see what you mean about CDs. -- Sean Whitton signature.asc Description: PGP signature
Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h
On 14868 March 1977, Sean Whitton wrote: > However, the preferred format of modification is in fact present in the > zxcvbn-c source package, which builds dict-src.h as part of its package > build. So I wonder if you could refer to that package in README.source > and it would be enough for the ftp-masters? And what guarantees that they will always be together? On CDs, partial mirrors (ok, not so important), when something gets removed? And our download links (say, packages.d.o) dont tell you to also download file X, y and z for getting all of the source you need. -- bye, Joerg
Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h
Hi Sean, [No need to CC me, I am subscribed to d-devel]. I didn't check the source of keepassxc, so my earlier remark was based on assumptions. On 26-11-17 20:39, Sean Whitton wrote: > On Sun, Nov 26 2017, Paul Gevers wrote: > >> I would copy the directory to some tmp folder in debian/ during the >> configure step (if not done before) and move it back during the clean >> step (and copy it from debian/ in the step where you are building >> src/zxcvbn/dict-src.h). >> >> I don't see any issue, except you should ask upstream to fix the >> situation. Repacking the source tarball for this feels wrong, except >> if you need to do that for other reasons as well. > > This doesn't satisfy the DFSG issue. dict-src.h is not in its preferred > form of modification. If this dict-src.h is (re)build during the building of the package, there isn't an issue right? That is what I understood was happening. I may have understood wrong, hence the request for clarification to Julian. Paul signature.asc Description: OpenPGP digital signature
Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h
Hello Paul, On Sun, Nov 26 2017, Paul Gevers wrote: > I would copy the directory to some tmp folder in debian/ during the > configure step (if not done before) and move it back during the clean > step (and copy it from debian/ in the step where you are building > src/zxcvbn/dict-src.h). > > I don't see any issue, except you should ask upstream to fix the > situation. Repacking the source tarball for this feels wrong, except > if you need to do that for other reasons as well. This doesn't satisfy the DFSG issue. dict-src.h is not in its preferred form of modification. -- Sean Whitton signature.asc Description: PGP signature
Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h
Hello Julian, On Sun, Nov 26 2017, Julian Andres Klode wrote: > The file src/zxcvbn/dict-src.h is an autogenerated dictionary file, > generated from smaller files. The directory is removed during build. I see that you are linking against libzxcvbn0. So, just to confirm, the whole src/zxcvbn/ directory is not actually used by your package build, right? It's just something upstream has in their tarballs. > I'm not entirely sure if I need to repackage the source tarball or > not, given that the file is removed during clean, hence the bug report > and CCing debian-devel. It's a file without its preferred format for modification. So, yes, you need to repack the tarball. I don't understand how "the file is removed during clean" would counteract that. The tarball would still be in our archive. Source packages must satisfy the DFSG just as much as binary packages. However, the preferred format of modification is in fact present in the zxcvbn-c source package, which builds dict-src.h as part of its package build. So I wonder if you could refer to that package in README.source and it would be enough for the ftp-masters? -- Sean Whitton signature.asc Description: PGP signature
Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h
On Sun, Nov 26, 2017 at 07:45:13AM +0100, Paul Gevers wrote: > Hi Julian, > > On 26-11-17 01:29, Julian Andres Klode wrote: > > The file src/zxcvbn/dict-src.h is an autogenerated dictionary file, > > generated from smaller files. The directory is removed during build. > > Are you saying that these smaller files are in the tar ball, but after > one build the files are gone? That would mean you have a problem to > build twice in a row. That's wrong. You can always remove files, removals are ignored when building the tarball. That's how dh-autoreconf works. > > I'm not entirely sure if I need to repackage the source tarball or > > not, given that the file is removed during clean, hence the bug > > report and CCing debian-devel. > > I would copy the directory to some tmp folder in debian/ during the > configure step (if not done before) and move it back during the clean > step (and copy it from debian/ in the step where you are building > src/zxcvbn/dict-src.h). > > I don't see any issue, except you should ask upstream to fix the > situation. Repacking the source tarball for this feels wrong, except if > you need to do that for other reasons as well. I'd say that's reasonable, yes. -- debian developer - deb.li/jak | jak-linux.org - free software dev ubuntu core developer i speak de, en
Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h
Hi Julian, On 26-11-17 01:29, Julian Andres Klode wrote: > The file src/zxcvbn/dict-src.h is an autogenerated dictionary file, > generated from smaller files. The directory is removed during build. Are you saying that these smaller files are in the tar ball, but after one build the files are gone? That would mean you have a problem to build twice in a row. > I'm not entirely sure if I need to repackage the source tarball or > not, given that the file is removed during clean, hence the bug > report and CCing debian-devel. I would copy the directory to some tmp folder in debian/ during the configure step (if not done before) and move it back during the clean step (and copy it from debian/ in the step where you are building src/zxcvbn/dict-src.h). I don't see any issue, except you should ask upstream to fix the situation. Repacking the source tarball for this feels wrong, except if you need to do that for other reasons as well. Paul signature.asc Description: OpenPGP digital signature
Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h
Package: src:keepassxc Severity: serious The file src/zxcvbn/dict-src.h is an autogenerated dictionary file, generated from smaller files. The directory is removed during build. I'm not entirely sure if I need to repackage the source tarball or not, given that the file is removed during clean, hence the bug report and CCing debian-devel. -- System Information: Debian Release: buster/sid APT prefers testing APT policy: (900, 'testing'), (800, 'unstable'), (500, 'unstable-debug'), (500, 'testing-debug'), (100, 'experimental'), (1, 'experimental-debug') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.13.0-1-amd64 (SMP w/4 CPU cores) Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8), LANGUAGE=en_IE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) -- debian developer - deb.li/jak | jak-linux.org - free software dev ubuntu core developer i speak de, en
