Bug#883375: qtbase-opensource-src: Please add private headers in /src/plugins/platforms/xcb/

[张继德]

qt5dxcb-plugin is a functionality extension based of qt xcb plugin, and is not 
a complete independent plugin, which depends on libqt5xcbqpa5 to work.





--


武汉深之度科技有限公司
Wuhan Deepin Technology Co., Ltd.

　　张继德　　

手机：+8613014623572

武汉：武汉市光谷大道77号光谷金融港B18栋6楼 
北京：北京西城区新街口外大街28号院普天德胜B座603室
上海：上海市长宁区愚园路1258号15A01室

Bug#883375: qtbase-opensource-src: Please add private headers in /src/plugins/platforms/xcb/

[Lisandro Damián Nicanor Pérez Meyer]

Control: tag -1 wontfix

El 3 dic. 2017 6:21 a.m., "Pino Toscano"  escribió:

> My question is, is it possible for us to include (copy) those header
files and
> distribute them inside package "qtbase5-private-dev" so that package
> "qt5dxcb-plugin" could build-dep on qtbase5-private-dev instead of
bundling
> them inside repository (like what Fedora did)?

[Snip Pino's reply]


No, it's not possible. As Pino said it's already a big headache to have to
ship official private headers. Adding even more would require us even more
work to properly track them. So the answer is no.


It ought to really work with what Qt ships, not trying to outsmart Qt
this way.  Why does qt5dxcb-plugin need these headers?  If it really
needs them (IMHO it should just use what Qt provides, even as private
headers), did you ask upstream Qt to provide them or the equivalent API
for what qt5dxcb-plugin wants to do?


Right, if you really need then then work with upstream to make it public
API, or at least official private one.

Please note that we will not add private headers to other qt submodules
except we the Debian Qt/KDE team really need them.

Bug#883375: qtbase-opensource-src: Please add private headers in /src/plugins/platforms/xcb/

[Pino Toscano]

In data domenica 3 dicembre 2017 15:58:28 CET, Boyuan Yang ha scritto:
> I'm working inside pkg-deepin team [1] to push Deepin applications into
> Debian. Deepin use Qt and Golang heavily in their applications.
> 
> There's a special dependency for Deepin applications: package "qt5dxcb-plugin"
> uses some really private Qt headers. Currently they bundle the header files
> inside src repository [2] but that is apparently not optimal approach for 
> Debian
> packaging. Those header files come from /src/plugins/platforms/xcb/
> directory in qtbase-opensource-src source tree.
> 
> Deepin applications (alongside Deepin Desktop Environment, DDE) need it to 
> work
> properly. In other distributions like Arch Linux and Fedora, package 
> maintainers
> already included them, either in a separate package ([4], in package
> qt5-xcb-private-headers) or together in the qt5 private devel package ([5], in
> package qt5-qtbase-private-devel).
> 
> My question is, is it possible for us to include (copy) those header files and
> distribute them inside package "qtbase5-private-dev" so that package
> "qt5dxcb-plugin" could build-dep on qtbase5-private-dev instead of bundling
> them inside repository (like what Fedora did)?

To be honest, this makes no sense.  Qt5 already ships two sets of
headers:
- public headers, available in qtbase5-dev
- private headers, available in qtbase5-private-dev
Tracking the private headers is already a non-trivial workload on the
team workflow (for example, it requires extra transitions).

Yet, qt5dxcb-plugin needs more private headers than the private headers?
It ought to really work with what Qt ships, not trying to outsmart Qt
this way.  Why does qt5dxcb-plugin need these headers?  If it really
needs them (IMHO it should just use what Qt provides, even as private
headers), did you ask upstream Qt to provide them or the equivalent API
for what qt5dxcb-plugin wants to do?

FWIW, there are already platform plugins in Debian (plasma-integration
and lxqt-qtplugin), so indeed a DDE one could just use the provided
API too, public or private.

-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.

Bug#883375: qtbase-opensource-src: Please add private headers in /src/plugins/platforms/xcb/

[Boyuan Yang]

Source: qtbase-opensource-src
Version: 5.9.2+dfsg-4
Severity: wishlist
X-Debbugs-CC: pkg-deepin-de...@lists.alioth.debian.org

Dear Qt maintainers,

I'm working inside pkg-deepin team [1] to push Deepin applications into
Debian. Deepin use Qt and Golang heavily in their applications.

There's a special dependency for Deepin applications: package "qt5dxcb-plugin"
uses some really private Qt headers. Currently they bundle the header files
inside src repository [2] but that is apparently not optimal approach for Debian
packaging. Those header files come from /src/plugins/platforms/xcb/
directory in qtbase-opensource-src source tree.

Deepin applications (alongside Deepin Desktop Environment, DDE) need it to work
properly. In other distributions like Arch Linux and Fedora, package maintainers
already included them, either in a separate package ([4], in package
qt5-xcb-private-headers) or together in the qt5 private devel package ([5], in
package qt5-qtbase-private-devel).

My question is, is it possible for us to include (copy) those header files and
distribute them inside package "qtbase5-private-dev" so that package
"qt5dxcb-plugin" could build-dep on qtbase5-private-dev instead of bundling
them inside repository (like what Fedora did)?

Thanks,
Boyuan Yang

[1] https://alioth.debian.org/projects/pkg-deepin/
[2] 
https://github.com/linuxdeepin/qt5dxcb-plugin/tree/master/platformplugin/libqt5xcbqpa-dev/5.9.2/
[3] 
https://sources.debian.org/src/qtbase-opensource-src/5.9.2+dfsg-4/src/plugins/platforms/xcb/
[4] https://www.archlinux.org/packages/extra/x86_64/qt5-xcb-private-headers/
[5] 
https://fedora.pkgs.org/rawhide/fedora-x86_64/qt5-qtbase-devel-5.9.3-3.fc28.x86_64.rpm.html

signature.asc
Description: This is a digitally signed message part.