Bug#884095: revisiting this

2020-03-26 Thread Chris Lamb
Hi Hans,

> I really don't think it will be possible to fix this issue something like
> file magin auto-detection.  An APK can be a working APK, JAR, DEX, and
> ZIP all at the same time.  Using file extensions could work.

I am still not 100% convinced that autodetection is the issue here,
which partly contributed to my retitling, but also because issues
should IMHO describe the goal or problem, not the steps towards that
goal.

To elaborate, the example that you link, ie:

  https://verification.f-droid.org/eu.faircode.email_914.apk.diffoscope.html

… very much appears to have detected this file *correctly* as an apk
file, although that is because it has added the following error:

   Command `apktool d -k -m -o {} {}` exited with 1.
^^^

It would not have run apktool if it thought it was a simple .zip file.
Sure, there should not be an error and the output is useless, but that
is likely to have a different cause.

Regardless of the potential solution, what I would need in any case is
access to the two files that diffoscope is failing to analyse for you.

Please could you provide them so I do not need to guess further at
things? Uploading to salsa would be best, but you could also provide
possibly temporary HTTP links in reply to this bug and I would be
happy to upload them myself.

The other relevant issue is that you appear to be using an old version
of diffoscope, namely version 113, whilst the last release was 137. I
mention this in particular because there have been *lots* of changes
to apk/dex etc. file handling since then. But still, getting the files
from you would be the next step towards solving this for you.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org  chris-lamb.co.uk
   `-



Bug#884095: revisiting this

2020-03-25 Thread Hans-Christoph Steiner
I'm @eighthave on salsa.

We're still stuck on this.  We regularly have to manually do APK
comparisons because we cannot force diffoscope to treat files as APKs,
and it is misdetecting.  I posted on
https://salsa.debian.org/reproducible-builds/diffoscope/issues/28 but
the only response was to retitle the issue to go back to detection.  I
really don't think it will be possible to fix this issue something like
file magin auto-detection.  An APK can be a working APK, JAR, DEX, and
ZIP all at the same time.  Using file extensions could work.

Here's a commonly occuring example:
https://verification.f-droid.org/eu.faircode.email_914.apk.diffoscope.html

Here is a user who was blocked from using diffoscope due to this issue:
https://forum.f-droid.org/t/help-wanted-how-to-create-a-reproducible-build-fairemail/8860/11