Bug#887040: RFS: reptyr/0.6.2-1.1 [RC] [NMU]

[Nicolas Braud-Santoni]

On Sun, Jan 21, 2018 at 08:00:49PM +0100, Nicolas Braud-Santoni wrote:
> The version currently in mentors.d.n looks good to me.

Actually, I missed a minor wart: there is still no DEP3 metadata in the patches.
You can easily add that with `patchedit`.


signature.asc
Description: PGP signature

Bug#887040: RFS: reptyr/0.6.2-1.1 [RC] [NMU]

[Nicolas Braud-Santoni]

Hi Mateusz,

On Fri, Jan 19, 2018 at 10:36:40PM +0100, Mateusz Łukasik wrote:
> 
> Thanks for review. I pushed all suggested changes to mentors.

You are very welcome.

The version currently in mentors.d.n looks good to me.

Now we only need an actual DD to sponsor the upload; Jonathan
(in copy) might do it, but he is not very available since a few days.


Best,

  nicoo


signature.asc
Description: PGP signature

Bug#887040: RFS: reptyr/0.6.2-1.1 [RC] [NMU]

[Mateusz Łukasik]

On 14.01.2018 03:23 +0100, Nicolas Braud-Santoni wrote:

Control: block 853640 by -1
Control: tag 853640 pending

Hi Mateusz,

I just had a look at your NMU, and it seems generally good.
I still have some fairly minor comments, though:

- You can send those changes to the packaging repository, as a pull request.
   This will make life much easier for other people sending changes after you.

- The patch files should have a sensible name, and use DEP3 metadata to indicate
   that they were cherry-picked from upstream.  You might want to have a look at
   http://dep.debian.net/deps/dep3/ and the patchedit utility.

- The changelog doesn't provide any rationale for disabling the Yama check 
except
   under Ubuntu, nor are there obvious reasons to do that (someone can enable 
Yama
   on a Debian system, or on a non-Ubuntu Debian derivative).

- The changelog entry that mentions the FTBFS should close it: just adding
   `(Closes: #853640)` (without backticks) to the line is enough.  Once the
   upload is processed and lands in the archive, the bug is automatically 
closed.

- Some of the items, in the changelog entry, could be improved:
   - Replace “Add hardening” by “Enable build-time hardening”
 (it is clearer that we are talking about hardening DEB_BUILD_MAINT_OPTION)
   - “Fix FTBFS when /dev/tty0 not exists.” ->
   “Fix FTBFS when /dev/tty0 does not exists.”
   - If I'm not mistaken (but I could be wrong), “Drop dpkg-dev” should be part
 of the move to dh 11 (i.e., debhelper versions <= 7 likely needed it)


Thanks a lot, especially, for taking the time to make the package lintian-clean.


Best,

   nicoo



Hi Nicolas,

Thanks for review. I pushed all suggested changes to mentors.


--
 .''`.  Mateusz Łukasik
: :' :  https://l0calh0st.pl
`. `'   Debian Member - mat...@linuxmint.pl
  `-GPG: D93B 0C12 C8D0 4D7A AFBC  FA27 CCD9 1D61 11A0 6851

Bug#887040: RFS: reptyr/0.6.2-1.1 [RC] [NMU]

[Nicolas Braud-Santoni]

Control: block 853640 by -1
Control: tag 853640 pending

Hi Mateusz,

I just had a look at your NMU, and it seems generally good.
I still have some fairly minor comments, though:

- You can send those changes to the packaging repository, as a pull request.
  This will make life much easier for other people sending changes after you.

- The patch files should have a sensible name, and use DEP3 metadata to indicate
  that they were cherry-picked from upstream.  You might want to have a look at
  http://dep.debian.net/deps/dep3/ and the patchedit utility.

- The changelog doesn't provide any rationale for disabling the Yama check 
except
  under Ubuntu, nor are there obvious reasons to do that (someone can enable 
Yama
  on a Debian system, or on a non-Ubuntu Debian derivative).

- The changelog entry that mentions the FTBFS should close it: just adding
  `(Closes: #853640)` (without backticks) to the line is enough.  Once the
  upload is processed and lands in the archive, the bug is automatically closed.

- Some of the items, in the changelog entry, could be improved:
  - Replace “Add hardening” by “Enable build-time hardening”
(it is clearer that we are talking about hardening DEB_BUILD_MAINT_OPTION)
  - “Fix FTBFS when /dev/tty0 not exists.” ->
  “Fix FTBFS when /dev/tty0 does not exists.”
  - If I'm not mistaken (but I could be wrong), “Drop dpkg-dev” should be part
of the move to dh 11 (i.e., debhelper versions <= 7 likely needed it)


Thanks a lot, especially, for taking the time to make the package lintian-clean.


Best,

  nicoo

On Fri, Jan 12, 2018 at 11:02:43PM +0100, Mateusz Łukasik wrote:
> Package: sponsorship-requests
> Severity: important
> 
> Dear mentors,
> 
>   I am looking for a sponsor for my package "reptyr"
> 
>  * Package name: reptyr
>Version : 0.6.2-1.1
>Upstream Author : Evan Broder 
>  * URL : https://github.com/nelhage/reptyr
>  * License : Expat
>Section : misc
> 
>   It builds those binary packages:
> 
> reptyr - Tool for moving running programs between ptys
> 
>   To access further information about this package, please visit the
> following URL:
> 
>   https://mentors.debian.net/package/reptyr
> 
> 
>   Alternatively, one can download the package with dget using this command:
> 
> dget -x
> https://mentors.debian.net/debian/pool/main/r/reptyr/reptyr_0.6.2-1.1.dsc
> 
>   Changes since the last upload:
> 
>* Non-maintainer upload.
>   * Add patches from upstream to fix FTBFS with gcc-7. (Closes: #853640)
>   * debian/control:
> - Bump dh version to 11, 7 is deprecated.
> - Use secure VCS links.
> - Bump standards version to 4.1.3 (no changes).
> - Drop dpkg-dev from D-B. No longer needed.
>   * Fix watch file.
>   * debian/rules:
> - Add hardening.
> - Fix FTBFS when /dev/tty0 not exists.
> - Add check yama's only on Ubuntu.
> 
>   Regards,
>Mateusz Łukasik
> 
> 


signature.asc
Description: PGP signature

Bug#887040: RFS: reptyr/0.6.2-1.1 [RC] [NMU]

[Mateusz Łukasik]

Package: sponsorship-requests
Severity: important

Dear mentors,

  I am looking for a sponsor for my package "reptyr"

 * Package name: reptyr
   Version : 0.6.2-1.1
   Upstream Author : Evan Broder 
 * URL : https://github.com/nelhage/reptyr
 * License : Expat
   Section : misc

  It builds those binary packages:

reptyr - Tool for moving running programs between ptys

  To access further information about this package, please visit the 
following URL:


  https://mentors.debian.net/package/reptyr


  Alternatively, one can download the package with dget using this command:

dget -x 
https://mentors.debian.net/debian/pool/main/r/reptyr/reptyr_0.6.2-1.1.dsc


  Changes since the last upload:

   * Non-maintainer upload.
  * Add patches from upstream to fix FTBFS with gcc-7. (Closes: #853640)
  * debian/control:
- Bump dh version to 11, 7 is deprecated.
- Use secure VCS links.
- Bump standards version to 4.1.3 (no changes).
- Drop dpkg-dev from D-B. No longer needed.
  * Fix watch file.
  * debian/rules:
- Add hardening.
- Fix FTBFS when /dev/tty0 not exists.
- Add check yama's only on Ubuntu.

  Regards,
   Mateusz Łukasik