On Sun, Jan 21, 2018 at 04:19:37PM +0100, Andreas Henriksson wrote:
> On Sun, Jan 14, 2018 at 08:08:09PM +0100, Helmut Grohne wrote:
> > Package: nilfs-tools
> [...]
> > /sbin/mkfs.nilfs2 contains badblocks. According to file it is a ELF 64-bit
> > LSB executable, x86-64, version 1 (SYSV)
> [...]
>
> Indeed /sbin/badblocks is used, but there's code to check if it's
> available and bail out of disk checking with a warning message if not.
>
> I'd say this warrants at most a 'Suggests: e2fsprogs' relationship.
>
> Leaving it up to maintainer to decide if this should simply be closed
> or if adding the suggests is useful.
I looked into the most recent source (2.2.8-1) and this is still
accurate.
Dmitry, I noticed the package is under the "debian" salsa project, so I
took the liberty of pushing a commit to add a Suggests: e2fsprogs. Hope
that's helpful -- feel free to amend/revert if you disagree.
Regards,
Faidon
