Bug#888001: Bug#762261: lintian: introduce a inexistent-file-in-dep5-copyright rather confusing
Hi Mattia, > Not sure where you are heading here… As I suspect you know (☺) I'm not > interested in naming things. Right, nor am I, hence the many caveats I added that my names were only about clarifying what you are after here > To make it simple: this last paragraph should eming **only one tag** > saying the file doesn't match any file from the source package. Thanks. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#888001: Bug#762261: lintian: introduce a inexistent-file-in-dep5-copyright rather confusing
On Wed, Jan 24, 2018 at 04:16:38AM +0530, Chris Lamb wrote: > > > Files: specific-name > > > License: GPL-3 > > > > So this paragraph should already (please check if you have simple way > > to!) cause tag unused-file-paragraph-in-dep5-copyright to appear. > > To 100% clarify; this is because whilst the file exists in this example, > it should be "covered" by the "*" in "Files: *" below it? Not sure what you mean by "covered", but to me it's because the next paragarph overrides this one. > > > Files: * > > > License: GPL-3 > > > > > > Files: file-does-not-exist > > > License: GPL-3 > > > > This one should trigger the new tag I'm proposing. > > OTOH I think unused-file-paragraph-in-dep5-copyright is also emitted for > > this one, so it should stop emitting > > unused-file-paragraph-in-dep5-copyright and move to > > inexistent-file-in-dep5-copyright instead. > > I hate name arguments (!) but I think it's partly the names that are > making this harder than it "should" to understand. How about (at least > for now) "entry-does-not-match-any-files-in-package" for this last one > and (again, just for this discussion) "entry-covered-by-another-entry". Not sure where you are heading here… As I suspect you know (☺) I'm not interested in naming things. To make it simple: this last paragraph should eming **only one tag** saying the file doesn't match any file from the source package. > Terrible names, I know, but just to make the clarifications easier! "entry-coverd-by-another-entry" is probably wrong on many level, starting by anything else after the 'Files: *', as they would all "duplicate" a file already covered by the * !! ;) -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#888001: Bug#762261: lintian: introduce a inexistent-file-in-dep5-copyright rather confusing
Hi Mattia, > > Files: specific-name > > License: GPL-3 > > So this paragraph should already (please check if you have simple way > to!) cause tag unused-file-paragraph-in-dep5-copyright to appear. To 100% clarify; this is because whilst the file exists in this example, it should be "covered" by the "*" in "Files: *" below it? > > Files: * > > License: GPL-3 > > > > Files: file-does-not-exist > > License: GPL-3 > > This one should trigger the new tag I'm proposing. > OTOH I think unused-file-paragraph-in-dep5-copyright is also emitted for > this one, so it should stop emitting > unused-file-paragraph-in-dep5-copyright and move to > inexistent-file-in-dep5-copyright instead. I hate name arguments (!) but I think it's partly the names that are making this harder than it "should" to understand. How about (at least for now) "entry-does-not-match-any-files-in-package" for this last one and (again, just for this discussion) "entry-covered-by-another-entry". Terrible names, I know, but just to make the clarifications easier! Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#888001: Bug#762261: lintian: introduce a inexistent-file-in-dep5-copyright rather confusing
On Wed, Jan 24, 2018 at 03:48:31AM +0530, Chris Lamb wrote: > What do we want to end up with? Let's use this example > > Files: specific-name > License: GPL-3 So this paragraph should already (please check if you have simple way to!) cause tag unused-file-paragraph-in-dep5-copyright to appear. I believe what you did for #762261 to cover this case well enough. > Files: * > License: GPL-3 > > Files: file-does-not-exist > License: GPL-3 This one should trigger the new tag I'm proposing. OTOH I think unused-file-paragraph-in-dep5-copyright is also emitted for this one, so it should stop emitting unused-file-paragraph-in-dep5-copyright and move to inexistent-file-in-dep5-copyright instead. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Bug#888001: Bug#762261: lintian: introduce a inexistent-file-in-dep5-copyright rather confusing
Hi Mattia, > Control: clone -1 -2 > Control: tag -2 - pending > Control: retitle -2 lintian: introduce a inexistent-file-in-dep5-copyright > Control: severity -2 wishlist Thanks for splitting this (into #888001)! Let's try and get everything clear in my mind as the "non-existing" double-negative seems to be screwing with my brain for some reason. What do we want to end up with? Let's use this example Files: specific-name License: GPL-3 Files: * License: GPL-3 Files: file-does-not-exist License: GPL-3 What, exactly, should we emit for this? (Or, if my example above not sorted correctly, please alter!) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
