Bug#890019: zile testsuite fails with TERM=unknown

[Reuben Thomas]

On 10 February 2018 at 17:48, Axel Beckert  wrote:

> Hi Reuben,
>
> Reuben Thomas wrote:
> >​I just want to check, do you nonetheless consider this an upstream
> > bug?
>
> No. And my fix is adding "env TERM=vt100" debian/rules. :-)
>

​Thanks for the clarification!
​​

-- 
https://rrt.sc3d.org

Bug#890019: zile testsuite fails with TERM=unknown

[Axel Beckert]

Hi Reuben,

Reuben Thomas wrote:
>​I just want to check, do you nonetheless consider this an upstream
> bug?

No. And my fix is adding "env TERM=vt100" debian/rules. :-)

Will upload a fixed package soon.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Bug#890019: zile testsuite fails with TERM=unknown

[Reuben Thomas]

On 10 February 2018 at 09:52, Axel Beckert  wrote:

> Control: tag -1 + confirmed
>
> Hi Matthias,
>
> Matthias Klose wrote:
> > make  check-TESTS check-local
> > make[5]: Entering directory '/<>'
> > echo ./tests/*.el ./tests/interactive/*.el | abs_srcdir=/<>
> > srcdir=. TERM=unknown VALGRIND="" EMACSPROG="" xargs /usr/bin/perl
> > ./tests/run-lisp-tests.pl
> > make[6]: Entering directory '/<>'
> > Error opening terminal: unknown.
> > Zile failed to run test `backward-char' with error code 256
> > Error opening terminal: unknown.[...]
>
> This probably happens for a long time, but my try to make the build
> not garble my terminal during package build testing with "cat -v" had
> covered dh_auto_test's exit code. The latter is fixed now and hence
> test suite failures come to surface as they should
>
> Anyway, confirmed locally with
>
> $ env TERM=foobar debuild -uc -us
>
> > seen on the Ubuntu buildds.
>
> Interestingly not on Debian's buildds (except hurd-i386) nor in
> pbuilder (which AFAIK doesn't pass $TERM).
>
> Will add a fix.
>

​I just want to check, do you nonetheless consider this an upstream bug?
Should I recognise the value "unknown" as being equivalent to unset TERM?
The problem for me is that I don't want to override any setting from the
user: for example, it is nice if a user who builds from source gets the
tests run against the terminal they happen to be using.

-- 
https://rrt.sc3d.org

Bug#890019: zile testsuite fails with TERM=unknown

[Axel Beckert]

Hi Thomas,

Reuben Thomas wrote:
> ​See tests/Makefile.am:
> 
> TERM ?= vt100
> 
> This suggests that it has been explicitly set in the environment to
> "unknown".

Exactly. And it does make sense in general als there is no terminal
when the package build runs on automated build daemons.

I'm actually surprised that this didn't happen on all Debian build
daemons.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Bug#890019: zile testsuite fails with TERM=unknown

[Axel Beckert]

Control: tag -1 + confirmed

Hi Matthias,

Matthias Klose wrote:
> make  check-TESTS check-local
> make[5]: Entering directory '/<>'
> echo ./tests/*.el ./tests/interactive/*.el | abs_srcdir=/<>
> srcdir=. TERM=unknown VALGRIND="" EMACSPROG="" xargs /usr/bin/perl
> ./tests/run-lisp-tests.pl
> make[6]: Entering directory '/<>'
> Error opening terminal: unknown.
> Zile failed to run test `backward-char' with error code 256
> Error opening terminal: unknown.[...]

This probably happens for a long time, but my try to make the build
not garble my terminal during package build testing with "cat -v" had
covered dh_auto_test's exit code. The latter is fixed now and hence
test suite failures come to surface as they should

Anyway, confirmed locally with

$ env TERM=foobar debuild -uc -us

> seen on the Ubuntu buildds.

Interestingly not on Debian's buildds (except hurd-i386) nor in
pbuilder (which AFAIK doesn't pass $TERM).

Will add a fix.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Bug#890019: zile testsuite fails with TERM=unknown

[Reuben Thomas]

On 10 February 2018 at 08:25, Matthias Klose  wrote:

> Package: src:zile
> Version: 2.4.14-5
>
> The zile tests apparently expect a working terminal. Please set it
> explicitly
> when running the tests, e.g. TERM=xterm.
>

​See tests/Makefile.am:

TERM ?= vt100

This suggests that it has been explicitly set in the environment to
"unknown".

Bug#890019: zile testsuite fails with TERM=unknown

[Matthias Klose]

Package: src:zile
Version: 2.4.14-5

The zile tests apparently expect a working terminal. Please set it explicitly
when running the tests, e.g. TERM=xterm.

make  check-TESTS check-local
make[5]: Entering directory '/<>'
echo ./tests/*.el ./tests/interactive/*.el | abs_srcdir=/<>
srcdir=. TERM=unknown VALGRIND="" EMACSPROG="" xargs /usr/bin/perl
./tests/run-lisp-tests.pl
make[6]: Entering directory '/<>'
Error opening terminal: unknown.
Zile failed to run test `backward-char' with error code 256
Error opening terminal: unknown.[...]

seen on the Ubuntu buildds.