Bug#891493: numix-gtk-theme: Undocumented and very likely also broken Breaks against murrine-themes since 2.6.7-2

2019-06-06 Thread Mike Gabriel 

Hi folks,

On Tue, 28 May 2019 17:59:56 +0200 Andreas Beckmann  wrote:
> Followup-For: Bug #891493
> Control: severity -1 serious
>
> Hi,
>
> this unwarranted co-installability prevention between numix-gtk-theme and
> murrine-themes also causes a stretch -> buster upgrade issue detected by
> piuparts: numix-gtk-theme is kept at the version from stretch instead of
> being upgraded to buster:
>
> ...
> Starting 2 pkgProblemResolver with broken count: 1
> Investigating (0) numix-gtk-theme:amd64 < 2.6.6-1 -> 2.6.7-4 @ii umU Ib >
> Broken numix-gtk-theme:amd64 Breaks on murrine-themes:amd64 < 0.98.11 
@ii mK > (<= 0.98.11)
> Considering murrine-themes:amd64 6 as a solution to 
numix-gtk-theme:amd64 0
> Holding Back numix-gtk-theme:amd64 rather than change 
murrine-themes:amd64

> Try to Re-Instate (1) numix-gtk-theme:amd64
> Done
> ...
> The following packages have been kept back:
> numix-gtk-theme
> ...
>
> And the solution for the actual problem that you want to get fixed is
> quite simple: use a virtual package, e.g. any-gtk-theme, any-gtk2-theme,
> any-murrine-theme or whatever fits the purpose best.
>
> Package: gtk2-engines-murrine
> Recommends: murrine-themes (>= 0.98) | any-gtk-theme
>
> Package: numix-gtk-theme
> Depends: gtk2-engines-murrine (>= 0.98)
> Provides: any-gtk-theme
> Breaks: n/a
>
> Installing numix-gtk-theme will pull in gtk2-engines-murrine, but the
> Recommends in gtk2-engines-murrine is already satisfied, so it won't
> pull in murrine-themes as well.
>
> See e.g. the opencl-icd virtual package serving a similar purpose.
>
>
> Andreas

as the Debian and upstream maintainer of arctica-greeter (which has 
numix theming a its default theme), I have an interest in getting the 
above issue resolved.


As I see it, we need an upload for murrine-themes here (which adds the 
"Recommends: murrine-themes (>= 0.98) | any-gtk-theme" line) and an 
upload of numix-gtk-theme (adding the corresponding Provides: 
any-gtk-theme).


@Corsac: could you do that for murrine-themes (or allow an NMU or team 
upload by me?).


@All: what would be the appropriate name for the virtual package here 
(any-gtk-theme? any-murrine-theme? ...?).


@JBicha: Let me know if you can handle that extra upload once agreed on 
a name for the virtual package, or if you can do the upload (I should be 
still under Uploaders: field, right?).


@All: would other theme packages be affected and should they then also 
Provide: the virtual package?


Please, let's get this solved before buster. Thanks.

Greets,
MIke

Bug#891493: numix-gtk-theme: Undocumented and very likely also broken Breaks against murrine-themes since 2.6.7-2

2019-05-28 Thread Andreas Beckmann 
Followup-For: Bug #891493
Control: severity -1 serious

Hi,

this unwarranted co-installability prevention between numix-gtk-theme and
murrine-themes also causes a stretch -> buster upgrade issue detected by
piuparts: numix-gtk-theme is kept at the version from stretch instead of
being upgraded to buster:

...
  Starting 2 pkgProblemResolver with broken count: 1
  Investigating (0) numix-gtk-theme:amd64 < 2.6.6-1 -> 2.6.7-4 @ii umU Ib >
  Broken numix-gtk-theme:amd64 Breaks on murrine-themes:amd64 < 0.98.11 @ii mK 
> (<= 0.98.11)
Considering murrine-themes:amd64 6 as a solution to numix-gtk-theme:amd64 0
Holding Back numix-gtk-theme:amd64 rather than change murrine-themes:amd64
   Try to Re-Instate (1) numix-gtk-theme:amd64
  Done
...  
  The following packages have been kept back:
numix-gtk-theme
...

And the solution for the actual problem that you want to get fixed is
quite simple: use a virtual package, e.g. any-gtk-theme, any-gtk2-theme,
any-murrine-theme or whatever fits the purpose best.

Package: gtk2-engines-murrine
Recommends: murrine-themes (>= 0.98) | any-gtk-theme

Package: numix-gtk-theme
Depends: gtk2-engines-murrine (>= 0.98)
Provides: any-gtk-theme
Breaks: n/a

Installing numix-gtk-theme will pull in gtk2-engines-murrine, but the
Recommends in gtk2-engines-murrine is already satisfied, so it won't
pull in murrine-themes as well.

See e.g. the opencl-icd virtual package serving a similar purpose.


Andreas


numix-gtk-theme_2.6.7-4.log.gz
Description: application/gzip

Bug#891493: numix-gtk-theme: Undocumented and very likely also broken Breaks against murrine-themes since 2.6.7-2

2018-02-26 Thread Jeremy Bicha 
On Mon, Feb 26, 2018 at 2:53 AM, Axel Beckert  wrote:
> Since 2.6.7-2, numix-gtk-theme has a "Breaks: murrine-themes (<=
> 0.98.11)" without any mentioning (and especially without giving a
> reason) in debian/changelog.

Yes, I should have mentioned in the debian/changelog. I have uploaded
2.6.7-3 just now that does have some explanation in the
debian/changelog.

The Breaks is intentional. As the maintainer of numix-gtk-theme, I
feel that the Recommends on murrine-themes is wrong and I don't want
it to be installed just because someone installs Numix.

I am now the 3rd Debian Developer to object to the Murrine
Maintainer's dependency decision. (I did speak to him privately
earlier.) (And it's 4 if you count Steve Langasek acting in Ubuntu way
back in 2011.) In Debian, Maintainers have a lot of power over their
packages, maybe too much. I wish there were some lower level of
conflict resolution besides the Technical Committee. This issue may
end up needing to go there.

By the way, I also object to the other open wontfix Murrine bug (
https://bugs.debian.org/883411 ) but I can't workaround that. It's an
annoyance for, say, Debian MATE.

Thanks,
Jeremy Bicha

Bug#891493: numix-gtk-theme: Undocumented and very likely also broken Breaks against murrine-themes since 2.6.7-2

2018-02-25 Thread Axel Beckert 
Package: numix-gtk-theme
Version: 2.6.7-2

Since 2.6.7-2, numix-gtk-theme has a "Breaks: murrine-themes (<=
0.98.11)" without any mentioning (and especially without giving a
reason) in debian/changelog.

According to the commit message in
https://salsa.debian.org/desktop-themes-team/numix-gtk-theme/commit/6eb0c14fb93ef740ef13e59551178726d4efd9b5
it's because of https://bugs.debian.org/623783 and
https://bugs.debian.org/838994. But besides "Ugly workaround for #623783
and #838994" there's no real reason given, why this Breaks should
workaround any of these two bugs. And I don't find any reason for this
change in #623783.

In #838994 there is the following dicussion, citing from the mail of
Yves-Alexis Perez of 28 Sep 2016 at
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=838994#20:

> > > > NB!  I notice the recommendation is versioned.  If reason for
> > > > that is to avoid older versions being outright broken (e.g. due
> > > > to bug#827134), then it does not work as intended (only
> > > > versioned _depends_ is certain to be obeyed).  Use a versioned
> > > > _breaks_ instead.
> > >
> > > so something like:
> > >
> > > Recommends: murrine-themes
> > > Breaks: murrine-themes (<< 0.98.1)
 ^^
> >
> > Specifically addressing the versioning, yes.  Does not address the issue 
> > on topic for this bugreport.
>
> In any case, I really don't believe that's something important enough
> to lose time on it (specifically, I won't). As already stated, just
> remove the packages you don't want.

Please note that there is no talk about 0.98.11 but 0.98.1!

Additionally, the mentioned Recommends of gtk2-engines-murrine on
murrine-themes (which the suggested Breaks should complement) is
versioned as ">= 0.98".

Currently installing numix-gtk-theme wants to uninstall the _current_
version of murrine-themes from unstable which does not have any RC bug
and which I hence does not consider broken enough to be kicked out by
such a Breaks.

This all leads me to the assumption that someone indeed did not "lose
enough time on it" and added a Breaks against the wrong version (0.98.11
instead of 0.98.1) _and_ forgot to document it properly, too.

If I'm right with this assumption, this would be a bug of severity
serious and it should be fixed as follows:

Fix the Breaks against murrine-themes themes to be versioned as "(<<
0.98)" or "(<<0.98.1)" and retro-actively add the missing changelog
entry to 2.6.7-2.

Or just drop it all again, as murrine-themes 0.98.1 and 0.98 were
uploads from 2011 (and even wheezy/oldoldstable has 0.98.4) and there's
probably no reason to add a Breaks against them nowadays.

Or explain indepth why this Breaks should actually fix or workaround
anything.  It's not obvious at all and seems to do more harm than
good. (If just the explaination is missing, it's probably of severity
normal or minor.)

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (980, 'unstable-debug'), (600, 'testing'), 
(111, 'buildd-unstable'), (111, 'buildd-experimental'), (110, 'experimental'), 
(105, 'experimental-debug')
Architecture: amd64 (x86_64)

Kernel: Linux 4.14.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages numix-gtk-theme depends on:
ii  gtk2-engines-murrine  0.98.2-2
ii  numix-icon-theme  0~20171225-1

numix-gtk-theme recommends no packages.

numix-gtk-theme suggests no packages.

-- no debconf information