Bug#893377: Re: Bug#893377: RFS: taptempo/1.2.1-1 [ITP]

[Mo Zhou]

control: close -1

On Sat, Sep 15, 2018 at 03:53:02PM +0200, François Mazen wrote:
> Hi Lumin,
> 
> the file msys/mingw-bundledlls.py was committed by mistake. It is only
> needed to generate the Windows package.
> I've removed it in the upstream code and I generated a new release
> (1.4.3). I've also updated the copyright file for the new 1.4.3-1
> package.
> 
> The new package is tagged debian/1.4.3-1 in the packaging repository:
> 
> https://git.tuxfamily.org/taptempo/taptempo_deb_packaging.git/tag/?h=debian/1.4.3-1
> 
> and it's uploaded to mentors (just to check that everything is still
> fine).

Thanks. And uploaded.

Bug#893377: Re: Bug#893377: RFS: taptempo/1.2.1-1 [ITP]

[Paul Wise]

On Sat, Sep 15, 2018 at 9:53 PM, François Mazen wrote:

> the file msys/mingw-bundledlls.py was committed by mistake. It is only
> needed to generate the Windows package.
> I've removed it in the upstream code and I generated a new release
> (1.4.3). I've also updated the copyright file for the new 1.4.3-1
> package.

Please re-add it in the next version, people using Windows deserve to
be able to automatically rebuild Windows packages from modified
versions of the code.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Bug#893377: Re: Bug#893377: RFS: taptempo/1.2.1-1 [ITP]

[François Mazen]

Hi Lumin,

the file msys/mingw-bundledlls.py was committed by mistake. It is only
needed to generate the Windows package.
I've removed it in the upstream code and I generated a new release
(1.4.3). I've also updated the copyright file for the new 1.4.3-1
package.

The new package is tagged debian/1.4.3-1 in the packaging repository:

https://git.tuxfamily.org/taptempo/taptempo_deb_packaging.git/tag/?h=debian/1.4.3-1

and it's uploaded to mentors (just to check that everything is still
fine).

Best Regards,
François




Le vendredi 14 septembre 2018 à 03:09 +, Mo Zhou a écrit :
> On Thu, Sep 13, 2018 at 10:57:42PM +0200, François Mazen wrote:
> > Hi Lumin,
> > 
> > congratulation for your promotion as Debian Developer!
> > 
> > I downgraded the standard version of my package from 4.2.1 to 4.1.4
> > and
> > I uploaded it to mentors but Lintian has been updated in the
> > meantime.
> > So I've kept the 4.2.1 version and you can upload:
> > https://mentors.debian.net/package/taptempo
> 
> Oops, I have no idea when msys/mingw-bundledlls.py appeared in
> the source package but you have to add it to the copyright file.
> 
> The rest looks good to me. Please tag debian/1.4.2-1 in your
> packaging
> repository after fixing the copyright. I'll directly upload the
> package from your git repo instead of mentors. (So you don't have to
> upload to mentors again)

Bug#893377: Re: Bug#893377: RFS: taptempo/1.2.1-1 [ITP]

[Mo Zhou]

On Thu, Sep 13, 2018 at 10:57:42PM +0200, François Mazen wrote:
> Hi Lumin,
> 
> congratulation for your promotion as Debian Developer!
> 
> I downgraded the standard version of my package from 4.2.1 to 4.1.4 and
> I uploaded it to mentors but Lintian has been updated in the meantime.

> So I've kept the 4.2.1 version and you can upload:
> https://mentors.debian.net/package/taptempo

Oops, I have no idea when msys/mingw-bundledlls.py appeared in
the source package but you have to add it to the copyright file.

The rest looks good to me. Please tag debian/1.4.2-1 in your packaging
repository after fixing the copyright. I'll directly upload the
package from your git repo instead of mentors. (So you don't have to
upload to mentors again)

Bug#893377: Re: Bug#893377: RFS: taptempo/1.2.1-1 [ITP]

[François Mazen]

Hi Lumin,

congratulation for your promotion as Debian Developer!

I downgraded the standard version of my package from 4.2.1 to 4.1.4 and
I uploaded it to mentors but Lintian has been updated in the meantime.

So I've kept the 4.2.1 version and you can upload:
https://mentors.debian.net/package/taptempo

Thanks a lot for the sponsoring!

Best Regards,
François



Le jeudi 13 septembre 2018 à 11:59 +, Mo Zhou a écrit :
> control: owner -1 !
> 
> Hi François,
> 
> I can sponsor this package for you now. Would you mind updating the
> package and bump the standard version? Or should I upload it as is?


signature.asc
Description: This is a digitally signed message part

Bug#893377: Re: Bug#893377: RFS: taptempo/1.2.1-1 [ITP]

[Mo Zhou]

control: owner -1 !

Hi François,

I can sponsor this package for you now. Would you mind updating the
package and bump the standard version? Or should I upload it as is?

Bug#893377: RFS: taptempo/1.2.1-1 [ITP]

[François Mazen]

Hi,

I've uploaded a new release for my package taptempo (1.4.1-1), and I'm 
looking for a sponsor:

  Package: sponsorship-requests
  Severity: wishlist

  Dear mentors,

  I am looking for a sponsor for my package "taptempo"

 * Package name: taptempo
   Version : 1.4.1-1
   Upstream Author : Francois Mazen 
 * URL : https://taptempo.tuxfamily.org/
 * License : GPL-3.0
   Section : sound

  It builds those binary packages:

taptempo   - command line tap tempo

  To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/taptempo


  Alternatively, one can download the package with dget using this
command:

dget -x https://mentors.debian.net/debian/pool/main/t/taptempo/tapt
empo_1.4.1-1.dsc

  More information about TapTempo can be obtained from https://taptempo
.tuxfamily.org/.

  Changes since the last upload (1.3.0):

  - Move debian package code to a separate repository.
  - Add unit tests using Catch framework.
  - Add gaming mode with --game switch.
  - Fix Options class when calling multiple times getopt_long
  - Change "check" target to "test" target, to match debian packaging
system.


  Regards,
   Francois Mazen



Le mardi 10 avril 2018 à 05:11 +, Lumin a écrit :
> Hi François,
> 
> I'm trying to apply for DD so I'm helping newcomers to review their
> packages. As agreed by Gianfranco, once we've finished polising
> the packaging, he will check and sponsor the package.
> 
> Now your package is in good shape, and there is nothing left to
> be dealt with except for waiting for the sponsorship.
> Let's hope Gianfranco will find a time doing the sponsorship.
> 
> Regards,
> 
> On 9 April 2018 at 17:43, François Mazen  wrote:
> > Hi Lumin,
> > 
> > I just want to know if I must do something to go on with the
> > integration of TapTempo into Debian.
> > Should I submit again a RFS for the new package version?
> > 
> > Thanks a lot for your help,
> > François
> > 
> > 
> > Le mardi 03 avril 2018 à 23:13 +0200, François Mazen a écrit :
> > > Hi Lumin,
> > > 
> > > upload to mentors done, please check:
> > > https://mentors.debian.net/package/taptempo
> > > 
> > > Regards,
> > > 
> > > François
> > > 
> > > 
> > > 
> > > Le mardi 03 avril 2018 à 06:17 +, Lumin a écrit :
> > > > Hi François,
> > > > 
> > > > On 31 March 2018 at 21:59, François Mazen 
> > > > wrote:
> > > > > 
> > > > > This program is useful to quickly find the tempo of a song.
> > > > > The idea is to type "taptempo" in a terminal, then hit enter
> > > > > key
> > > > > at
> > > > > each beat while hearing a song, and display the tempo.
> > > > > 
> > > > > The targeted people are mainly musicians who need to
> > > > > transcribe
> > > > > music
> > > > > or play the song at the exact original tempo. The typical
> > > > > situation
> > > > > to
> > > > > use this software is when you are in a hurry and you don't
> > > > > have
> > > > > time to
> > > > > launch a big workstation like Ardour or Lmms in order to find
> > > > > the
> > > > > tempo.
> > > > 
> > > > Got it. Thank you for this explanation.
> > > > 
> > > > > 
> > > > > > 8. When you have built the latest version of the modified
> > > > > > package,
> > > > > > you could run lintian against it:
> > > > > > 
> > > > > > lintian -EviI --pedantic .changes
> > > > > > 
> > > > > > There generally shouldn't be any Error or Warning.
> > > > > 
> > > > > I've fixed all the error and the lintian output should be
> > > > > clean.
> > > > 
> > > > You have done quite a good job making the package in a good
> > > > shape,
> > > > and making the upstream very standard.
> > > > 
> > > > By the way I'm surprised that you have fixed all lintian
> > > > outputs,
> > > > including the pedantic stuff. The pedantic items are only
> > > > optional,
> > > > not what must be fixed. Errors and Warnings should be dealt
> > > > with,
> > > > and some lintian Info can even pass if the maintainer has a
> > > > good
> > > > reason.
> > > > 
> > > > In return everything's shining and in good shape :-)
> > > > 
> > > > > Let me know if it still require more work.
> > > > 
> > > > Nitpicking:
> > > > 
> > > > 1. Please collapse the two lines in changelog into one. They
> > > > refer
> > > > to
> > > > the same thing.
> > > > 
> > > > -  * Initial debian package.
> > > > -  * Closes: #893306
> > > > +  * Initial debian package. (Closes: #893306)
> > > > 
> > > > 2. there is still an autpkgtest problem:
> > > > 
> > > > autopkgtest [07:01:02]: test version: [---
> > > > spawn taptempo --version
> > > > couldn't execute "taptempo": no such file or directory
> > > > while executing
> > > > "spawn taptempo --version"
> > > > (file
> > > > "/tmp/autopkgtest.C3pEq9/build.uWo/src/debian/tests/version"
> > > > line
> > > > 6)
> > > > autopkgtest [07:01:03]: test version: ---]
> > > > autopkgtest [07:01:03]: test version:  - - - - - 

Bug#893377: RFS: taptempo/1.2.1-1 [ITP]

[Lumin]

Hi François,

I'm trying to apply for DD so I'm helping newcomers to review their
packages. As agreed by Gianfranco, once we've finished polising
the packaging, he will check and sponsor the package.

Now your package is in good shape, and there is nothing left to
be dealt with except for waiting for the sponsorship.
Let's hope Gianfranco will find a time doing the sponsorship.

Regards,

On 9 April 2018 at 17:43, François Mazen  wrote:
> Hi Lumin,
>
> I just want to know if I must do something to go on with the
> integration of TapTempo into Debian.
> Should I submit again a RFS for the new package version?
>
> Thanks a lot for your help,
> François
>
>
> Le mardi 03 avril 2018 à 23:13 +0200, François Mazen a écrit :
>> Hi Lumin,
>>
>> upload to mentors done, please check:
>> https://mentors.debian.net/package/taptempo
>>
>> Regards,
>>
>> François
>>
>>
>>
>> Le mardi 03 avril 2018 à 06:17 +, Lumin a écrit :
>> > Hi François,
>> >
>> > On 31 March 2018 at 21:59, François Mazen  wrote:
>> > >
>> > > This program is useful to quickly find the tempo of a song.
>> > > The idea is to type "taptempo" in a terminal, then hit enter key
>> > > at
>> > > each beat while hearing a song, and display the tempo.
>> > >
>> > > The targeted people are mainly musicians who need to transcribe
>> > > music
>> > > or play the song at the exact original tempo. The typical
>> > > situation
>> > > to
>> > > use this software is when you are in a hurry and you don't have
>> > > time to
>> > > launch a big workstation like Ardour or Lmms in order to find the
>> > > tempo.
>> >
>> > Got it. Thank you for this explanation.
>> >
>> > >
>> > > > 8. When you have built the latest version of the modified
>> > > > package,
>> > > > you could run lintian against it:
>> > > >
>> > > > lintian -EviI --pedantic .changes
>> > > >
>> > > > There generally shouldn't be any Error or Warning.
>> > >
>> > > I've fixed all the error and the lintian output should be clean.
>> >
>> > You have done quite a good job making the package in a good shape,
>> > and making the upstream very standard.
>> >
>> > By the way I'm surprised that you have fixed all lintian outputs,
>> > including the pedantic stuff. The pedantic items are only optional,
>> > not what must be fixed. Errors and Warnings should be dealt with,
>> > and some lintian Info can even pass if the maintainer has a good
>> > reason.
>> >
>> > In return everything's shining and in good shape :-)
>> >
>> > > Let me know if it still require more work.
>> >
>> > Nitpicking:
>> >
>> > 1. Please collapse the two lines in changelog into one. They refer
>> > to
>> > the same thing.
>> >
>> > -  * Initial debian package.
>> > -  * Closes: #893306
>> > +  * Initial debian package. (Closes: #893306)
>> >
>> > 2. there is still an autpkgtest problem:
>> >
>> > autopkgtest [07:01:02]: test version: [---
>> > spawn taptempo --version
>> > couldn't execute "taptempo": no such file or directory
>> > while executing
>> > "spawn taptempo --version"
>> > (file
>> > "/tmp/autopkgtest.C3pEq9/build.uWo/src/debian/tests/version" line
>> > 6)
>> > autopkgtest [07:01:03]: test version: ---]
>> > autopkgtest [07:01:03]: test version:  - - - - - - - - - - results
>> > -
>> > -
>> > - - - - - - - -
>> > version  FAIL non-zero exit status 1
>> > autopkgtest [07:01:03]: test version:  - - - - - - - - - - stderr -
>> > -
>> > - - - - - - - -
>> > couldn't execute "taptempo": no such file or directory
>> > while executing
>> > "spawn taptempo --version"
>> > (file
>> > "/tmp/autopkgtest.C3pEq9/build.uWo/src/debian/tests/version" line
>> > 6)
>> >
>> > this can be fixed by the patch. It looks somewhat wired but we need
>> > it.
>> >
>> > --- a/debian/tests/control
>> > +++ b/debian/tests/control
>> > @@ -1,2 +1,2 @@
>> >  Tests: version, help, tempo
>> > -Depends: expect
>> > +Depends: expect, taptempo
>> >
>> > The autopkgtest result after patched:
>> >
>> > http://debomatic-amd64.debian.net/distribution#unstable/taptempo/1.
>> > 3.
>> > 0-1/autopkgtest
>> >
>> > build result:
>> >
>> > http://debomatic-amd64.debian.net/distribution#unstable/taptempo/1.
>> > 3.
>> > 0-1/buildlog
>> >
>> > > Should I update this new package to the mentors website?
>> >
>> > Yes, please fix the two problem mentioned above, and upload to
>> > mentors.
>> >
>> > Thank you for you contribution to Debian, and have a good day.



-- 
Best,

Bug#893377: RFS: taptempo/1.2.1-1 [ITP]

[François Mazen]

Hi Lumin,

upload to mentors done, please check:
https://mentors.debian.net/package/taptempo

Regards,

François



Le mardi 03 avril 2018 à 06:17 +, Lumin a écrit :
> Hi François,
> 
> On 31 March 2018 at 21:59, François Mazen  wrote:
> > 
> > This program is useful to quickly find the tempo of a song.
> > The idea is to type "taptempo" in a terminal, then hit enter key at
> > each beat while hearing a song, and display the tempo.
> > 
> > The targeted people are mainly musicians who need to transcribe
> > music
> > or play the song at the exact original tempo. The typical situation
> > to
> > use this software is when you are in a hurry and you don't have
> > time to
> > launch a big workstation like Ardour or Lmms in order to find the
> > tempo.
> 
> Got it. Thank you for this explanation.
> 
> > 
> > > 8. When you have built the latest version of the modified
> > > package,
> > > you could run lintian against it:
> > > 
> > > lintian -EviI --pedantic .changes
> > > 
> > > There generally shouldn't be any Error or Warning.
> > 
> > I've fixed all the error and the lintian output should be clean.
> 
> You have done quite a good job making the package in a good shape,
> and making the upstream very standard.
> 
> By the way I'm surprised that you have fixed all lintian outputs,
> including the pedantic stuff. The pedantic items are only optional,
> not what must be fixed. Errors and Warnings should be dealt with,
> and some lintian Info can even pass if the maintainer has a good
> reason.
> 
> In return everything's shining and in good shape :-)
> 
> > Let me know if it still require more work.
> 
> Nitpicking:
> 
> 1. Please collapse the two lines in changelog into one. They refer to
> the same thing.
> 
> -  * Initial debian package.
> -  * Closes: #893306
> +  * Initial debian package. (Closes: #893306)
> 
> 2. there is still an autpkgtest problem:
> 
> autopkgtest [07:01:02]: test version: [---
> spawn taptempo --version
> couldn't execute "taptempo": no such file or directory
> while executing
> "spawn taptempo --version"
> (file
> "/tmp/autopkgtest.C3pEq9/build.uWo/src/debian/tests/version" line 6)
> autopkgtest [07:01:03]: test version: ---]
> autopkgtest [07:01:03]: test version:  - - - - - - - - - - results -
> -
> - - - - - - - -
> version  FAIL non-zero exit status 1
> autopkgtest [07:01:03]: test version:  - - - - - - - - - - stderr - -
> - - - - - - - -
> couldn't execute "taptempo": no such file or directory
> while executing
> "spawn taptempo --version"
> (file
> "/tmp/autopkgtest.C3pEq9/build.uWo/src/debian/tests/version" line 6)
> 
> this can be fixed by the patch. It looks somewhat wired but we need
> it.
> 
> --- a/debian/tests/control
> +++ b/debian/tests/control
> @@ -1,2 +1,2 @@
>  Tests: version, help, tempo
> -Depends: expect
> +Depends: expect, taptempo
> 
> The autopkgtest result after patched:
> 
> http://debomatic-amd64.debian.net/distribution#unstable/taptempo/1.3.
> 0-1/autopkgtest
> 
> build result:
> 
> http://debomatic-amd64.debian.net/distribution#unstable/taptempo/1.3.
> 0-1/buildlog
> 
> > Should I update this new package to the mentors website?
> 
> Yes, please fix the two problem mentioned above, and upload to
> mentors.
> 
> Thank you for you contribution to Debian, and have a good day.

signature.asc
Description: This is a digitally signed message part

Bug#893377: RFS: taptempo/1.2.1-1 [ITP]

[Lumin]

Hi François,

On 31 March 2018 at 21:59, François Mazen  wrote:
>
> This program is useful to quickly find the tempo of a song.
> The idea is to type "taptempo" in a terminal, then hit enter key at
> each beat while hearing a song, and display the tempo.
>
> The targeted people are mainly musicians who need to transcribe music
> or play the song at the exact original tempo. The typical situation to
> use this software is when you are in a hurry and you don't have time to
> launch a big workstation like Ardour or Lmms in order to find the
> tempo.

Got it. Thank you for this explanation.

>
>> 8. When you have built the latest version of the modified package,
>> you could run lintian against it:
>>
>> lintian -EviI --pedantic .changes
>>
>> There generally shouldn't be any Error or Warning.
>
> I've fixed all the error and the lintian output should be clean.

You have done quite a good job making the package in a good shape,
and making the upstream very standard.

By the way I'm surprised that you have fixed all lintian outputs,
including the pedantic stuff. The pedantic items are only optional,
not what must be fixed. Errors and Warnings should be dealt with,
and some lintian Info can even pass if the maintainer has a good
reason.

In return everything's shining and in good shape :-)

> Let me know if it still require more work.

Nitpicking:

1. Please collapse the two lines in changelog into one. They refer to
the same thing.

-  * Initial debian package.
-  * Closes: #893306
+  * Initial debian package. (Closes: #893306)

2. there is still an autpkgtest problem:

autopkgtest [07:01:02]: test version: [---
spawn taptempo --version
couldn't execute "taptempo": no such file or directory
while executing
"spawn taptempo --version"
(file "/tmp/autopkgtest.C3pEq9/build.uWo/src/debian/tests/version" line 6)
autopkgtest [07:01:03]: test version: ---]
autopkgtest [07:01:03]: test version:  - - - - - - - - - - results - -
- - - - - - - -
version  FAIL non-zero exit status 1
autopkgtest [07:01:03]: test version:  - - - - - - - - - - stderr - -
- - - - - - - -
couldn't execute "taptempo": no such file or directory
while executing
"spawn taptempo --version"
(file "/tmp/autopkgtest.C3pEq9/build.uWo/src/debian/tests/version" line 6)

this can be fixed by the patch. It looks somewhat wired but we need it.

--- a/debian/tests/control
+++ b/debian/tests/control
@@ -1,2 +1,2 @@
 Tests: version, help, tempo
-Depends: expect
+Depends: expect, taptempo

The autopkgtest result after patched:

http://debomatic-amd64.debian.net/distribution#unstable/taptempo/1.3.0-1/autopkgtest

build result:

http://debomatic-amd64.debian.net/distribution#unstable/taptempo/1.3.0-1/buildlog

> Should I update this new package to the mentors website?

Yes, please fix the two problem mentioned above, and upload to mentors.

Thank you for you contribution to Debian, and have a good day.

Bug#893377: RFS: taptempo/1.2.1-1 [ITP]

[François Mazen]

Hi,

I've chosen to create a separate repo for packaging:
https://git.tuxfamily.org/taptempo/taptempo_deb_packaging.git

and I will soon remove the debian folder in the upstream repository.

> 0. This program seems to be a terminal bpm meter. I'm not quite good
> at music stuff, so I'd like to make sure:
> 0.1  For what purpose can this program be used?
> 0.2  Who's the targeted people of this program?

This program is useful to quickly find the tempo of a song.
The idea is to type "taptempo" in a terminal, then hit enter key at
each beat while hearing a song, and display the tempo.

The targeted people are mainly musicians who need to transcribe music
or play the song at the exact original tempo. The typical situation to
use this software is when you are in a hurry and you don't have time to
launch a big workstation like Ardour or Lmms in order to find the
tempo.


> 8. When you have built the latest version of the modified package,
> you could run lintian against it:
> 
> lintian -EviI --pedantic .changes
> 
> There generally shouldn't be any Error or Warning.

I've fixed all the error and the lintian output should be clean.

Let me know if it still require more work.

Should I update this new package to the mentors website?

Thanks,
François






Le mardi 27 mars 2018 à 07:05 +, Lumin a écrit :
> Hi François,
> 
> On 26 March 2018 at 19:56, François Mazen  wrote:
> > I've manually changed the timestamp of the changelog file from the
> > original repo, and I haven't check that the date was wrong. I can
> > update the changelog file.
> 
> I've seen new commits in the repo. Let's assume it's the latest
> version
> we would talk about. The following discussion will be based on
> https://github.com/moleculext/taptempo
> 
> > The public key is published on the sks-keyservers network. Should I
> > sent it to debian keyring or other keyserver?
> 
> I can retrieve the key now.
> 
> > Should I submit a new revision of the package (1.2.1-2) or re-
> > upload
> > with the current revision number (1.2.1-1)?
> 
> Not necessary. Further changes are needed, I'll check the git repo
> directly since there is delay for mentor uploads.
> 
> Here are a list of problems I have found:
> 
> 0. This program seems to be a terminal bpm meter. I'm not quite good
> at music stuff, so I'd like to make sure:
> 0.1  For what purpose can this program be used?
> 0.2  Who's the targeted people of this program?
> 
> 1. Upstream source should not contain a "debian" directory. However,
> you seem to be the upstream author, so you have two choices:
> (a) remove debian directory from source, and create another
> packaging
>  repo where the debian directory is tracked.
> (b) change source/format to 3.0 (naitive). In this way you can
> keep
>  the debian directory in upstream source.
> 
> 2. The standards version is quite out of date. You could lookup the
> update
> checklist of Debian Policy[2], and update the standards version
> to the
> latest one (version 4.1.3).
> 
> 3. Debhelper compatibility version is old. Version 11 is preferred.
> 
> 4. control: the long discription is somewhat short. Could you please
> explain a bit more about the program's purpose and functionality?
> 
> 5. changelog: It should close the ITP bug you've submitted. e.g.
> Close: #XXX
> 
> 6. control: I'd recommend to add the Vcs-Git and Vcs-Browser field
> which
> point to the packaging repository. And add a homepage which
> points
> to the upstream homepage or simply the upstream repo.
> 
> 7. Hardening flags[3] should be added to rules. i.e.
> export DEB_BUILD_MAINT_OPTIONS   = hardening=+all
> 
> 8. When you have built the latest version of the modified package,
> you could run lintian against it:
> 
> lintian -EviI --pedantic .changes
> 
> There generally shouldn't be any Error or Warning.
> 
> 9. changelog: please keep the version number aligned with upstream
> version.
> or thing may get into a mess.
> 
> I'll check the git repo again once you have updated it. If you have
> any
> questions about the above points, just feel free to ask
> 
> [1] https://www.debian.org/doc/manuals/maint-guide/index.en.html
> [2] https://www.debian.org/doc/debian-policy/
> [3] https://wiki.debian.org/Hardening
> 

Bug#893377: RFS: taptempo/1.2.1-1 [ITP]

[Lumin]

Hi François,

On 26 March 2018 at 19:56, François Mazen  wrote:
> I've manually changed the timestamp of the changelog file from the
> original repo, and I haven't check that the date was wrong. I can
> update the changelog file.

I've seen new commits in the repo. Let's assume it's the latest version
we would talk about. The following discussion will be based on
https://github.com/moleculext/taptempo

> The public key is published on the sks-keyservers network. Should I
> sent it to debian keyring or other keyserver?

I can retrieve the key now.

> Should I submit a new revision of the package (1.2.1-2) or re-upload
> with the current revision number (1.2.1-1)?

Not necessary. Further changes are needed, I'll check the git repo
directly since there is delay for mentor uploads.

Here are a list of problems I have found:

0. This program seems to be a terminal bpm meter. I'm not quite good
at music stuff, so I'd like to make sure:
0.1  For what purpose can this program be used?
0.2  Who's the targeted people of this program?

1. Upstream source should not contain a "debian" directory. However,
you seem to be the upstream author, so you have two choices:
(a) remove debian directory from source, and create another packaging
 repo where the debian directory is tracked.
(b) change source/format to 3.0 (naitive). In this way you can keep
 the debian directory in upstream source.

2. The standards version is quite out of date. You could lookup the update
checklist of Debian Policy[2], and update the standards version to the
latest one (version 4.1.3).

3. Debhelper compatibility version is old. Version 11 is preferred.

4. control: the long discription is somewhat short. Could you please
explain a bit more about the program's purpose and functionality?

5. changelog: It should close the ITP bug you've submitted. e.g. Close: #XXX

6. control: I'd recommend to add the Vcs-Git and Vcs-Browser field which
point to the packaging repository. And add a homepage which points
to the upstream homepage or simply the upstream repo.

7. Hardening flags[3] should be added to rules. i.e.
export DEB_BUILD_MAINT_OPTIONS   = hardening=+all

8. When you have built the latest version of the modified package,
you could run lintian against it:

lintian -EviI --pedantic .changes

There generally shouldn't be any Error or Warning.

9. changelog: please keep the version number aligned with upstream version.
or thing may get into a mess.

I'll check the git repo again once you have updated it. If you have any
questions about the above points, just feel free to ask

[1] https://www.debian.org/doc/manuals/maint-guide/index.en.html
[2] https://www.debian.org/doc/debian-policy/
[3] https://wiki.debian.org/Hardening

-- 
Best,

Bug#893377: RFS: taptempo/1.2.1-1 [ITP]

[François Mazen]

Hi Lumin,

thanks a lot for your help. I'll try to fix everything.

> 1. Why is the package on mentors newer than that on github repo?
> Could you please keep the packaging repo up-to-date?

I've manually changed the timestamp of the changelog file from the
original repo, and I haven't check that the date was wrong. I can
update the changelog file.

> 
> 2. Where is your public key? no such key on keyserver.
> 
> 86A5ABD6FFDB0A0C7F5057D34797FA721C351C9E

The public key is published on the sks-keyservers network. Should I
sent it to debian keyring or other keyserver?

http://hkps.pool.sks-keyservers.net/pks/lookup?search=0x86A5ABD6FFDB0A0C7F5057D34797FA721C351C9E


> 
> 3. There are still many problems related to package, let's
> discuss on that once we have a synced git repository
> to talk about.

Should I submit a new revision of the package (1.2.1-2) or re-upload
with the current revision number (1.2.1-1)?

Regards,
François

Bug#893377: RFS: taptempo/1.2.1-1 [ITP]

[Lumin]

Control: owner -1 !
Control: tag -1 +moreinfo

Hi François,

Several questions about your package:

1. Why is the package on mentors newer than that on github repo?
Could you please keep the packaging repo up-to-date?

https://github.com/moleculext/taptempo

2. Where is your public key? no such key on keyserver.

86A5ABD6FFDB0A0C7F5057D34797FA721C351C9E

3. There are still many problems related to package, let's
discuss on that once we have a synced git repository
to talk about.


-- 
Best,

Bug#893377: RFS: taptempo/1.2.1-1 [ITP]

[François Mazen]

Package: sponsorship-requests
  Severity: wishlist

  Dear mentors,

  I am looking for a sponsor for my package "taptempo"

 * Package name: taptempo
   Version : 1.2.1-1
   Upstream Author : Francois Mazen 
 * URL : https://github.com/moleculext/taptempo
 * License : GPL-3.0
   Section : misc

  It builds those binary packages:

taptempo   - command line tap tempo

  To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/taptempo


  Alternatively, one can download the package with dget using this
command:

dget -x https://mentors.debian.net/debian/pool/main/t/taptempo/tapt
empo_1.2.1-1.dsc

  More information about TapTempo can be obtained from https://github.c
om/moleculext/taptempo.

  Changes since the last upload:

taptempo (1.2.1-1) unstable; urgency=low

  * Initial debian package.
  * Closes: #893306

 -- Francois Mazen   Sun, 18 Mar 2018 09:52:03 +0100


  Regards,
   Francois Mazen