Bug#893572: tracker.debian.org: Debian Maintainer display: [dm] links empty, should be uppercase and use parentheses
Ok. No dm.txt. Thanks Paul and Raphael. Regards, Herbert Em sáb, 15 de jun de 2019 05:52, Raphael Hertzog escreveu: > On Sat, 15 Jun 2019, Raphael Hertzog wrote: > > I also don't know why you picked this bug report to start your journey > > into distro-tracker. It's not a trivial issue to fix and the added value > > is relatively low compared to other missing features. > > > > I took the time to highlight easy bugs with the newcomer tag, > > maybe you should start with some of those? > > Ah, I see the bug was tagged as newcomer by Paul in fact. I suggest > you first deal with all the requests in this bug except the last > idea to display who approved the DM right... the rest should be relatively > easy. > > Cheers, > -- > Raphaël Hertzog ◈ Debian Developer > > Support Debian LTS: https://www.freexian.com/services/debian-lts.html > Learn to master Debian: https://debian-handbook.info/get/ >
Bug#893572: tracker.debian.org: Debian Maintainer display: [dm] links empty, should be uppercase and use parentheses
On Sat, 15 Jun 2019, Raphael Hertzog wrote: > I also don't know why you picked this bug report to start your journey > into distro-tracker. It's not a trivial issue to fix and the added value > is relatively low compared to other missing features. > > I took the time to highlight easy bugs with the newcomer tag, > maybe you should start with some of those? Ah, I see the bug was tagged as newcomer by Paul in fact. I suggest you first deal with all the requests in this bug except the last idea to display who approved the DM right... the rest should be relatively easy. Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: https://www.freexian.com/services/debian-lts.html Learn to master Debian: https://debian-handbook.info/get/ signature.asc Description: PGP signature
Bug#893572: tracker.debian.org: Debian Maintainer display: [dm] links empty, should be uppercase and use parentheses
On Sat, 15 Jun 2019, Paul Wise wrote: > On Fri, 2019-06-14 at 16:13 -0300, Herbert Fortes wrote: > > > Should dm.txt file be downloaded and read once a day? > > (to update/save new info) > > I note there is already code in RetrieveDebianMaintainersTask that > downloads and processes dm.txt so perhaps that should be used. Definitely, and you also don't want to use urlopen() in any web request, that doesn't scale... we would be hammering ftp-master to retrieve the same information over and over. And we have our own code to retrieve data over HTTP (get_resource_text) so we don't use urlopen(). Herbert, you need to come up with a good design before you get into coding. Here are some rough guidelines: 1/ you want to handle all the processing of the dm.txt file in RetrieveDebianMaintainersTask, you want to parse the "dd_fpr" variable that we already extract 2/ you want to come up with a way to store that data in the database, I would probably opt to add a JSONField to the DebianContributor model so that you can store a hash associating "package => granted_by". 3/ then you need to modify the template and the associated context to display that information I also don't know why you picked this bug report to start your journey into distro-tracker. It's not a trivial issue to fix and the added value is relatively low compared to other missing features. I took the time to highlight easy bugs with the newcomer tag, maybe you should start with some of those? https://bugs.debian.org/cgi-bin/pkgreport.cgi?dist=unstable;package=tracker.debian.org;tag=newcomer https://salsa.debian.org/qa/distro-tracker/issues?label_name%5B%5D=newcomer Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: https://www.freexian.com/services/debian-lts.html Learn to master Debian: https://debian-handbook.info/get/ signature.asc Description: PGP signature
Bug#893572: tracker.debian.org: Debian Maintainer display: [dm] links empty, should be uppercase and use parentheses
On Fri, 2019-06-14 at 16:13 -0300, Herbert Fortes wrote: > Should dm.txt file be downloaded and read once a day? > (to update/save new info) I note there is already code in RetrieveDebianMaintainersTask that downloads and processes dm.txt so perhaps that should be used. -- bye, pabs https://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#893572: tracker.debian.org: Debian Maintainer display: [dm] links empty, should be uppercase and use parentheses
> Should dm.txt file be downloaded and read once a day? > (to update/save new info) > > 'class DebianContributor(models.Model)' has 'allowed_packages' and > 'is_debian_maintainer' > > Or a dictionary. > > I set 'DISTRO_TRACKER_DATA_PATH' + 'cache/dm.txt' for now. But no > downloads yet. > > Here is the forked repository: > https://salsa.debian.org/hpfn/distro-tracker/commit/56b2a5d95f9ce4aa3eaee9e21668a45d54a79094 I did a commit to use 'urlopen' and do not have to worry about it. Regards, Herbert
Bug#893572: tracker.debian.org: Debian Maintainer display: [dm] links empty, should be uppercase and use parentheses
On 6/13/19 6:14 PM, Raphael Hertzog wrote:
> Hi,
>
> On Thu, 13 Jun 2019, Herbert Fortes wrote:
>> I found where to make the change. But the information about
>> who gave the permission I do not know where it is at *debian.org.
>>
>> In distro_tracker/vendor/debian/rules.py file:
>>
>> _add_dm_entry function - extra.append({'display': 'dm'})
>>
>> 'link': "https://ftp-master.debian.org/dm.txt;
>> 'description': "Debian Maintainer upload allowed by Andreas Henriksson"
>
> In https://ftp-master.debian.org/dm.txt behind each package, there's a
> fingerprint between parenthesis. This fingerprint is the fingerprint
> of the key who signed the addition of the DM right. So if you can map
> that back to a name, then you're good.
>
> There's some code doing that already with the help of the GPG keyring
> that we have configured, see verify_signature() in
> distro_tracker/core/utils/__init__.py (in particular
> ctx.get_key(...)).
>
Ok.
What I did seems to work. I added two tests for a function that I
created - allowed_by(pkg).
Initial lines are copy from verify_signature (it does not work
when passing a fingerprint to it).
The function reads dm.txt file to get the fingerprint and gives it to
gpg.Context().get_key(). One test added to return 'None'. One test
added to return 'PTS Tests'.
I edited these files:
- distro_tracker/core/tests/tests-data/cache/dm.txt - one DM
- distro_tracker/core/tests/tests_utils.py
- distro_tracker/core/utils/__init__.py
- distro_tracker/vendor/debian/rules.py
- distro_tracker/vendor/debian/tests.py
It is a first step.
Should dm.txt file be downloaded and read once a day?
(to update/save new info)
'class DebianContributor(models.Model)' has 'allowed_packages' and
'is_debian_maintainer'
Or a dictionary.
I set 'DISTRO_TRACKER_DATA_PATH' + 'cache/dm.txt' for now. But no
downloads yet.
Here is the forked repository:
https://salsa.debian.org/hpfn/distro-tracker/commit/56b2a5d95f9ce4aa3eaee9e21668a45d54a79094
Regards,
Herbert
Bug#893572: tracker.debian.org: Debian Maintainer display: [dm] links empty, should be uppercase and use parentheses
Hi,
On Thu, 13 Jun 2019, Herbert Fortes wrote:
> I found where to make the change. But the information about
> who gave the permission I do not know where it is at *debian.org.
>
> In distro_tracker/vendor/debian/rules.py file:
>
> _add_dm_entry function - extra.append({'display': 'dm'})
>
> 'link': "https://ftp-master.debian.org/dm.txt;
> 'description': "Debian Maintainer upload allowed by Andreas Henriksson"
In https://ftp-master.debian.org/dm.txt behind each package, there's a
fingerprint between parenthesis. This fingerprint is the fingerprint
of the key who signed the addition of the DM right. So if you can map
that back to a name, then you're good.
There's some code doing that already with the help of the GPG keyring
that we have configured, see verify_signature() in
distro_tracker/core/utils/__init__.py (in particular
ctx.get_key(...)).
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/
Bug#893572: tracker.debian.org: Debian Maintainer display: [dm] links empty, should be uppercase and use parentheses
Hi,
On Wed, 21 Mar 2018 10:32:00 +0800 Paul Wise wrote:
> On Tue, 20 Mar 2018 07:25:35 +0800 Paul Wise wrote:
>
> > I think these changes are needed:
>
> It would also be nice to have info on who approved the package.
>
> > Here is how these changes should look in the HTML:
>
> Updated version:
>
>
> (https://ftp-master.debian.org/dm.txt;> title="Debian Maintainer upload allowed by Andreas
> Henriksson">DM)
>
>
I found where to make the change. But the information about
who gave the permission I do not know where it is at *debian.org.
In distro_tracker/vendor/debian/rules.py file:
_add_dm_entry function - extra.append({'display': 'dm'})
'link': "https://ftp-master.debian.org/dm.txt;
'description': "Debian Maintainer upload allowed by Andreas Henriksson"
Regards,
Herber
Bug#893572: tracker.debian.org: Debian Maintainer display: [dm] links empty, should be uppercase and use parentheses
On Tue, 20 Mar 2018 07:25:35 +0800 Paul Wise wrote: > I think these changes are needed: It would also be nice to have info on who approved the package. > Here is how these changes should look in the HTML: Updated version: (https://ftp-master.debian.org/dm.txt;>DM) -- bye, pabs https://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#893572: tracker.debian.org: Debian Maintainer display: [dm] links empty, should be uppercase and use parentheses
Package: tracker.debian.org Severity: minor Tags: newcomer On the libgit2 page there is a link next to the Maintainer: [dm] https://tracker.debian.org/pkg/libgit2 I think these changes are needed: * the dm should be uppercase (possibly in smallcaps), because it is an acronym for Debian Maintainer * use an acronym tag, because DM is an acronym for Debian Maintainer * use "Debian Maintainer upload allowed" for the explanation title, inthat case the abbrev tag should be used instead of the acronym tag * use parentheses instead of crotchets/brackets to differentiate it from the DMD link a bit and because the PTS used that * the link should be removed or changed to dm.txt since that is the only source of information about DM upload permissions. Here is how these changes should look in the HTML: (https://ftp-master.debian.org/dm.txt; title="">DM) Or: (DM) -- bye, pabs https://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
