Bug#893739: gettext: FTBFS with openjdk-9 as default-jdk

2018-03-23 Thread Santiago Vila 
severity 893739 serious
thanks

Hi.

This is really a serious bug because it's a FTBFS bug.

The reason I bother to raise the severity even if I'm about to apply
the proposed patch in short is that there is yet another serious bug
around that would prevent the package from entering testing.

Hopefully the testing scripts will detect that this release has one
less serious bug than the previous one and will let it pass to buster.

Thanks.

Bug#893739: gettext: FTBFS with openjdk-9 as default-jdk

2018-03-21 Thread Tiago Daitx 
Dear Maintainer,

Sorry for confusing initial report.
I'm copying the original message bellow and attaching the debdiff for
review again.


Currently gettext FTBFS when building with openjdk-9 due to:

cp: cannot stat 'debian/tmp/usr/share/gettext/libintl.jar': No such
file or directory

which in turn is caused by a configure failing to detect openjdk:
checking for Java virtual machine... java
configure: WARNING: unknown target-version 9, please update gt_JAVACOMP macro
checking for Java compiler... no


For comparison, the above message, when compiling with OpenJDK 8 is:
checking for Java virtual machine... java
configure: WARNING: unknown target-version 1.8, please update gt_JAVACOMP macro
checking for Java compiler... /usr/lib/jvm/default-java/bin/javac
-target 1.1 -source 1.3


The attached debdiff, copied from opensuse and modified to include
support for source/target 1.7 and 1.8, fixes this issue.

The configure message, with the patch applied, is:
checking for Java virtual machine... java
configure: WARNING: unknown target-version 9, please update gt_JAVACOMP macro
checking for Java compiler... no


Please consider applying it to enable the work for transitioning
default-jdk from openjdk-8 to openjdk-9.

thanks
Tiago Daitx
diff -Nru gettext-0.19.8.1/debian/changelog gettext-0.19.8.1/debian/changelog
--- gettext-0.19.8.1/debian/changelog	2018-03-04 09:24:05.0 +0100
+++ gettext-0.19.8.1/debian/changelog	2018-03-20 19:47:19.0 +0100
@@ -1,3 +1,10 @@
+gettext (0.19.8.1-4ubuntu5~02) UNRELEASED; urgency=medium
+
+  * d/p/04-enable-jdk9-compatibility.patch: enable building with
+source and target flags set to 1.8; update gt_JAVACOMP macro.
+
+ -- Tiago Stürmer Daitx   Tue, 20 Mar 2018 18:47:19 +
+
gettext (0.19.8.1-4) unstable; urgency=medium

  * Avoid extraneous NUL bytes in .mo files. Closes: #872869.
diff -Nru gettext-0.19.8.1/debian/patches/04-enable-jdk9-compatibility.patch gettext-0.19.8.1/debian/patches/04-enable-jdk9-compatibility.patch
--- gettext-0.19.8.1/debian/patches/04-enable-jdk9-compatibility.patch	1970-01-01 01:00:00.0 +0100
+++ gettext-0.19.8.1/debian/patches/04-enable-jdk9-compatibility.patch	2018-03-20 19:47:19.0 +0100
@@ -0,0 +1,235 @@
+Description: Enable compatibility with JDK 9+
+ According to JEP-182 OpenJDK 9 will only support 1.6 or later for source and
+ target flags. This patch adds supports for 1.6, 1.7, and 1.8 flags for
+ detecting and building gettext java.
+ Modified from opensuse to include support for 1.7 and 1.8.
+Origin: opensuse, https://build.opensuse.org/package/view_file/openSUSE:Factory/gettext-runtime/gettext-0.19.8.1-jdk9.patch
+Bug-Debian: 
+Forwarded: no
+Last-Update: 2018-03-21
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+Index: gettext-0.19.8.1/gettext-runtime/configure.ac
+===
+--- gettext-0.19.8.1.orig/gettext-runtime/configure.ac
 gettext-0.19.8.1/gettext-runtime/configure.ac
+@@ -35,7 +35,7 @@ AC_PROG_YACC
+ 
+ gt_JAVA_CHOICE
+ 
+-gt_JAVACOMP([1.3], [1.1])
++gt_JAVACOMP([1.6], [1.6])
+ AC_CHECK_PROG([JAR], [jar], [jar])
+ if test -n "$HAVE_JAVACOMP" && test -n "$JAR" && test "$JAVA_CHOICE" != no; then
+   BUILDJAVA=yes
+Index: gettext-0.19.8.1/gettext-runtime/gnulib-m4/javacomp.m4
+===
+--- gettext-0.19.8.1.orig/gettext-runtime/gnulib-m4/javacomp.m4
 gettext-0.19.8.1/gettext-runtime/gnulib-m4/javacomp.m4
+@@ -16,6 +16,8 @@ dnl with or without modifications, as lo
+ #   1.4 assert keyword
+ #   1.5 generic classes and methods
+ #   1.6 (not yet supported)
++#   1.7 (not yet supported)
++#   1.8 (not yet supported)
+ #
+ # target-version can be:  classfile version:
+ #   1.1 45.3
+@@ -24,6 +26,8 @@ dnl with or without modifications, as lo
+ #   1.4 48.0
+ #   1.5 49.0
+ #   1.6 50.0
++#   1.7 51.0
++#   1.8 52.0
+ # The classfile version of a .class file can be determined through the "file"
+ # command. More portably, the classfile major version can be determined through
+ # "od -A n -t d1 -j 7 -N 1 classfile".
+@@ -36,6 +40,8 @@ dnl with or without modifications, as lo
+ #   1.4 JDK/JRE 1.4, gij 4.0, 4.1
+ #   1.5 JDK/JRE 1.5
+ #   1.6 JDK/JRE 1.6
++#   1.7 JDK/JRE 7
++#   1.8 JDK/JRE 8
+ # Note: gij >= 3.3 can in some cases handle classes compiled with -target 1.4,
+ # and gij >= 4.1 can in some cases partially handle classes compiled with
+ # -target 1.5, but I have no idea how complete this support is.
+@@ -47,7 +53,9 @@ dnl with or without modifications, as lo
+ # It is unreasonable to ask for:
+ #   -

Bug#893739: gettext: FTBFS with openjdk-9 as default-jdk

2018-03-21 Thread Tiago Stürmer Daitx 
Package: gettext
Version: 0.19.8-2
Severity: important

Dear Maintainer,

*** Reporter, please consider answering these questions, where appropriate ***

   * What led up to the situation?
   * What exactly did you do (or not do) that was effective (or
 ineffective)?
   * What was the outcome of this action?
   * What outcome did you expect instead?

*** End of the template - remove these template lines ***

Content-Type: multipart/mixed; boundary="===3187527196013602937=="
MIME-Version: 1.0
From: =?utf-8?q?Tiago_St=C3=BCrmer_Daitx?= 
To: Debian Bug Tracking System 
Subject: gettext: FTBFS with openjdk 9 as default-jdk
Message-ID: <152167117225.13763.14111882470295268469.reportbug@tdaitx-P65>
X-Mailer: reportbug 7.1.8ubuntu1
Date: Wed, 21 Mar 2018 23:26:12 +0100
X-Debbugs-Cc: tiago.da...@canonical.com

This is a multi-part MIME message sent by reportbug.


--===3187527196013602937==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: gettext
Version: 0.19.8-2
Severity: important

Dear Maintainer,

Currently gettext FTBFS when building with openjdk-9 due to:

cp: cannot stat 'debian/tmp/usr/share/gettext/libintl.jar': No such file or 
directory

which in turn is caused by a configure failing to detect openjdk:

checking for Java virtual machine... java
configure: WARNING: unknown target-version 9, please update gt_JAVACOMP macro
checking for Java compiler... no


For comparison, the above message, when compiling with OpenJDK 8 is:
checking for Java virtual machine... java
configure: WARNING: unknown target-version 1.8, please update gt_JAVACOMP macro
checking for Java compiler... /usr/lib/jvm/default-java/bin/javac -target 1.1 
-source 1.3


The attached debdiff, copied from opensuse and modified to include
support for source/target 1.7 and 1.8, fixes this issue.

The configure message, with the patch applied, is:
checking for Java virtual machine... java
configure: WARNING: unknown target-version 9, please update gt_JAVACOMP macro
checking for Java compiler... no


Please consider applying it to enable the work for transitioning
default-jdk from openjdk-8 to openjdk-9.

thanks
Tiago Daitx

-- System Information:
Debian Release: buster/sid
  APT prefers bionic
  APT policy: (500, 'bionic'), (400, 'bionic-proposed')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.15.0-10-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8), LANGUAGE=en_US 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

--===3187527196013602937==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: attachment; 
filename="gettext_0.19.8-1_debdiff_0.19.8-2.patch"

ZGlmZiAtTnJ1IGdldHRleHQtMC4xOS44LjEvZGViaWFuL2NoYW5nZWxvZyBnZXR0ZXh0LTAuMTku
OC4xL2RlYmlhbi9jaGFuZ2Vsb2cKLS0tIGdldHRleHQtMC4xOS44LjEvZGViaWFuL2NoYW5nZWxv
ZwkyMDE4LTAzLTA0IDA5OjI0OjA1LjAwMDAwMDAwMCArMDEwMAorKysgZ2V0dGV4dC0wLjE5Ljgu
MS9kZWJpYW4vY2hhbmdlbG9nCTIwMTgtMDMtMjAgMTk6NDc6MTkuMDAwMDAwMDAwICswMTAwCkBA
IC0xLDMgKzEsMTAgQEAKK2dldHRleHQgKDAuMTkuOC4xLTR1YnVudHU1fjAyKSBVTlJFTEVBU0VE
OyB1cmdlbmN5PW1lZGl1bQorCisgICogZC9wLzA0LWVuYWJsZS1qZGs5LWNvbXBhdGliaWxpdHku
cGF0Y2g6IGVuYWJsZSBidWlsZGluZyB3aXRoCisgICAgc291cmNlIGFuZCB0YXJnZXQgZmxhZ3Mg
c2V0IHRvIDEuODsgdXBkYXRlIGd0X0pBVkFDT01QIG1hY3JvLgorCisgLS0gVGlhZ28gU3TDvHJt
ZXIgRGFpdHggPHRpYWdvLmRhaXR4QHVidW50dS5jb20+ICBUdWUsIDIwIE1hciAyMDE4IDE4OjQ3
OjE5ICswMDAwCisKZ2V0dGV4dCAoMC4xOS44LjEtNCkgdW5zdGFibGU7IHVyZ2VuY3k9bWVkaXVt
CgogICogQXZvaWQgZXh0cmFuZW91cyBOVUwgYnl0ZXMgaW4gLm1vIGZpbGVzLiBDbG9zZXM6ICM4
NzI4NjkuCmRpZmYgLU5ydSBnZXR0ZXh0LTAuMTkuOC4xL2RlYmlhbi9wYXRjaGVzLzA0LWVuYWJs
ZS1qZGs5LWNvbXBhdGliaWxpdHkucGF0Y2ggZ2V0dGV4dC0wLjE5LjguMS9kZWJpYW4vcGF0Y2hl
cy8wNC1lbmFibGUtamRrOS1jb21wYXRpYmlsaXR5LnBhdGNoCi0tLSBnZXR0ZXh0LTAuMTkuOC4x
L2RlYmlhbi9wYXRjaGVzLzA0LWVuYWJsZS1qZGs5LWNvbXBhdGliaWxpdHkucGF0Y2gJMTk3MC0w
MS0wMSAwMTowMDowMC4wMDAwMDAwMDAgKzAxMDAKKysrIGdldHRleHQtMC4xOS44LjEvZGViaWFu
L3BhdGNoZXMvMDQtZW5hYmxlLWpkazktY29tcGF0aWJpbGl0eS5wYXRjaAkyMDE4LTAzLTIwIDE5
OjQ3OjE5LjAwMDAwMDAwMCArMDEwMApAQCAtMCwwICsxLDIzNSBAQAorRGVzY3JpcHRpb246IEVu
YWJsZSBjb21wYXRpYmlsaXR5IHdpdGggSkRLIDkrCisgQWNjb3JkaW5nIHRvIEpFUC0xODIgT3Bl
bkpESyA5IHdpbGwgb25seSBzdXBwb3J0IDEuNiBvciBsYXRlciBmb3Igc291cmNlIGFuZAorIHRh
cmdldCBmbGFncy4gVGhpcyBwYXRjaCBhZGRzIHN1cHBvcnRzIGZvciAxLjYsIDEuNywgYW5kIDEu
OCBmbGFncyBmb3IKKyBkZXRlY3RpbmcgYW5kIGJ1aWxkaW5nIGdldHRleHQgamF2YS4KKyBNb2Rp
ZmllZCBmcm9tIG9wZW5zdXNlIHRvIGluY2x1ZGUgc3VwcG9ydCBmb3IgMS43IGFuZCAxLjguCitP
cmlnaW46IG9wZW5zdXNlLCBodHRwczovL2J1aWxkLm9wZW5zdXNlLm9yZy9wYWNrYWdlL3ZpZXdf
ZmlsZS9vcGVuU1VTRTpGYWN0b3J5L2dldHRleHQtcnVudGltZS9nZXR0ZXh0LTAuMTkuOC4xLWpk
azkucGF0Y2gKK0J1Zy1EZWJpYW46IAorRm9yd2FyZGVkOiBubworTGFzdC1VcGRhdGU6IDIwMTgt