Bug#895995: mate-themes: High contrast themes show transparent zones instead of black when rendered with metacity
Hello, A complement is needed on this fix, see PR https://github.com/mate-desktop/mate-themes/pull/217 and attached patch. Samuel --- a/marco-themes/HighContrast/metacity-theme-1.xml +++ b/marco-themes/HighContrast/metacity-theme-1.xml @@ -284,13 +284,13 @@ - + - + --- a/desktop-themes/ContrastHighInverse/metacity-1/metacity-theme-1.xml +++ b/desktop-themes/ContrastHighInverse/metacity-1/metacity-theme-1.xml @@ -279,13 +279,13 @@ - + - +
Bug#895995: mate-themes: High contrast themes show transparent zones instead of black when rendered with metacity
Hi On Do 19 Apr 2018 23:43:06 CEST, Samuel Thibault wrote: Samuel Thibault, le jeu. 19 avril 2018 23:39:04 +0200, a ecrit: Mike Gabriel, le jeu. 19 avril 2018 21:37:03 +, a ecrit: > Do you think you can rebase your patch against 3.22.11 (for the stretch-pu) > and against 3.22.16? Another option would be to wait for 3.22.17/.18 for > unstable, but then we still need the rebased patch for the s-pu. > > Any chance you can work on that? Sure. I believe it's really just a matter of renaming only. Yes, the attached just-renamed patch works fine on 3.22.11 and 3.22.16. Samuel You patch has been uploaded as -3 revision of 3.22.16. Upstream approved it on IRC. Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de pgpkkHgZQp642.pgp Description: Digitale PGP-Signatur
Bug#895995: mate-themes: High contrast themes show transparent zones instead of black when rendered with metacity
Samuel Thibault, le jeu. 19 avril 2018 23:39:04 +0200, a ecrit: > Mike Gabriel, le jeu. 19 avril 2018 21:37:03 +, a ecrit: > > Do you think you can rebase your patch against 3.22.11 (for the stretch-pu) > > and against 3.22.16? Another option would be to wait for 3.22.17/.18 for > > unstable, but then we still need the rebased patch for the s-pu. > > > > Any chance you can work on that? > > Sure. I believe it's really just a matter of renaming only. Yes, the attached just-renamed patch works fine on 3.22.11 and 3.22.16. Samuel commit 4438dd67f526d4a9c915235d7426de985cec9da3 Author: Samuel Thibault Date: Wed Apr 18 13:54:11 2018 +0200 Fix HighContrast themes visibility with metacity When rendered with metacity (e.g. with metacity-theme-viewer), the back background parts of HighContrast and HighContrastInverse actually show up transparent. This is because the corresponding rectangles were missing the filled attribute. In the HighContrast case, the gtk_arrow is getting drawn black on black (and there is currently no way to change the color), so we can as well draw it by hand to be able to change the color. The close button also deserves bigger width to be more visible. Fixes #211 diff --git a/desktop-themes/ContrastHighInverse/metacity-1/metacity-theme-1.xml b/desktop-themes/ContrastHighInverse/metacity-1/metacity-theme-1.xml index 9129356a..d2fd4c33 100644 --- a/desktop-themes/ContrastHighInverse/metacity-1/metacity-theme-1.xml +++ b/desktop-themes/ContrastHighInverse/metacity-1/metacity-theme-1.xml @@ -135,11 +135,11 @@ +width="3"/> + width="3"/> @@ -147,7 +147,9 @@ - + diff --git a/marco-themes/HighContrast/metacity-theme-1.xml b/marco-themes/HighContrast/metacity-theme-1.xml index 06c7e3cd..d6135f47 100644 --- a/marco-themes/HighContrast/metacity-theme-1.xml +++ b/marco-themes/HighContrast/metacity-theme-1.xml @@ -72,11 +72,18 @@ - + + @@ -135,11 +142,11 @@ +width="3"/> + width="3"/> @@ -147,7 +154,7 @@ -
Bug#895995: mate-themes: High contrast themes show transparent zones instead of black when rendered with metacity
Mike Gabriel, le jeu. 19 avril 2018 21:37:03 +, a ecrit: > On Do 19 Apr 2018 19:37:01 CEST, Samuel Thibault wrote: > > > Here is the patch that upstream likes. > > > > Samuel > > your patch is based on some newer HEAD of mate-themes, one that has renamed > the ContrastHighInverse folder to HighContrastInverse. It scarcely applies. Ah, right, eww, already had to do that several times. > Do you think you can rebase your patch against 3.22.11 (for the stretch-pu) > and against 3.22.16? Another option would be to wait for 3.22.17/.18 for > unstable, but then we still need the rebased patch for the s-pu. > > Any chance you can work on that? Sure. I believe it's really just a matter of renaming only. Samuel
Bug#895995: mate-themes: High contrast themes show transparent zones instead of black when rendered with metacity
HI Samuel, On Do 19 Apr 2018 19:37:01 CEST, Samuel Thibault wrote: Here is the patch that upstream likes. Samuel your patch is based on some newer HEAD of mate-themes, one that has renamed the ContrastHighInverse folder to HighContrastInverse. It scarcely applies. Do you think you can rebase your patch against 3.22.11 (for the stretch-pu) and against 3.22.16? Another option would be to wait for 3.22.17/.18 for unstable, but then we still need the rebased patch for the s-pu. Any chance you can work on that? Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de pgpn8PJuuofdq.pgp Description: Digitale PGP-Signatur
Bug#895995: mate-themes: High contrast themes show transparent zones instead of black when rendered with metacity
On Do 19 Apr 2018 21:33:40 CEST, Samuel Thibault wrote: Mike Gabriel, le jeu. 19 avril 2018 18:53:12 +, a ecrit: On Do 19 Apr 2018 19:37:01 CEST, Samuel Thibault wrote: Do I get you right, that this issue is also a problem in Debian stretch? It is, yes, and it'd be very useful to spu the patch once settled in testing etc. Yep. Understood. Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de pgpwETCoR115y.pgp Description: Digitale PGP-Signatur
Bug#895995: mate-themes: High contrast themes show transparent zones instead of black when rendered with metacity
Mike Gabriel, le jeu. 19 avril 2018 18:53:12 +, a ecrit: > On Do 19 Apr 2018 19:37:01 CEST, Samuel Thibault wrote: > > > Here is the patch that upstream likes. > > > > Samuel > > I am currently waiting for mate-themes upstream to look into your patch(set). Sure! > Do I get you right, that this issue is also a problem in Debian stretch? It is, yes, and it'd be very useful to spu the patch once settled in testing etc. Samuel
Bug#895995: mate-themes: High contrast themes show transparent zones instead of black when rendered with metacity
Hi Samuel, On Do 19 Apr 2018 19:37:01 CEST, Samuel Thibault wrote: Here is the patch that upstream likes. Samuel I am currently waiting for mate-themes upstream to look into your patch(set). Do I get you right, that this issue is also a problem in Debian stretch? Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de pgplph0gBDYkE.pgp Description: Digitale PGP-Signatur
Bug#895995: mate-themes: High contrast themes show transparent zones instead of black when rendered with metacity
Here is the patch that upstream likes. Samuel commit 4438dd67f526d4a9c915235d7426de985cec9da3 Author: Samuel Thibault Date: Wed Apr 18 13:54:11 2018 +0200 Fix HighContrast themes visibility with metacity When rendered with metacity (e.g. with metacity-theme-viewer), the back background parts of HighContrast and HighContrastInverse actually show up transparent. This is because the corresponding rectangles were missing the filled attribute. In the HighContrast case, the gtk_arrow is getting drawn black on black (and there is currently no way to change the color), so we can as well draw it by hand to be able to change the color. The close button also deserves bigger width to be more visible. Fixes #211 diff --git a/desktop-themes/HighContrastInverse/metacity-1/metacity-theme-1.xml b/desktop-themes/HighContrastInverse/metacity-1/metacity-theme-1.xml index 9129356a..d2fd4c33 100644 --- a/desktop-themes/HighContrastInverse/metacity-1/metacity-theme-1.xml +++ b/desktop-themes/HighContrastInverse/metacity-1/metacity-theme-1.xml @@ -135,11 +135,11 @@ +width="3"/> + width="3"/> @@ -147,7 +147,9 @@ - + diff --git a/marco-themes/HighContrast/metacity-theme-1.xml b/marco-themes/HighContrast/metacity-theme-1.xml index 06c7e3cd..d6135f47 100644 --- a/marco-themes/HighContrast/metacity-theme-1.xml +++ b/marco-themes/HighContrast/metacity-theme-1.xml @@ -72,11 +72,18 @@ - + + @@ -135,11 +142,11 @@ +width="3"/> + width="3"/> @@ -147,7 +154,7 @@ -
Bug#895995: mate-themes: High contrast themes show transparent zones instead of black when rendered with metacity
Package: mate-themes Version: 3.22.11-1 Severity: important Tags: upstream patch Forwarded: https://github.com/mate-desktop/mate-themes/issues/211 Hello, As reported upstream, the background of decoration buttons of high contrast themes show up transparent instead of black, making them unreadable and thus unusable. That can be seen in metacity-theme-viewer by selecting the Metacity themes and then a high contrast theme (both have the issue), as the attached snapshot shows. The attached patch, submitted upstream, fixes them. Samuel -- System Information: Debian Release: buster/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'stable-debug'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.16.0 (SMP w/4 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages mate-themes depends on: ii gtk2-engines 1:2.20.2-5 ii gtk2-engines-murrine 0.98.2-2 ii gtk2-engines-pixbuf 2.24.32-1 ii librsvg2-common 2.40.20-2 ii mate-icon-theme 1.20.0-1 Versions of packages mate-themes recommends: ii dmz-cursor-theme 0.4.5 mate-themes suggests no packages. -- no debconf information -- Samuel bien sûr que ça convient mieux à tout le monde enfin, dans la mesure où tout le monde c'est comme moi -+- le consensus, c'est facile -+- Index: mate-themes-3.22.11/desktop-themes/ContrastHighInverse/metacity-1/metacity-theme-1.xml === --- mate-themes-3.22.11.orig/desktop-themes/ContrastHighInverse/metacity-1/metacity-theme-1.xml +++ mate-themes-3.22.11/desktop-themes/ContrastHighInverse/metacity-1/metacity-theme-1.xml @@ -147,7 +147,7 @@ - Index: mate-themes-3.22.11/marco-themes/HighContrast/metacity-theme-1.xml === --- mate-themes-3.22.11.orig/marco-themes/HighContrast/metacity-theme-1.xml +++ mate-themes-3.22.11/marco-themes/HighContrast/metacity-theme-1.xml @@ -57,6 +57,7 @@ + @@ -72,6 +73,9 @@ + -
