Bug#899144: [oxygen-icon-theme] Please include scalable version

2018-05-20 Thread Bastien ROUCARIES
On Sun, May 20, 2018 at 12:03 AM, Pino Toscano  wrote:
> In data sabato 19 maggio 2018 22:41:16 CEST, Bastien ROUCARIES ha scritto:
>> On Sat, May 19, 2018 at 9:55 PM, Pino Toscano  wrote:
>> > tag 899144 + moreinfo
>> > thanks
>> >
>> > In data sabato 19 maggio 2018 21:42:15 CEST, Bastien ROUCARIÈS ha scritto:
>> >> Some package packages scalable version (svg) of this theme. Could be 
>> >> possible
>> >> to get scalable version here in order to create symbolic link and reduce 
>> >> code
>> >> duplication
>> >
>> > You generally should not rely on a specific icon theme, so what exactly
>> > needs such symlinks, and why?
>>
>> A js package use it (mocha). For now I use 22x22 png but it is ugly I
>> will prefer to use the svg one. Oxygen is also used by a few other js
>> package.
>
> This still does not tell me what exactly mocha and the other js packages
> are doing with oxygen icons. Please explain in detail what is the actual
> situation, otherwise it is hard for us to implement a solution (and
> maintain it) for a problem we have no idea about.

It will create a web page with some images taken from this theme. Pass
icons is ok-apply for example.

In need scalable in order to reduce "code" duplication in hte archive

Bastien

> --
> Pino Toscano



Bug#899144: [oxygen-icon-theme] Please include scalable version

2018-05-20 Thread Maximiliano Curia

¡Hola Bastien!

El 2018-05-19 a las 21:42 +0200, Bastien ROUCARIÈS escribió:

Package: oxygen-icon-theme
Version: 5:5.45.0-1
Severity: important
control: tags -1 + patch



Hi,



Some package packages scalable version (svg) of this theme. Could be possible
to get scalable version here in order to create symbolic link and reduce code
duplication



Here patch untested by could help


Can you please send the patch upstream? Currently upstream processes the 
patches through the phabricator.kde.org (the documentation on how to use it 
can be found: https://community.kde.org/Infrastructure/Phabricator)


Please consider adding a rationale on why are the svg and svgz useful for you 
in the installed paths (as requested by Pino).


Happy hacking,
--
"Nothing ever goes away." -- Commoner's Law of Ecology
Saludos /\/\ /\ >< `/


signature.asc
Description: PGP signature


Bug#899144: [oxygen-icon-theme] Please include scalable version

2018-05-19 Thread Pino Toscano
In data sabato 19 maggio 2018 22:41:16 CEST, Bastien ROUCARIES ha scritto:
> On Sat, May 19, 2018 at 9:55 PM, Pino Toscano  wrote:
> > tag 899144 + moreinfo
> > thanks
> >
> > In data sabato 19 maggio 2018 21:42:15 CEST, Bastien ROUCARIÈS ha scritto:
> >> Some package packages scalable version (svg) of this theme. Could be 
> >> possible
> >> to get scalable version here in order to create symbolic link and reduce 
> >> code
> >> duplication
> >
> > You generally should not rely on a specific icon theme, so what exactly
> > needs such symlinks, and why?
> 
> A js package use it (mocha). For now I use 22x22 png but it is ugly I
> will prefer to use the svg one. Oxygen is also used by a few other js
> package.

This still does not tell me what exactly mocha and the other js packages
are doing with oxygen icons. Please explain in detail what is the actual
situation, otherwise it is hard for us to implement a solution (and
maintain it) for a problem we have no idea about.

-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.


Bug#899144: [oxygen-icon-theme] Please include scalable version

2018-05-19 Thread Bastien ROUCARIES
On Sat, May 19, 2018 at 9:55 PM, Pino Toscano  wrote:
> tag 899144 + moreinfo
> thanks
>
> In data sabato 19 maggio 2018 21:42:15 CEST, Bastien ROUCARIÈS ha scritto:
>> Some package packages scalable version (svg) of this theme. Could be possible
>> to get scalable version here in order to create symbolic link and reduce code
>> duplication
>
> You generally should not rely on a specific icon theme, so what exactly
> needs such symlinks, and why?

A js package use it (mocha). For now I use 22x22 png but it is ugly I
will prefer to use the svg one. Oxygen is also used by a few other js
package.

Bastien
>
> --
> Pino Toscano



Bug#899144: [oxygen-icon-theme] Please include scalable version

2018-05-19 Thread Pino Toscano
tag 899144 + moreinfo
thanks

In data sabato 19 maggio 2018 21:42:15 CEST, Bastien ROUCARIÈS ha scritto:
> Some package packages scalable version (svg) of this theme. Could be possible 
> to get scalable version here in order to create symbolic link and reduce code 
> duplication

You generally should not rely on a specific icon theme, so what exactly
needs such symlinks, and why?

-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.


Bug#899144: [oxygen-icon-theme] Please include scalable version

2018-05-19 Thread Bastien ROUCARIÈS
Package: oxygen-icon-theme
Version: 5:5.45.0-1
Severity: important
control: tags -1 + patch

Hi,

Some package packages scalable version (svg) of this theme. Could be possible 
to get scalable version here in order to create symbolic link and reduce code 
duplication

Here patch untested by could helpIndex: oxygen-icons5-5.46.0/CMakeLists.txt
===
--- oxygen-icons5-5.46.0.orig/CMakeLists.txt
+++ oxygen-icons5-5.46.0/CMakeLists.txt
@@ -18,7 +18,7 @@ include(KDECompilerSettings NO_POLICY_SC
 # Dependencies
 set(REQUIRED_QT_VERSION 5.8.0)
 
-set( oxygen_icon_dirs  8x8 16x16 22x22 32x32 48x48 64x64 128x128 256x256 )
+set( oxygen_icon_dirs  8x8 16x16 22x22 32x32 48x48 64x64 128x128 256x256 scalable)
 
 add_subdirectory(autotests)
 


signature.asc
Description: This is a digitally signed message part.