Bug#900740: pcal failed to cross build at compile
On Mon, Jun 04, 2018 at 10:49:00AM +0700, vinh.nguyenc...@toshiba-tsdv.com wrote: > Attached file is the patch for this. The patch looks quite complex and subtly wrong to me: * It uses DEB_BUILD_GNU_TYPE without initializing it. * It uses OS without initializing it. * When a user sets CC, it gets overwritten. This is much easier solved with dh_auto_build, which doesn't use uninitialized variables and honours a CC environment variable. Helmut diff --minimal -Nru pcal-4.11.0/debian/changelog pcal-4.11.0/debian/changelog --- pcal-4.11.0/debian/changelog2012-05-09 22:32:10.0 +0200 +++ pcal-4.11.0/debian/changelog2018-12-15 00:39:01.0 +0100 @@ -1,3 +1,10 @@ +pcal (4.11.0-3.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * Fix FTCBFS: Let dh_auto_build pass cross tools to make. (Closes: #-1) + + -- Helmut Grohne Sat, 15 Dec 2018 00:39:01 +0100 + pcal (4.11.0-3) unstable; urgency=low * lintian fixes diff --minimal -Nru pcal-4.11.0/debian/rules pcal-4.11.0/debian/rules --- pcal-4.11.0/debian/rules2012-04-11 21:39:35.0 +0200 +++ pcal-4.11.0/debian/rules2018-12-15 00:38:55.0 +0100 @@ -15,7 +15,7 @@ build-stamp: dh_testdir - $(MAKE) CFLAGS="-O2 -Wall -DEPS" + dh_auto_build -- CFLAGS="-O2 -Wall -DEPS" touch build-stamp
Bug#900740: pcal failed to cross build at compile
Package: src: pcal Version: 0.4.3-8.1 Severity: normal Tags: patch Hi, I attempted to cross-build pcal , and it failed with dpkg-buildpackage as follows: CONFIG_SITE=/etc/dpkg-cross/cross-config.armhf DEB_BUILD_OPTIONS=nocheck dpkg-buildpackage -aarmhf [...] /usr/bin/gcc -O2 -Wall -DEPS -DEPS_DSC '-DSEARCH_PCAL_DIR=0' -DBUILD_ENV_UNIX -o obj/readfile.o -c src/readfile.c /usr/bin/gcc -O2 -Wall -DEPS -DEPS_DSC '-DSEARCH_PCAL_DIR=0' -DBUILD_ENV_UNIX -o obj/writefil.o -c src/writefil.c /usr/bin/gcc -o exec/pcal obj/pcal.o obj/encvec.o obj/exprpars.o obj/moonphas.o obj/pcalutil.o obj/pcallang.o obj/readfile.o obj/writefil.o -lm -lpaper /usr/bin/ld: cannot find -lpaper collect2: error: ld returned 1 exit status [...] By default, "CC" is "gcc". It would be good if it uses right "CC" variable. Attached file is the patch for this. Thanks, Vinh. -- System Information: Architecture: amd64 (x86_64) Foreign Architectures: armhf Kernel: Linux 3.16.0-4-amd64 (SMP w/16 CPU cores) Shell: /bin/sh linked to /bin/bash pcal_crossbuild.diff Description: Binary data -- This mail was scanned by BitDefender For more information please visit http://www.bitdefender.com