Bug#901114: python-coverage: FTBFS when built with dpkg-buildpackage -A

2018-06-09 Thread Ben Finney
Control: tags -1 + confirmed

On 09-Jun-2018, Santiago Vila wrote:

> I'm using "sbuild --arch-all --no-arch-any" on a clean chroot, which
> is what an official autobuilder would do to build the arch-indep
> packages.

Yes, thanks. That allows me to reproduce the behaviour.

> My feeling is that you are assuming some packages to be present when
> in fact they do not necessarily have to be present according to
> debian/control when building only the arch-independent packages.

Okay, I'll check into that.

-- 
 \   “Why, I'd horse-whip you if I had a horse.” —Groucho Marx |
  `\   |
_o__)  |
Ben Finney 


signature.asc
Description: PGP signature


Bug#901114: python-coverage: FTBFS when built with dpkg-buildpackage -A

2018-06-08 Thread Santiago Vila
On Sat, Jun 09, 2018 at 10:26:05AM +1000, Ben Finney wrote:

> The package currently has (discovered when investigating this
> behaviour, so thank you) a bug in its definition of the ‘debian/rules’
> target ‘override_dh_auto_build’.
> 
> I'm unsure about Debhelper failing to find the sequence for ‘python2’.
> That should already be pulled in when you install the build
> dependencies. Maybe this is complicated by the
> ‘override_dh_auto_build’ bug.
> 
> I am adding this change, please let me know whether it corrects the
> package behaviour for you:

Sorry, I can't test external packages easily in my setup.

Instead, I'll be more precise so that you can reproduce this too:

I'm using "sbuild --arch-all --no-arch-any" on a clean chroot,
which is what an official autobuilder would do to build the arch-indep
packages.

By looking at the debian/control file, this seems to be a bad interaction
between Build-Depends / Build-Depends-Indep / Build-Depends-Arch.

My feeling is that you are assuming some packages to be present
when in fact they do not necessarily have to be present according to
debian/control when building only the arch-independent packages.

(And this would be why debhelper does not "find" the python2 thing).

Hope this helps.



Bug#901114: python-coverage: FTBFS when built with dpkg-buildpackage -A

2018-06-08 Thread Ben Finney
Control: tags -1 + patch moreinfo

On 08-Jun-2018, Santiago Vila wrote:

>  dpkg-source --before-build python-coverage-4.5+dfsg.1
>  fakeroot debian/rules clean
> debian/rules:166: warning: overriding recipe for target 
> 'override_dh_auto_build'
> debian/rules:129: warning: ignoring old recipe for target 
> 'override_dh_auto_build'
> dh clean --with python3,python2,pypy,sphinxdoc --buildsystem=pybuild
> dh: unable to load addon python2: Can't locate 
> Debian/Debhelper/Sequence/python2.pm in @INC (you may need to install the 
> Debian::Debhelper::Sequence::python2 module) (@INC contains: /etc/perl 
> /usr/local/lib/x86_64-linux-gnu/perl/5.26.2 /usr/local/share/perl/5.26.2 
> /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 
> /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 
> /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at (eval 10) 
> line 1.
> BEGIN failed--compilation aborted at (eval 10) line 1.

The package currently has (discovered when investigating this
behaviour, so thank you) a bug in its definition of the ‘debian/rules’
target ‘override_dh_auto_build’.

I'm unsure about Debhelper failing to find the sequence for ‘python2’.
That should already be pulled in when you install the build
dependencies. Maybe this is complicated by the
‘override_dh_auto_build’ bug.

I am adding this change, please let me know whether it corrects the
package behaviour for you:


diff --git a/debian/rules b/debian/rules
index cd4633de..8f9a88f1 100755
--- a/debian/rules
+++ b/debian/rules
@@ -127,6 +127,8 @@ endef # uscan-download-source
 override_dh_auto_build: remove-bundled-libraries
 override_dh_auto_build:
dh_auto_build --buildsystem=pybuild
+   $(SPHINX) ${SPHINX_OPTS} -bhtml ${DOCUMENTATION_DIR}/ \
+ ${DOCUMENTATION_BUILD_HTML_DIR}/
 
 # Upstream test suite doesn't currently run in our build environment.
 override_dh_auto_test:
@@ -162,11 +164,6 @@ override_dh_auto_clean:
   dh_auto_clean
   $(RM) -r ${GENERATED_FILES}
 
-override_dh_auto_build:
-   dh_auto_build
-   $(SPHINX) ${SPHINX_OPTS} -bhtml ${DOCUMENTATION_DIR}/ \
- ${DOCUMENTATION_BUILD_HTML_DIR}/
-
 
 # Local variables:
 # mode: makefile

-- 
 \  “Begin with false premises and you risk reaching false |
  `\   conclusions. Begin with falsified premises and you forfeit your |
_o__)  authority.” —Kathryn Schulz, 2015-10-19 |
Ben Finney 


signature.asc
Description: PGP signature


Bug#901114: python-coverage: FTBFS when built with dpkg-buildpackage -A

2018-06-08 Thread Santiago Vila
Package: src:python-coverage
Version: 4.5+dfsg.1-3
Severity: serious

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
but it failed:


[...]
dpkg-buildpackage: info: source package python-coverage
dpkg-buildpackage: info: source version 4.5+dfsg.1-3
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Ben Finney 
 dpkg-source --before-build python-coverage-4.5+dfsg.1
 fakeroot debian/rules clean
debian/rules:166: warning: overriding recipe for target 'override_dh_auto_build'
debian/rules:129: warning: ignoring old recipe for target 
'override_dh_auto_build'
dh clean --with python3,python2,pypy,sphinxdoc --buildsystem=pybuild
dh: unable to load addon python2: Can't locate 
Debian/Debhelper/Sequence/python2.pm in @INC (you may need to install the 
Debian::Debhelper::Sequence::python2 module) (@INC contains: /etc/perl 
/usr/local/lib/x86_64-linux-gnu/perl/5.26.2 /usr/local/share/perl/5.26.2 
/usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 
/usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at (eval 10) line 
1.
BEGIN failed--compilation aborted at (eval 10) line 1.

debian/rules:74: recipe for target 'clean' failed
make: *** [clean] Error 2
dpkg-buildpackage: error: fakeroot debian/rules clean subprocess returned exit 
status 2


To reproduce, please try "dpkg-buildpackage -A".
(The error does not happen with "dpkg-buildpackage").

Thanks.