Bug#902183: cryptsetup-initramfs: "ERROR: Couldn't find sysfs hierarchy for /dev/sda1"

2018-06-23 Thread Guilhem Moulin
On Sat, 23 Jun 2018 at 20:41:34 +0100, Chris Lamb wrote:
>> Nope, removing 'cryptsetup-initramfs' was the right thing to do since
>> you don't need to unlock anything at initramfs stage.
> 
> Out of interest, assuming I *did* actually use cryptsetup (!) would it
> have resulted an unbootable system? :)

Depends, the cryptsetup binaries wouldn't have been included to the
initramfs image, but if the root device isn't encrypted then it's always
possible to setup a chroot manually and run the “real” cryptsetup
binary.  (Assuming ‘cryptsetup-bin’ is installed, of course.)  That
being said, it's a bit strange to have devices that need to be present
that early in the boot process (typically the resume device, or the
device holding /usr; OTOH /home doesn't need to be present that early)
when the root device itself isn't encrypted…

Also, on systems with encrypted devices that need to be unlocked at
initramfs stage, `update-initramfs -u` doesn't suggest to remove
‘cryptsetup-initramfs’.  But perhaps we should ship a prerm script
warning the user that removing the package was a terrible idea, and that
they should most likely reinstall it before trying to reboot :-)

-- 
Guilhem.


signature.asc
Description: PGP signature


Bug#902183: cryptsetup-initramfs: "ERROR: Couldn't find sysfs hierarchy for /dev/sda1"

2018-06-23 Thread Chris Lamb
Hi Guilhem,

> My commit from yesterday to make cryptsetup ≥2:2.0.3-2 work with d-i is
> also fixing this :-)
> 
> https://salsa.debian.org/cryptsetup-team/cryptsetup/commit/8ea400db2e146ee9e4a0f475f9353bf87201d1f3

Ah, neat!

> > Anything I should be concerned with?
> 
> Nope, removing 'cryptsetup-initramfs' was the right thing to do since
> you don't need to unlock anything at initramfs stage.

Out of interest, assuming I *did* actually use cryptsetup (!) would it
have resulted an unbootable system? :)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#902183: cryptsetup-initramfs: "ERROR: Couldn't find sysfs hierarchy for /dev/sda1"

2018-06-23 Thread Guilhem Moulin
Control: tag -1 pending
Control: retitle -1 cryptsetup-initramfs: "ERROR: Couldn't find sysfs hierarchy 
for "

Hi Chris,

On Sat, 23 Jun 2018 at 08:45:54 +0100, Chris Lamb wrote:
> cryptsetup: ERROR: Couldn't find sysfs hierarchy for /dev/sda1
> cryptsetup: ERROR: Couldn't find sysfs hierarchy for 
>   UUID=2efdbd50-bc29-4134-9519-5a007c41c12a

My commit from yesterday to make cryptsetup ≥2:2.0.3-2 work with d-i is
also fixing this :-)


https://salsa.debian.org/cryptsetup-team/cryptsetup/commit/8ea400db2e146ee9e4a0f475f9353bf87201d1f3

The problem is that while you have you have a sysfs(5) entry ‘block/sda’
corresponding to ‘/dev/sda’, there is no entry ‘block/sda1’
corresponding to its first partition.  It's not a problem for mapped
devices (dm) as there are entries ‘block/dm-$index’, so finding slaves
of an encrypted devices should always succeed and never spew this error.
According to our tests, at least :-).

My bad for not reading the docs carefully.  sysfs(5) mentions
‘/sys/dev/block/$maj:$min’ not ‘/sys/block/$blk’ as the reliable way to
access the sysfs directory corresponding to a device.  This is what the
hook is using now.

> So, I didn't look into the sysfs error at all — as I do not use
> cryptsetup on this machine, I thought I would just remove the
> cryptsetup-initramfs package and get on with my morning (NB. typo bug
> already filed in #901971!).
> […]
> Anything I should be concerned with?

Nope, removing 'cryptsetup-initramfs' was the right thing to do since
you don't need to unlock anything at initramfs stage.

Cheers,
-- 
Guilhem.


signature.asc
Description: PGP signature


Bug#902183: cryptsetup-initramfs: "ERROR: Couldn't find sysfs hierarchy for /dev/sda1"

2018-06-23 Thread Chris Lamb
retitle 902183 cryptsetup-initramfs:
thanks

Sorry, pressed "Send" too quickly...

Again,  I'm only really filing this just in case it affects people
actually using cryptsetup or similar — I want to avoid them rebooting
to a failing system. :)

Feel free to close if invalid; I am just being trigger-happy. :)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-