Bug#902197: mozjs52 FTBFS with icu 60.2

2018-07-03 Thread Simon McVittie
On Wed, 04 Jul 2018 at 00:14:25 +0100, Simon McVittie wrote:
> Having fixed that, I get a different FTBFS

This is https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902961



Bug#902197: mozjs52 FTBFS with icu 60.2

2018-07-03 Thread Simon McVittie
Control: tags -1 + patch

On Sat, 23 Jun 2018 at 16:33:40 +0100, Simon McVittie wrote:
> On Sat, 23 Jun 2018 at 12:52:01 +0300, Adrian Bunk wrote:
> > make[3]: *** No rule to make target 'ParagraphLayout.ao', needed by 
> > '../lib/libiculx.a'.  Stop.
> 
> It looks as though Ubuntu might have a fix for this
> ...
> +  * Don't build-depend on libicu-dev

This didn't work for me: even with a Build-Conflicts, I got the same
failure. However, a better solution seems to be to pass --disable-layoutex
to the bundled icu's configure script, as in the attached. That makes
some sense to me at least: the bundled icu's configure script has an
"automagic" dependency on the icu-le-hb layout engine library, which until
recently we didn't have. However, the bundled icu is incomplete/minimal
and doesn't actually have the source code for the optional paragraph
layout feature that requires icu-le-hb. We can resolve that by turning
the feature off, which isn't a regression because the versions of mozjs52
that compiled successfully didn't have it either.

Having fixed that, I get a different FTBFS: the mozjs command-line entry
point fails to start up. I'll open a separate bug to track that. I can
work around it, but I'm reasonably sure my workaround isn't the proper
solution.

smcv
From: Mike Hommey 
Date: Sat, 19 May 2018 11:23:18 +0900
Subject: Add --disable-layoutex when running ICU configure. r=froydnj,
 a=RyanVM

In some recent ICU update, --enable-layoutex changed from defaulting
to the "same-as-layout" to "yes", so --disable-layout doesn't imply
--disable-layoutex anymore, but we removed the layoutex files.

Applied-upstream: https://hg.mozilla.org/mozilla-unified/rev/31d4880fde31
---
 intl/icu_sources_data.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/intl/icu_sources_data.py b/intl/icu_sources_data.py
index 7d2d983..fc95d6a 100644
--- a/intl/icu_sources_data.py
+++ b/intl/icu_sources_data.py
@@ -122,6 +122,7 @@ def update_data_file(topsrcdir):
  '--disable-extras',
  '--disable-icuio',
  '--disable-layout',
+ '--disable-layoutex',
  '--disable-tests',
  '--disable-samples',
  '--disable-strict'],


Bug#902197: mozjs52 FTBFS with icu 60.2

2018-06-23 Thread Adrian Bunk
On Sat, Jun 23, 2018 at 04:33:40PM +0100, Simon McVittie wrote:
>...
> (It would be better to fix #878362 by using the system ICU, but I don't
> know how feasible that will be - last time I tried, mozjs52 failed
> to build.)

It wouldn't work long-time if mozjs52 follows upstream firefox-esr
in stable.

> smcv

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed



Bug#902197: mozjs52 FTBFS with icu 60.2

2018-06-23 Thread Simon McVittie
On Sat, 23 Jun 2018 at 12:52:01 +0300, Adrian Bunk wrote:
> make[3]: *** No rule to make target 'ParagraphLayout.ao', needed by 
> '../lib/libiculx.a'.  Stop.

It looks as though Ubuntu might have a fix for this, along with an update
to a newer mozjs52 that would probably also be beneficial for Debian:

+  * Update to 52.8.1esr
...
+  * Don't build-depend on libicu-dev - the bundled ICU is used and the
+distro ICU package ships the layout engine API since 60.2, which
+causes intl/icu_sources_data.py to fail due to source files excluded from
+the Mozilla source

(It would be better to fix #878362 by using the system ICU, but I don't
know how feasible that will be - last time I tried, mozjs52 failed
to build.)

smcv



Bug#902197: mozjs52 FTBFS with icu 60.2

2018-06-23 Thread Adrian Bunk
Source: mozjs52
Version: 52.3.1-7
Severity: serious
Tags: ftbfs

https://buildd.debian.org/status/package.php?p=mozjs52=sid

...
make[2]: Making `all' in `layoutex'
make[3]: Entering directory '/tmp/icu-obj-zx3uTY/layoutex'
make[3]: *** No rule to make target 'ParagraphLayout.ao', needed by 
'../lib/libiculx.a'.  Stop.
make[3]: Leaving directory '/tmp/icu-obj-zx3uTY/layoutex'
make[2]: *** [Makefile:147: all-recursive] Error 2
make[2]: Leaving directory '/tmp/icu-obj-zx3uTY'
Error running "make" in directory /tmp/icu-obj-zx3uTY
Error updating ICU data file
Updating ICU sources lists...
Running ICU configure...
Running ICU make...
make[1]: *** [debian/rules:71: override_dh_auto_configure] Error 1