Bug#902654: larry6: Add support for SVGA version
I've tried the game on different system (stretch + git g-d-p + buster scummvm & innoextract). There was some strange output in terminal: WARNING: SDL mixer output buffer size: 512 differs from desired: 1024! User picked target 'lsl6hires' (gameid 'lsl6hires')... Looking for a plugin supporting this gameid... SCI [SCI0, SCI01, SCI10, SCI11, SCI32] Starting 'Leisure Suit Larry 6: Shape Up or Slip Out!' ALSA lib seq_hw.c:466:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory ALSA lib seq_hw.c:466:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory ALSA lib seq_hw.c:466:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory ALSA lib seq_hw.c:466:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory ALSA lib seq_hw.c:466:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory ALSA lib seq_hw.c:466:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory ALSA lib seq_hw.c:466:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory ALSA lib seq_hw.c:466:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory ALSA lib seq_hw.c:466:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory ALSA lib seq_hw.c:466:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory But the game, menu entry & menu command work so i don't think it's a g-d-p's problem. I believe it was a strange glitch of buster that i can't reproduce.
Bug#902654: larry6: Add support for SVGA version
2018-07-03 11:29 UTC+02:00, Simon McVittie : > lsl6-cd apparently doesn't work in current ScummVM, though. I assume you > have access to a copy of LSL6 (VGA) since you added it in the first place. > Please could you investigate whether failing to start with ID lsl6-cd > is a transient ScummVM bug, or whether there is something better than > either lsl6-cd or sci that we can put in our .desktop file? Hi, I have both the original LSL6 and 7; but I'm not home at the moment. Alexandre
Bug#902654: larry6: Add support for SVGA version
On Tue, 03 Jul 2018 at 10:59:52 +0200, Alexandre Detiste wrote: > 2018-07-03 5:31 UTC+02:00, Рома Тенцер : > > --detect finds the engine name as gameid. And it works! > > > > sciLeisure Suit Larry 6: Shape Up or Slip Out! (CD/DOS/English) > > /usr/share/games/larry6 > > > >Starting 'Sierra SCI Game' > > > > Hi, "sci" is a fallback, please don't use this. > > Back then the "--detect" flag didn't exist; I had to look up every > codename with the GUI. lsl6-cd apparently doesn't work in current ScummVM, though. I assume you have access to a copy of LSL6 (VGA) since you added it in the first place. Please could you investigate whether failing to start with ID lsl6-cd is a transient ScummVM bug, or whether there is something better than either lsl6-cd or sci that we can put in our .desktop file? Thanks, smcv
Bug#902654: larry6: Add support for SVGA version
2018-07-03 5:31 UTC+02:00, Рома Тенцер : > > --detect finds the engine name as gameid. And it works! > > sciLeisure Suit Larry 6: Shape Up or Slip Out! (CD/DOS/English) > /usr/share/games/larry6 > >Starting 'Sierra SCI Game' > Hi, "sci" is a fallback, please don't use this. Back then the "--detect" flag didn't exist; I had to look up every codename with the GUI. I remember I comment a bit on the pull request to enventually make it usefull for GDP make-template, but forgot about the detaisl. Greetings,
Bug#902654: larry6: Add support for SVGA version
Does the SVGA version work when run with the command from the .desktop file? Yes, it works. lsl6-cd is the "gameid" from larry6.yaml. In the case of the VGA version, Alexandre filled in lsl6-cd when he first added support for this game; in the case of the SVGA version, I guessed lsl6hires. Yes, and scummvm's gui uses the same gameid. But it works only if the game was found by gui. --detect finds the engine name as gameid. And it works! $ scummvm -p /usr/share/games/larry6 --detect ID DescriptionFull Path -- -- - sciLeisure Suit Larry 6: Shape Up or Slip Out! (CD/DOS/English) /usr/share/games/larry6 $ scummvm -p /usr/share/games/larry6 sci User picked target 'sci' (gameid 'sci')... Looking for a plugin supporting this gameid... SCI [SCI0, SCI01, SCI10, SCI11, SCI32] Starting 'Sierra SCI Game' The game starts successfully. I think it's a scummvm's bug, but not sure if i going to report it.
Bug#902654: larry6: Add support for SVGA version
On Tue, 03 Jul 2018 at 01:25:04 +0700, Рома Тенцер wrote: > First. The command from a menu item for vga version doesn't works. I'm not > sure if it's a g-d-p problem — when i use scummvm's gui to find the game > manually it works fine and the command starts to work. > > $ scummvm -p /usr/share/games/larry6 lsl6-cd > scummvm: Unrecognized game target 'lsl6-cd' > Usage: scummvm [OPTIONS]... [GAME] > > Try 'scummvm --help' for more options. lsl6-cd is the "gameid" from larry6.yaml. In the case of the VGA version, Alexandre filled in lsl6-cd when he first added support for this game; in the case of the SVGA version, I guessed lsl6hires. Does the SVGA version work when run with the command from the .desktop file? If it does, them my guess was correct. Can you find a scummvm command-line option that does work as a replacement for lsl6-cd? It might help to use scummvm -p /usr/share/games/larry6 --detect scummvm -p /usr/share/games/larry6-svga --detect If I understand scummvm correctly, we want the "ID" column. I don't have any of the LSL games, but for instance, here's what I get for Loom: $ scummvm -p /usr/share/games/loom-en --detect ID DescriptionFull Path -- -- - loom Loom (VGA/DOS/English) /usr/share/games/loom-en > And second. A menu items for both versions have the same name. I don't think > it's good. I think that means we need a different "longname" directive in the YAML for one or both of them, to add a (VGA) or (SVGA) suffix (see larry1.yaml for an example of this). smcv
Bug#902654: larry6: Add support for SVGA version
Both versions works fine (thanks!) except for two issues. First. The command from a menu item for vga version doesn't works. I'm not sure if it's a g-d-p problem — when i use scummvm's gui to find the game manually it works fine and the command starts to work. $ scummvm -p /usr/share/games/larry6 lsl6-cd scummvm: Unrecognized game target 'lsl6-cd' Usage: scummvm [OPTIONS]... [GAME] Try 'scummvm --help' for more options. And second. A menu items for both versions have the same name. I don't think it's good. P.S. Your make-template output has 64 files in AUD/, all of which we package, and no HIRES/ or SFX/ directory; so I think GOG have done this already? GOG uses dosbox to run svga-version.
Bug#902654: larry6: Add support for SVGA version
On Sat, 30 Jun 2018 at 21:48:07 +0700, Рома Тенцер wrote: > Still doesn't work. Try with current git? Please try the VGA version too - I don't think I've broken it, but it's best to be sure. The description that g-d-p uses to package this game is in data/larry6.yaml. Run "make" after making any changes. smcv
Bug#902654: larry6: Add support for SVGA version
Still doesn't work.
ERROR:game_data_packager.build:gog_leisure_suit_larry_6_2.0.0.1.sh should have
provided resource.mtb but did not
ERROR:game_data_packager.build:gog_leisure_suit_larry_6_2.0.0.1.sh should have
provided resource.nol but did not
ERROR:game_data_packager.build:gog_leisure_suit_larry_6_2.0.0.1.sh should have
provided sfx/resource.sfx but did not
ERROR:game_data_packager.build:could not find
setup_leisure_suit_larry6_vga_2.2.0.18.exe:
expected:
size: 404934784 bytes
md5:373cc731980938602a79bd9220a56040
sha1: d0f08649e3f890550b62476f1c7ca39557f22745
sha256: None
ERROR:game_data_packager.build:could not find
setup_leisure_suit_larry6_vga_2.2.0.19.exe:
expected:
size: 407138320 bytes
md5:2acfe2b839162036710b6759e66da9ac
sha1: 53739296cee3bc44ccb489cfdbf5830eae9939b4
sha256: None
ERROR:game_data_packager.build:could not find
leisure_suit_larry_6_vga_en_gog_2_20240.sh:
expected:
size: 484022760 bytes
md5:d5e1973d126bc7750550729cbec4379f
sha1: f8fc30281f859d1793255c0dda5bc46f7877540b
sha256: a66e51f1293ecb57a149d6ba1c4ef3ff4c97209d6fb9fccae4d49cd4a4e92ae8
ERROR:game_data_packager.build:could not find resource.mtb:
expected:
size: 377 bytes
md5:cbbe51830655cd8abe8dc2cfdb3cb025
sha1: None
sha256: None
ERROR:game_data_packager.build:could not find resource.nol:
expected:
size: 384 bytes
md5:ff96016b21e92df672abe3ca57901fe2
sha1: None
sha256: None
ERROR:game_data_packager.build:could not find sfx/resource.sfx:
expected:
size: 7482184 bytes
md5:8d284d70d11327ec6f6acee8bd4ca0fb
sha1: 8a694e251d5f68e89cc78726f8bfc9836aaffbe2
sha256: None
ERROR:game_data_packager.build:Unable to complete any packages.
usage: game-data-packager larry6 [-h] [--verbose | --no-verbose] [--debug]
[--everything] [--package PACKAGE]
[--target-format {arch,deb,rpm}]
[--target-distro TARGET_DISTRO]
[--install-method METHOD]
[--gain-root-command METHOD]
[--binary-executables] [-i | -n] [-d OUTDIR]
[-z | --no-compress]
[--download | --no-download]
[--save-downloads DIR]
[--search | --no-search]
[DIRECTORY|FILE [DIRECTORY|FILE ...]]
Package data files for Leisure Suit Larry 6: Shape Up or Slip Out!.
positional arguments:
DIRECTORY|FILEFiles to use in constructing the .deb
optional arguments:
-h, --helpshow this help message and exit
--verbose show output from external tools
--no-verbose hide output from external tools (default)
--debug show debug messages
--everything Download all possible expansions
--package PACKAGE, -p PACKAGE
Produce this data package (may be repeated)
--target-format {arch,deb,rpm}
Produce packages for this packaging system
--target-distro TARGET_DISTRO
Produce packages suitable for this distro
--install-method METHOD
Use METHOD (apt, dpkg, gdebi, gdebi-gtk, gdebi-kde) to
install packages
--gain-root-command METHOD
Use METHOD (su, sudo, pkexec) to gain root if needed
--binary-executables allow installation of executable code that was not
built from public source code
-i, --install install the generated package
-n, --no-install do not install the generated package (requires -d,
default)
-d OUTDIR, --destination OUTDIR
write the generated .deb(s) to OUTDIR
-z, --compresscompress generated .deb (default if -d is used)
--no-compress do not compress generated .deb (default without -d)
--downloadautomatically download necessary files if possible
(default)
--no-download do not download anything
--save-downloads DIR save downloaded files to DIR, and look for files there
--search look for installed files in Steam and other likely
places (default)
--no-search only look in paths provided on the command line
packages possible for this game:
larry-docLeisure Suit Larry Hits and Misses
booklet
larry6-data Leisure Suit Larry 6: Shape Up or
Slip Out!
larry6-svga-data Leisure Suit Larry 6: Shape Up or
Slip Out!
This game can be bought online here:
https://www.gog.com/game/leisure_suit_larry?pp=22d200f8670dbdb3e253a90eee5098477c95c23d
External links:
Bug#902654: larry6: Add support for SVGA version
Control: tags -1 - pending Control: tags -1 + moreinfo On Sat, 30 Jun 2018 at 17:39:41 +0700, Рома Тенцер wrote: > File "/usr/share/games/game-data-packager/game_data_packager/build.py", > line 907, in fill_gap > fmt = provider.unpack['format'] > TypeError: 'NoneType' object is not subscriptable Fixed in git, thanks. > Also, scummvm's wiki gives this extra instructions for larry6-hires: > > >> if your game comes with a HIRES directory, copy all files from the HIRES > directory to the game directory, then copy all files from the AUD and SFX > directories to the game directory. Your make-template output has 64 files in AUD/, all of which we package, and no HIRES/ or SFX/ directory; so I think GOG have done this already? We could add these to the "svga assets" group if you think they're a good idea? * the rest of PATCHES/ * RESOURCE.CFG (but other SCI games don't seem to need that) * *.DRV files (but I think those are part of the original executable rather than game data?) * INSTALL.* (likewise) Thanks, smcv
Bug#902654: larry6: Add support for SVGA version
I tried and get an error: $ game-data-packager larry6 gog_leisure_suit_larry_6_2.0.0.1.sh --no-download identifying gog_leisure_suit_larry_6_2.0.0.1.sh Traceback (most recent call last): File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main "__main__", mod_spec) File "/usr/lib/python3.6/runpy.py", line 85, in _run_code exec(code, run_globals) File "/usr/share/games/game-data-packager/game_data_packager/command_line.py", line 365, in run_command_line() File "/usr/share/games/game-data-packager/game_data_packager/command_line.py", line 362, in run_command_line task.run_command_line(parsed) File "/usr/share/games/game-data-packager/game_data_packager/build.py", line 1698, in run_command_line requested_packages=requested_packages) File "/usr/share/games/game-data-packager/game_data_packager/build.py", line 1850, in prepare_packages log=log_immediately) not in (FillResult.IMPOSSIBLE, File "/usr/share/games/game-data-packager/game_data_packager/build.py", line 650, in fill_gaps log=(log and wanted in package.install_files)) File "/usr/share/games/game-data-packager/game_data_packager/build.py", line 907, in fill_gap fmt = provider.unpack['format'] TypeError: 'NoneType' object is not subscriptable Also, scummvm's wiki gives this extra instructions for larry6-hires: >> if your game comes with a HIRES directory, copy all files from the HIRES directory to the game directory, then copy all files from the AUD and SFX directories to the game directory. DEBUG:__main__:Arguments: ['/usr/share/games/game-data-packager/game_data_packager/command_line.py', 'larry6', 'gog_leisure_suit_larry_6_2.0.0.1.sh', '--no-download'] DEBUG:__main__:obeying PRESERVE=yes in configuration DEBUG:__main__:parsed command-line arguments into: Namespace(binary_executables=False, compress=None, demo=False, destination='.', download=False, everything=False, gain_root_command='', install=False, install_method='', packages=[], paths=['gog_leisure_suit_larry_6_2.0.0.1.sh'], save_downloads=None, search=True, shortname='larry6', target_distro='generic', target_format='deb', verbose=False) DEBUG:game_data_packager.game:loading full data DEBUG:game_data_packager.game:... /usr/share/games/game-data-packager/vfs.zip/larry6.groups DEBUG:game_data_packager.game:Adding group: assets DEBUG:game_data_packager.game:Adding group: gog packaging DEBUG:game_data_packager.game:Adding group: svga assets DEBUG:game_data_packager.game:Adding group: vga assets DEBUG:game_data_packager.game:Adding file: aud/0.map DEBUG:game_data_packager.game:Adding file: aud/130.map DEBUG:game_data_packager.game:Adding file: aud/140.map DEBUG:game_data_packager.game:Adding file: aud/190.map DEBUG:game_data_packager.game:Adding file: aud/200.map DEBUG:game_data_packager.game:Adding file: aud/205.map DEBUG:game_data_packager.game:Adding file: aud/210.map DEBUG:game_data_packager.game:Adding file: aud/230.map DEBUG:game_data_packager.game:Adding file: aud/240.map DEBUG:game_data_packager.game:Adding file: aud/250.map DEBUG:game_data_packager.game:Adding file: aud/260.map DEBUG:game_data_packager.game:Adding file: aud/270.map DEBUG:game_data_packager.game:Adding file: aud/280.map DEBUG:game_data_packager.game:Adding file: aud/300.map DEBUG:game_data_packager.game:Adding file: aud/305.map DEBUG:game_data_packager.game:Adding file: aud/310.map DEBUG:game_data_packager.game:Adding file: aud/320.map DEBUG:game_data_packager.game:Adding file: aud/330.map DEBUG:game_data_packager.game:Adding file: aud/340.map DEBUG:game_data_packager.game:Adding file: aud/350.map DEBUG:game_data_packager.game:Adding file: aud/360.map DEBUG:game_data_packager.game:Adding file: aud/370.map DEBUG:game_data_packager.game:Adding file: aud/380.map DEBUG:game_data_packager.game:Adding file: aud/390.map DEBUG:game_data_packager.game:Adding file: aud/400.map DEBUG:game_data_packager.game:Adding file: aud/410.map DEBUG:game_data_packager.game:Adding file: aud/420.map DEBUG:game_data_packager.game:Adding file: aud/430.map DEBUG:game_data_packager.game:Adding file: aud/440.map DEBUG:game_data_packager.game:Adding file: aud/460.map DEBUG:game_data_packager.game:Adding file: aud/500.map DEBUG:game_data_packager.game:Adding file: aud/505.map DEBUG:game_data_packager.game:Adding file: aud/510.map DEBUG:game_data_packager.game:Adding file: aud/520.map DEBUG:game_data_packager.game:Adding file: aud/530.map DEBUG:game_data_packager.game:Adding file: aud/560.map DEBUG:game_data_packager.game:Adding file: aud/570.map DEBUG:game_data_packager.game:Adding file: aud/580.map DEBUG:game_data_packager.game:Adding file: aud/590.map DEBUG:game_data_packager.game:Adding file: aud/600.map DEBUG:game_data_packager.game:Adding file: aud/610.map DEBUG:game_data_packager.game:Adding file: aud/611.map DEBUG:game_data_packager.game:Adding file: aud/620.map DEBUG:game_data_packager.game:Adding file: aud/630.map DEBUG:game_data_packager.game:Adding
Bug#902654: larry6: Add support for SVGA version
On Fri, 29 Jun 2018 at 14:46:05 +0700, Рома Тенцер wrote: > scummvm 2.0 supports hi-res version of the game. A template for gog > installer is attached. Please try the version in game-data-packager git? Hopefully it works OK with the same files installed as for the VGA version. smcv
Bug#902654: larry6: Add support for SVGA version
Package: game-data-packager Version: 59 Severity: wishlist scummvm 2.0 supports hi-res version of the game. A template for gog installer is attached. --- copyright: "\xA9 1970 FIXME" files: gog_leisure_suit_larry_6_2.0.0.1.sh: provides: - contents of gog_leisure_suit_larry_6_2.0.0.1.sh - contents of gog_leisure_suit_larry_6_2.0.0.1.sh - documentation - contents of gog_leisure_suit_larry_6_2.0.0.1.sh - licenses - contents of gog_leisure_suit_larry_6_2.0.0.1.sh - optional unpack: format: zip groups: archives: group_members: | 465631999 09f667d1230974bd6321bde648de687b gog_leisure_suit_larry_6_2.0.0.1.sh contents of gog_leisure_suit_larry_6_2.0.0.1.sh: group_members: | 10445 b7901ed6f8863cee5fa743cd430c8ceb data/noarch/data/ADL.DRV 675 d519cbd80f99f4c018678a0b73aaccd9 data/noarch/data/AUD/0.MAP 108 e6c1edea1759964888541ab86e085e4e data/noarch/data/AUD/130.MAP 318 f2f7d4cf894640456bd7800bfe506e39 data/noarch/data/AUD/140.MAP 45e814d928dae857fcfe50013991eec2a8 data/noarch/data/AUD/190.MAP 724 4aecc8b0d344c48e4b23efba24823efd data/noarch/data/AUD/200.MAP 444 434d8693c49f04148d9dd4b722ec202e data/noarch/data/AUD/205.MAP 676 a2b17730abe920159e1482c1734f7a7e data/noarch/data/AUD/210.MAP 1949 af7897534de5e6024b6b7c7638b89076 data/noarch/data/AUD/230.MAP 710 be12369e3684de2216d8a7a681ca27b6 data/noarch/data/AUD/240.MAP 925 9a1a1e0a0712d74cd92d2fe98c38fffa data/noarch/data/AUD/250.MAP 52a072b3accaefbc4ecd644ddcbd3d725d data/noarch/data/AUD/260.MAP 269 ca3d6ec3e4893d1e56504cea88c03c3c data/noarch/data/AUD/270.MAP 437 a41a7ad7cde0d627c903915673c6f2ec data/noarch/data/AUD/280.MAP 115 03a321f89795ed2fd63f794c0e7b2070 data/noarch/data/AUD/300.MAP 227 38fd797793977fb25a2075ef03b049a6 data/noarch/data/AUD/305.MAP 1242 8d1cb8070644cc613db56d7b90d4eb5a data/noarch/data/AUD/310.MAP 612 213e88a30637b42d278492a8dc97c73a data/noarch/data/AUD/320.MAP 1767 9b213006eefb11cb67e82c16df7f8185 data/noarch/data/AUD/330.MAP 409 efd1d329d74e31d20031131942a5ace7 data/noarch/data/AUD/340.MAP 507 4c6509ed99b62e1a8cf4838cfd454152 data/noarch/data/AUD/350.MAP 807b46d4f311afb8befd689ccc34991174 data/noarch/data/AUD/360.MAP 696 5d4a3699d8aa44c03020d99dc2cacddd data/noarch/data/AUD/370.MAP 521 031cefba0287c944f5224beb7a64ed1d data/noarch/data/AUD/380.MAP 771 5dc946ae8b34d33fcc16adb4de17a72a data/noarch/data/AUD/390.MAP 773 7a092f04a5c2a8551a270a775bed8a1d data/noarch/data/AUD/400.MAP 1078 a274831e5b31a70cd66b6d347bf4 data/noarch/data/AUD/410.MAP 521 0653f6f4fd9806fc105eeb8a144cb296 data/noarch/data/AUD/420.MAP 940 763350495edfe7bd1c94122fd6ace1a7 data/noarch/data/AUD/430.MAP 465 c39d4df27a0ce6b4a6d8d34de6762dca data/noarch/data/AUD/440.MAP 635 65644aca79b63bac1635627e192c8d50 data/noarch/data/AUD/460.MAP 6691e9263bd4fc31f48fdb0839192b9990 data/noarch/data/AUD/500.MAP 276 6f4194b507a8bde4a8fb3d6d670932f4 data/noarch/data/AUD/505.MAP 1410 941e810f0c5cc4a32a10da1f46cf4219 data/noarch/data/AUD/510.MAP 567 5de46fab5f8b7f49b48ffef07e53e28d data/noarch/data/AUD/520.MAP 311 417c22d4f2a953cf55a9e4476830880a data/noarch/data/AUD/530.MAP 570 dbd8a3d2125c4723d08fd1ca5a2f2843 data/noarch/data/AUD/560.MAP 9478b7f7d93993a5169c50dccd1d2e91ae data/noarch/data/AUD/570.MAP 297 6264218504cc6b2d8a05dbe5d631a6b8 data/noarch/data/AUD/580.MAP 630 79c032c062e89cff84ce76458daa659a data/noarch/data/AUD/590.MAP 703 9538062ad379d995c0980c068ebde1d1 data/noarch/data/AUD/600.MAP 1424 277fd769a170e0a5d42984f40fbaae4a data/noarch/data/AUD/610.MAP 451 d85dd0022c4e3a4d72909712ce3516e7 data/noarch/data/AUD/611.MAP 885 0df965db5569106a75adf3b49e9f9411 data/noarch/data/AUD/620.MAP 1249 1c8fe48594deb8df8970988815f28842 data/noarch/data/AUD/630.MAP 150 f0422e53a0459f140977551d8c911247 data/noarch/data/AUD/640.MAP 171 8307ebca7c355e86ba57167b64553ebe data/noarch/data/AUD/650.MAP 185 d47bbbcecedaf93987378dca76c62d3c data/noarch/data/AUD/660.MAP 101 16f5269e90ce1688a3fe8fa30065fd52 data/noarch/data/AUD/680.MAP 94d26b365f744ca24c653197ea769e55de data/noarch/data/AUD/690.MAP 276 abfd10e7ddd8461241b7dde5931ebdd4 data/noarch/data/AUD/700.MAP 234 bbbe81f88658d76468c38646e4201eea data/noarch/data/AUD/710.MAP 1664 9b1db90814a6e56e20ee6b6cb006 data/noarch/data/AUD/720.MAP 24d2ccfe3683474777ea8b554e9ba6986e data/noarch/data/AUD/740.MAP 290 f4cbb38f6581db085b3d909d523a2322
