Bug#903491: marble: OSM Address Lookup Broken
I wanted to report that the patch submitted by Adrien worked for me after I rebuilt the debs. If anybody doesn't want to wait for the official bug fix release, and wants to contact me directly, I can provide the rebuilt debs.
Bug#903491: [marble]
Package: marble
Version: 4:17.08.3-3
--- Please enter the report below this line. ---
Upstream bug: https://bugs.kde.org/show_bug.cgi?id=394517
So nobody has proposed something yet. Since contributing to Marble is a
bit complicated (I don't have any account for now), here is a small patch.
Adrien
--- System information. ---
Architecture:
Kernel: Linux 4.16.0-2-amd64
Debian Release: buster/sid
500 unstable ftp.fr.debian.org
500 testing download.jitsi.org
1 experimental ftp.fr.debian.org
--- Package information. ---
Depends (Version) | Installed
===-+-=
marble-data (>= 4:17.08.3-3) | 4:17.08.3-3
marble-plugins (= 4:17.08.3-3) | 4:17.08.3-3
kio | 5.47.0-1
libc6 (>= 2.14) | 2.27-4
libgcc1 (>= 1:3.0) | 1:8.1.0-9
libkf5configcore5 (>= 4.98.0) | 5.47.0-1
libkf5configgui5 (>= 4.97.0) | 5.47.0-1
libkf5configwidgets5 (>= 4.96.0) | 5.47.0-1
libkf5coreaddons5 (>= 4.100.0) | 5.47.0-1
libkf5crash5 (>= 4.96.0) | 5.47.0-1
libkf5i18n5 (>= 4.97.0) | 5.47.0-1
libkf5kiowidgets5 (>= 4.99.0) | 5.47.0-1
libkf5newstuff5 (>= 4.95.0) | 5.47.0-1
libkf5parts5 (>= 4.96.0) | 5.47.0-1
libkf5widgetsaddons5 (>= 4.96.0) | 5.47.0-1
libkf5xmlgui5 (>= 4.98.0) | 5.47.0-1
libmarblewidget-qt5-28 (= 4:17.08.3-3) | 4:17.08.3-3
libqt5core5a (>= 5.9.0~beta) | 5.10.1+dfsg-7
libqt5dbus5 (>= 5.4) | 5.10.1+dfsg-7
libqt5gui5 (>= 5.7.0) | 5.10.1+dfsg-7
libqt5network5 (>= 5.4) | 5.10.1+dfsg-7
libqt5printsupport5 (>= 5.4) | 5.10.1+dfsg-7
libqt5widgets5 (>= 5.4) | 5.10.1+dfsg-7
libqt5xml5 (>= 5.4) | 5.10.1+dfsg-7
libstdc++6 (>= 4.1.1) | 8.1.0-9
Package's Recommends field is empty.
Suggests (Version) | Installed
===-+-===
gosmore |
monav-routing-daemon |
routino |
Index: marble-17.08.3/src/plugins/runner/nominatim-reversegeocoding/OsmNominatimReverseGeocodingRunner.cpp
===
--- marble-17.08.3.orig/src/plugins/runner/nominatim-reversegeocoding/OsmNominatimReverseGeocodingRunner.cpp
+++ marble-17.08.3/src/plugins/runner/nominatim-reversegeocoding/OsmNominatimReverseGeocodingRunner.cpp
@@ -49,7 +49,7 @@ void OsmNominatimRunner::returnNoReverse
void OsmNominatimRunner::reverseGeocoding( const GeoDataCoordinates )
{
m_coordinates = coordinates;
-QString base = "http://nominatim.openstreetmap.org/reverse?format=xml=1;;
+QString base = "https://nominatim.openstreetmap.org/reverse?format=xml=1;;
// @todo: Alternative URI with addressdetails=1 could be used for shorther placemark name
QString query = "=%1=%2=%3";
double lon = coordinates.longitude( GeoDataCoordinates::Degree );
Index: marble-17.08.3/src/plugins/runner/nominatim-search/OsmNominatimSearchRunner.cpp
===
--- marble-17.08.3.orig/src/plugins/runner/nominatim-search/OsmNominatimSearchRunner.cpp
+++ marble-17.08.3/src/plugins/runner/nominatim-search/OsmNominatimSearchRunner.cpp
@@ -50,7 +50,7 @@ void OsmNominatimRunner::returnNoResults
void OsmNominatimRunner::search( const QString , const GeoDataLatLonBox )
{
-QString base = "http://nominatim.openstreetmap.org/search?;;
+QString base = "https://nominatim.openstreetmap.org/search?;;
QString query = "q=%1=xml=1=%2";
QString url = QString(base + query).arg(searchTerm).arg(MarbleLocale::languageCode());
if( !preferred.isEmpty() ) {
Bug#903491: marble: OSM Address Lookup Broken
Package: marble Version: 4:16.08.3-1 Severity: important Dear Maintainer, KDE Marble in Stretch used to be able to do searches on addresses or partial city names, which I believe was using the Open Street Map API. This functionality seems to have broken in the last few months, but I do not know exactly when. E.g., one could type "1600 Pennsylvania Avenue" in the search box, hit enter, and it would give a list of all places containing that address. If I launch Marble from the command prompt, and attempt these sorts of searches, I see an error "Cannot parse osm nominatim result", suggesting something has changed in the OSM API. I do not have time to experiment with a newer version of Marble, but I wouldn't be surprised if this hasn't been fixed upstream and the change just needs to be backported. Note: The search box auto-complete API still seems to work, although only major city names are auto-completed. -- System Information: Debian Release: 9.4 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 4.9.0-6-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages marble depends on: ii kio 5.28.0-2 ii libc6 2.24-11+deb9u3 ii libgcc1 1:6.3.0-18+deb9u1 ii libkf5configcore5 5.28.0-2 ii libkf5configgui55.28.0-2 ii libkf5configwidgets55.28.0-2 ii libkf5coreaddons5 5.28.0-2 ii libkf5i18n5 5.28.0-2 ii libkf5kiowidgets5 5.28.0-2 ii libkf5newstuff5 5.28.0-1 ii libkf5parts55.28.0-1 ii libkf5runner5 5.28.0-1 ii libkf5widgetsaddons55.28.0-3 ii libkf5xmlgui5 5.28.0-1 ii libmarblewidget-qt5-25 4:16.08.3-1 ii libqt5core5a5.7.1+dfsg-3+b1 ii libqt5dbus5 5.7.1+dfsg-3+b1 ii libqt5gui5 5.7.1+dfsg-3+b1 ii libqt5network5 5.7.1+dfsg-3+b1 ii libqt5printsupport5 5.7.1+dfsg-3+b1 ii libqt5widgets5 5.7.1+dfsg-3+b1 ii libqt5xml5 5.7.1+dfsg-3+b1 ii libstdc++6 6.3.0-18+deb9u1 ii marble-data 4:16.08.3-1 ii marble-plugins 4:16.08.3-1 marble recommends no packages. Versions of packages marble suggests: pn gosmore pn monav-routing-daemon pn routino -- no debconf information
