Bug#904250: RFS - golang-github-ulule-limiter - don't skip all tests
On Sun, 29 Jul 2018 Paride Legovini wrote: > Alexandre Viau wrote on 29/07/2018: > > On 2018-07-29 04:58 AM, Julien Rouhaud wrote: > >> I just noticed that the s/MIT/Expat/ in 1a37607957 also modified > >> LIMITED. I'm new here so unfortunately I don't know if I should do > >> more than this email. > > > > That would be important to fix. > > > > I have prepared and uploaded a new version, there is else nothing to do! > > That's annoying. Thanks to you both for noticing and fixing. I meant my typo, not your fixup, of course. > Alexandre: sure you have noticed that 2.2.0-1 has already been accepted > into unstable. Maybe before uploading 2.2.0-2 let's check if everything > goes fine with 2.2.0-1. If it doesn't we can then make an upload that > fixes more than one thing. I now see 2.2.0-2 is already pending. Well, nevermind then. Cheers! Paride
Bug#904250: RFS - golang-github-ulule-limiter - don't skip all tests
Alexandre Viau wrote on 29/07/2018: > On 2018-07-29 04:58 AM, Julien Rouhaud wrote: >> I just noticed that the s/MIT/Expat/ in 1a37607957 also modified >> LIMITED. I'm new here so unfortunately I don't know if I should do >> more than this email. > > That would be important to fix. > > I have prepared and uploaded a new version, there is else nothing to do! That's annoying. Thanks to you both for noticing and fixing. Alexandre: sure you have noticed that 2.2.0-1 has already been accepted into unstable. Maybe before uploading 2.2.0-2 let's check if everything goes fine with 2.2.0-1. If it doesn't we can then make an upload that fixes more than one thing. Thanks for sponsoring the packages. Paride
Bug#904250: RFS - golang-github-ulule-limiter - don't skip all tests
On Sun, Jul 29, 2018 at 11:47 AM, Alexandre Viau wrote: > On 2018-07-29 04:58 AM, Julien Rouhaud wrote: >> I just noticed that the s/MIT/Expat/ in 1a37607957 also modified >> LIMITED. I'm new here so unfortunately I don't know if I should do >> more than this email. > > That would be important to fix. > > I have prepared and uploaded a new version, there is else nothing to do! > > It is fine to upload several versions of the same package in NEW. > > ftpmasters will usually consider only the last, they can also accept > only one version if needed. > > If you make a mistake and realize that you don't have the time to fix > it, you can mail the ftpmasters and ask them to reject your package. > This will ensure that they don't waste time reviewing something that > they won't accept anyways. > > in this case, just making another upload is more than enough. > > Good job noticing it. Thanks a lot for all those informations!
Bug#904250: RFS - golang-github-ulule-limiter - don't skip all tests
On 2018-07-29 04:58 AM, Julien Rouhaud wrote: > I just noticed that the s/MIT/Expat/ in 1a37607957 also modified > LIMITED. I'm new here so unfortunately I don't know if I should do > more than this email. That would be important to fix. I have prepared and uploaded a new version, there is else nothing to do! It is fine to upload several versions of the same package in NEW. ftpmasters will usually consider only the last, they can also accept only one version if needed. If you make a mistake and realize that you don't have the time to fix it, you can mail the ftpmasters and ask them to reject your package. This will ensure that they don't waste time reviewing something that they won't accept anyways. in this case, just making another upload is more than enough. Good job noticing it. Cheers, -- Alexandre Viau av...@debian.org signature.asc Description: OpenPGP digital signature
Bug#904250: RFS - golang-github-ulule-limiter - don't skip all tests
Hi, On Sun, Jul 29, 2018 at 7:52 AM, Alexandre Viau wrote: > On 2018-07-28 05:49 AM, Paride Legovini wrote: >> Alexandre Viau wrote on 28/07/2018: >> [...] >> I think I've found a better way to skip that test, without patching. >> Please check my last commits when you have time. > > This is clever, good work. > > Uploaded :) I just noticed that the s/MIT/Expat/ in 1a37607957 also modified LIMITED. I'm new here so unfortunately I don't know if I should do more than this email.
Bug#904250: RFS - golang-github-ulule-limiter - don't skip all tests
On 2018-07-28 05:49 AM, Paride Legovini wrote: > Alexandre Viau wrote on 28/07/2018: >> Hello, >> >> I have noticed that you skip all tests in golang-github-ulule-limiter. >> >> However, there is only two tests that require redis. >> >> I think that it would be best to skip only these two tests. >> >> You can simply write a patch that adds t.Skip() to these tests. > Hello Alexandre, > > I think I've found a better way to skip that test, without patching. > Please check my last commits when you have time. This is clever, good work. Uploaded :) -- Alexandre Viau av...@debian.org signature.asc Description: OpenPGP digital signature
Bug#904250: RFS - golang-github-ulule-limiter - don't skip all tests
Alexandre Viau wrote on 28/07/2018: > Hello, > > I have noticed that you skip all tests in golang-github-ulule-limiter. > > However, there is only two tests that require redis. > > I think that it would be best to skip only these two tests. > > You can simply write a patch that adds t.Skip() to these tests. Hello Alexandre, I think I've found a better way to skip that test, without patching. Please check my last commits when you have time. Cheers, Paride signature.asc Description: OpenPGP digital signature
Bug#904250: RFS - golang-github-ulule-limiter - don't skip all tests
Hello, I have noticed that you skip all tests in golang-github-ulule-limiter. However, there is only two tests that require redis. I think that it would be best to skip only these two tests. You can simply write a patch that adds t.Skip() to these tests. Cheers, -- Alexandre Viau av...@debian.org signature.asc Description: OpenPGP digital signature
