Bug#906284: CC0 is short

[Julien Puydt]

Hi,

On 27/08/2018 19:09, Chris Lamb wrote:


Thanks for that. Do you happen to have some "bad" ones handy too?


I don't have anything handy, but I remembered : when I packaged 
minetest-mod-unified-inventory and found it used CC0, I used 
codesearch.debian.net, to find other packages where CC0 was used.


So perhaps it's possible to use codesearch.d.n to find bad examples too, 
by looking at a known-wrong expression in path:debian/copyright? I 
naively searched "only some of the key features" and "not a license and 
has no legal value" found only the source of the lintian check in which 
I already took the words anyway.


Does that check actually detect anything?

jpuydt on irc.debian.org

Bug#906284: CC0 is short

[Chris Lamb]

Hi Julian,

> I hope I have found the right place to apply it

I appear to have confused you, apologies. I am prepared to make this
change myself, I am only looking for example license texts that should
and should not trigger this.

> > Apply to apply this, but before I do can you supply some "known good"
^

This should have read "Happy to apply this."

Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#906284: CC0 is short

[Julian Gilbey]

On Mon, Aug 27, 2018 at 02:36:34PM +0100, Chris Lamb wrote:
> Julian et al.,
> 
> > if ($full_license and $short_license =~ m/cc-/) {
> > if ($full_license !~ /definitions/i and
> > $full_license !~ /copyright and related rights/i and
> > $full_license !~ m%/usr/share/common-licenses/CC) {
> > tag 'incomplete-creative-commons-license';
> > }
> > }
> 
> Apply to apply this, but before I do can you supply some "known good"
> and "known bad" texts? That way I can supplement our testsuite..

I hope I have found the right place to apply it - I haven't read the
lintian code that carefully, and it may be that there's a better
approach.

Anyway, remind me next week if no-one else has done it and I'll write
some; it's a little difficult for me to do it this week.

Best wishes,

   Julian

Bug#906284: CC0 is short

[Chris Lamb]

Hi Julien,

> > Apply to apply this, but before I do can you supply some "known good"
> > and "known bad" texts? That way I can supplement our testsuite..
> > 
> > best wishes,
> 
> I'm not 100% sure my test is "known good", but here it is:
[…]

Thanks for that. Do you happen to have some "bad" ones handy too?


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#906284: CC0 is short

[Julien Puydt]

On 27/08/2018 15:36, Chris Lamb wrote:

Julian et al.,


if ($full_license and $short_license =~ m/cc-/) {
 if ($full_license !~ /definitions/i and
 $full_license !~ /copyright and related rights/i and
 $full_license !~ m%/usr/share/common-licenses/CC) {
 tag 'incomplete-creative-commons-license';
 }
}


Apply to apply this, but before I do can you supply some "known good"
and "known bad" texts? That way I can supplement our testsuite..

best wishes,


I'm not 100% sure my test is "known good", but here it is:

License: CC0
 To the extent possible under law, the author(s) have dedicated all 
copyright

 and related and neighboring rights to this software to the public domain
 worldwide. This software is distributed without any warranty.
 .
 You should have received a copy of the CC0 Public Domain Dedication 
along with
 this software. If not, see 
.


Cheers,

jpuydt on irc.debian.org

Bug#906284: CC0 is short

[Chris Lamb]

Julian et al.,

> if ($full_license and $short_license =~ m/cc-/) {
> if ($full_license !~ /definitions/i and
> $full_license !~ /copyright and related rights/i and
> $full_license !~ m%/usr/share/common-licenses/CC) {
> tag 'incomplete-creative-commons-license';
> }
> }

Apply to apply this, but before I do can you supply some "known good"
and "known bad" texts? That way I can supplement our testsuite..


best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#906284: CC0 is short

[Julian Gilbey]

On Sat, Aug 25, 2018 at 10:32:55AM +0200, Julien Puydt wrote:
> Hi,
> 
> the following also triggers the check, and I think it's a false positive,
> and would still be even with the proposed change:
> 
> License: CC0

Indeed - good catch.  We have to treat CC0 differently, as it's got
different license wording and it also appears in
/usr/share/common-licenses.  How about the following then:

if ($full_license and $short_license =~ m/cc-/) {
if ($full_license !~ /definitions/i and
$full_license !~ /copyright and related rights/i and
$full_license !~ m%/usr/share/common-licenses/CC) {
tag 'incomplete-creative-commons-license';
}
}

Best wishes,

   Julian

Bug#906284: CC0 is short

[Julien Puydt]

Hi,

the following also triggers the check, and I think it's a false 
positive, and would still be even with the proposed change:


License: CC0
 To the extent possible under law, the author(s) have dedicated all 
copyright

 and related and neighboring rights to this software to the public domain
 worldwide. This software is distributed without any warranty.
 .
 You should have received a copy of the CC0 Public Domain Dedication 
along with
 this software. If not, see 
.



If it's legit, I'll fix :-)

Cheers,

jpuydt on irc.debian.org