Bug#907258: Bug#907259: Bug#907258: Bug#907259: Bug#907258: Bug#907259: Bug#907258: Bug#907259: hiredis: New upstream "release" ?

[Chris Lamb]

tags 907259 + pending
thanks

Hi Tom,

> > Hm, why don't you just fix these?
> 
> Time, mostly. Was expecting not to be available for a while, but had some
> spare time today to wrap it up.

Great stuff; uploaded:

Uploading hiredis_0.14.0-1.dsc
Uploading hiredis_0.14.0.orig.tar.gz
Uploading hiredis_0.14.0-1.debian.tar.xz
Uploading hiredis_0.14.0-1_amd64.buildinfo
Uploading libhiredis-dev_0.14.0-1_amd64.deb
Uploading libhiredis0.14-dbgsym_0.14.0-1_amd64.deb
Uploading libhiredis0.14_0.14.0-1_amd64.deb
Uploading hiredis_0.14.0-1_amd64.changes


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#907258: Bug#907259: Bug#907258: Bug#907259: Bug#907258: Bug#907259: Bug#907258: Bug#907259: hiredis: New upstream "release" ?

[Tom Lee]

On Thu, Sep 27, 2018 at 2:21 AM Chris Lamb  wrote:

> Hi Tom,
>
> > Otherwise it should be fine aside from a few gripes from the pedantic
> > lintian checks.
>
> Hm, why don't you just fix these?


Time, mostly. Was expecting not to be available for a while, but had some
spare time today to wrap it up.

One outstanding lint check I'm not sure if I should be actioning yet:

P: hiredis source: debug-symbol-migration-possibly-complete
> --dbgsym-migration='libhiredis-dbg (line 37)
>

I should leave that one be until after this upload, right?


> Also, before I upload please could
> you address:
>
>  * Use compat level 11.
>
>  * Add  to the relevant build-dependencies.
>
>  * Drop unnecessary cruft (DEB_DESTDIR, "#export DH_VERBOSE=1" etc.
>etc.)
>
>
Should be all done.

Of note:

   - Haven't used the build profile stuff before, hopefully I'm doing it
   right.
   - I think dh_fixperms (or something else independent of the build) may
   be marking .pc/.cmake files under usr/lib, so had to work around that in
   override_dh_fixperms. Not sure if there's a better way.
   - No GPG signatures available upstream, so added a lintian override for
   that for now.

Cheers,
Tom
-- 
*Tom Lee */ http://tomlee.co / @tglee 

Bug#907258: Bug#907259: Bug#907258: Bug#907259: Bug#907258: Bug#907259: hiredis: New upstream "release" ?

[Chris Lamb]

Hi Tom,

> Otherwise it should be fine aside from a few gripes from the pedantic
> lintian checks.

Hm, why don't you just fix these? Also, before I upload please could
you address:

 * Use compat level 11.

 * Add  to the relevant build-dependencies.

 * Drop unnecessary cruft (DEB_DESTDIR, "#export DH_VERBOSE=1" etc.
   etc.) 

Thanks!


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#907258: Bug#907259: Bug#907258: Bug#907259: Bug#907258: Bug#907259: hiredis: New upstream "release" ?

[Tom Lee]

Phew, done: https://github.com/thomaslee/hiredis-debian

Note because of the SONAME change / API & ABI breakage the binary package
name changed from libhiredis0.13 to libhiredis0.14. Can't recall exactly
how to handle that ... I was tempted to add Breaks/Replaces stanzas to
debian/control but thought better of it. Let me know if I need to take any
action there.

Otherwise it should be fine aside from a few gripes from the pedantic
lintian checks.

Cheers,
Tom

On Wed, Sep 26, 2018 at 1:21 AM Chris Lamb  wrote:

> Hi Tom,
>
> Great stuff.
>
> > Would you be willing to sponsor the upload when it's ready
>
> Gladly. Please either send me a HTTP-accessible link to a .dsc that works
> with "dget" or a pointer to a git-buildpackage repository when you are
> ready for me to have a look at this.
>
>
> Best wishes,
>
> --
>   ,''`.
>  : :'  : Chris Lamb
>  `. `'`  la...@debian.org / chris-lamb.co.uk
>`-
>


-- 
*Tom Lee */ http://tomlee.co / @tglee 

Bug#907259: Bug#907258: Bug#907259: Bug#907258: Bug#907259: hiredis: New upstream "release" ?

[Chris Lamb]

Hi Tom,

Great stuff.

> Would you be willing to sponsor the upload when it's ready

Gladly. Please either send me a HTTP-accessible link to a .dsc that works
with "dget" or a pointer to a git-buildpackage repository when you are
ready for me to have a look at this.


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#907258: Bug#907259: Bug#907258: Bug#907259: hiredis: New upstream "release" ?

[Tom Lee]

Hey again Chris,

Quick update: we've got a 0.14.0 release from upstream that I think should
be compatible with redis. Patches updated, test suite is passing & now I've
just got a few lintian headaches to work through. Should have a new release
for you in the next day or two.

Would you be willing to sponsor the upload when it's ready, or should I
reach out to somebody else?

On Mon, Sep 24, 2018 at 2:26 PM Tom Lee  wrote:

> Works for me.
>
> On Mon, Sep 24, 2018 at 2:21 PM Chris Lamb  wrote:
>
>> Hi Tom,
>>
>> > So if you don't mind waiting a little longer to see where upstream
>> hiredis
>> > #609 lands that'd be awesome
>>
>> Mmm, although let's not wait too long. I've replied to the issue (which
>> already has had one reply) so we'll see how it looks by this weekend...?
>>
>>
>> Best wishes,
>>
>> --
>>   ,''`.
>>  : :'  : Chris Lamb
>>  `. `'`  la...@debian.org / chris-lamb.co.uk
>>`-
>>
>
>
> --
> *Tom Lee */ http://tomlee.co / @tglee 
>
>

-- 
*Tom Lee */ http://tomlee.co / @tglee 

Bug#907258: Bug#907259: Bug#907258: Bug#907259: hiredis: New upstream "release" ?

[Tom Lee]

Works for me.

On Mon, Sep 24, 2018 at 2:21 PM Chris Lamb  wrote:

> Hi Tom,
>
> > So if you don't mind waiting a little longer to see where upstream
> hiredis
> > #609 lands that'd be awesome
>
> Mmm, although let's not wait too long. I've replied to the issue (which
> already has had one reply) so we'll see how it looks by this weekend...?
>
>
> Best wishes,
>
> --
>   ,''`.
>  : :'  : Chris Lamb
>  `. `'`  la...@debian.org / chris-lamb.co.uk
>`-
>


-- 
*Tom Lee */ http://tomlee.co / @tglee 

Bug#907258: Bug#907259: Bug#907258: Bug#907259: hiredis: New upstream "release" ?

[Chris Lamb]

Hi Tom,

> So if you don't mind waiting a little longer to see where upstream hiredis
> #609 lands that'd be awesome

Mmm, although let's not wait too long. I've replied to the issue (which
already has had one reply) so we'll see how it looks by this weekend...?


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#907258: Bug#907259: Bug#907258: Bug#907259: hiredis: New upstream "release" ?

[Tom Lee]

Back up and running again Chris, thanks for your patience!

After poking around in diffs between 0.13.3 and master for a bit, I raised
a ticket upstream to see if we can get a "real" release:
https://github.com/redis/hiredis/issues/609

I'd really prefer to see a real release than to go yanking from an
arbitrary SHA -- even if it is a relatively slow-moving code base. No doubt
as time goes on we can expect redis & hiredis to slowly diverge again, but
it would be nice to keep things sane for good citizens targeting a specific
version number.

So if you don't mind waiting a little longer to see where upstream hiredis
#609 lands that'd be awesome. On the other hand, if you're really desperate
for the phony release let me know & I'll figure it out.