Source: gnome-packagekit
Version: 3.28.0-2
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

Hi,

It is super nice that you think of tagging Build-Depends with <!nocheck>
where appropriate. Unfortunately, it doesn't quite work that way yet. A
nocheck build fails finding xvfb-run. If you run "xvfb-run
dh_auto_test", dh_auto_test checks whether checks are disabeld in an
environment provided by xvfb-run. So to actually make xvfb optional, you
must check DEB_BUILD_OPTIONS yourself. Please consider applying the
attached patch.

Helmut
diff --minimal -Nru gnome-packagekit-3.28.0/debian/changelog 
gnome-packagekit-3.28.0/debian/changelog
--- gnome-packagekit-3.28.0/debian/changelog    2018-03-17 23:23:02.000000000 
+0100
+++ gnome-packagekit-3.28.0/debian/changelog    2018-08-27 06:06:46.000000000 
+0200
@@ -1,3 +1,10 @@
+gnome-packagekit (3.28.0-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Only run xvfb, when it is available. (Closes: #-1)
+
+ -- Helmut Grohne <hel...@subdivi.de>  Mon, 27 Aug 2018 06:06:46 +0200
+
 gnome-packagekit (3.28.0-2) unstable; urgency=medium
 
   * Update 01_prefer-software-properties.patch to also prefer update-manager
diff --minimal -Nru gnome-packagekit-3.28.0/debian/rules 
gnome-packagekit-3.28.0/debian/rules
--- gnome-packagekit-3.28.0/debian/rules        2018-03-17 23:23:02.000000000 
+0100
+++ gnome-packagekit-3.28.0/debian/rules        2018-08-27 06:06:44.000000000 
+0200
@@ -28,7 +28,9 @@
        dh_missing --fail-missing
 
 override_dh_auto_test:
+ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),)
        xvfb-run dh_auto_test
+endif
 
 override_dh_installdocs:
        dh_installdocs

Reply via email to