Bug#908094: i3lock-fancy: new upstream version

[Simon Désaulniers]

Hi Brian,

Sorry for the small response delay. ;) This is my only Debian package and I have
let things go for a while now. I'm trying to get back on this.

> Maybe. However it is probably not a bug in xss-lock... How would you
> phrase such a question?

I'm not sure. :D

According to the upstream's README file, they're supposed to "pick" the changes
from master to the `dualmonitor` branch (see [1]), so I think that you should
try to propose the change there at least, i.e. make a pull request onto the
`dualbranch` over the upsteam repository.

However, since this change is really deal breaker for you (and some others using
xss-lock) and since upstream doesn't do much to advance development of the
`dualmonitor` branch, then I think that we should include your patch in the
meantime. I have tested it and it works nicely for me. The only thing bothering
me is that it takes one additional second to spawn the script (I tested with
`time` multiple times on both versions). Anyway, that's not too bad, I guess.

I'll upload the change shortly and close this issue.

[1]: https://github.com/meskarune/i3lock-fancy#multiple-monitors

Le lun. 10 sept. 2018, à 18 h 12, Brian May  a écrit :

> Simon Désaulniers  writes:
>
> > Noted. May be that would be worth to formulate as a question to 
> xss-lock's
> > upstream too?
>
> Maybe. However it is probably not a bug in xss-lock... How would you
> phrase such a question?
> -- 
> Brian May 
>
Le lun. 10 sept. 2018, à 18 h 12, Brian May  a écrit :Simon Désaulniers  writes:

> Noted. May be that would be worth to formulate as a question to xss-lock's
> upstream too?

Maybe. However it is probably not a bug in xss-lock... How would you
phrase such a question?
-- 
Brian May 



signature.asc
Description: PGP signature

Bug#908094: i3lock-fancy: new upstream version

[Brian May]

Simon Désaulniers  writes:

> Noted. May be that would be worth to formulate as a question to xss-lock's
> upstream too?

Maybe. However it is probably not a bug in xss-lock... How would you
phrase such a question?
-- 
Brian May 

Bug#908094: i3lock-fancy: new upstream version

[Simon Désaulniers]

Hi,

On Thu, Sep 06, 2018 at 04:37:21PM +1000, Brian May wrote:
> Simon Désaulniers  writes:
> 
> > Unless there are important issues concerning this request, I don't
> > think that we should do that for reasons I mentionned above. Please,
> > feel free to respond if I'm missing something important.
> 
> :-(
> 
> Would you consider this patch? Seems that upstream use "import" not
> instead of "scrot" (despite documentation saying otherwise).

I will look into it soon.

> For reasons I don't fully comprehend, scrot when called from xss-lock
> always produces a black bitmap, but after this change it works fine.

Noted. May be that would be worth to formulate as a question to xss-lock's
upstream too?

> 
> --- /usr/bin/i3lock-fancy 2018-01-26 15:54:36.0 +1100
> +++ bin/lock.sh   2018-09-06 16:29:53.025279474 +1000
> @@ -49,7 +49,7 @@
>  pl_* ) TEXT="Podaj hasło" ;; # Polish
>  esac
>  
> -scrot -z "$IMAGE"
> +import -window root "$IMAGE"
>  ICON="$SCRIPTPATH/lock.png"
>  PARAM=(--textcolor=ff00 --insidecolor=ff1c --ringcolor=ff3e \
> --linecolor=ff00 --keyhlcolor=0080 --ringvercolor= \
> 
> -- 
> Brian May 

-- 
Simon Désaulniers
sim.desaulni...@gmail.com


signature.asc
Description: PGP signature

Bug#908094: i3lock-fancy: new upstream version

[Brian May]

Simon Désaulniers  writes:

> Unless there are important issues concerning this request, I don't
> think that we should do that for reasons I mentionned above. Please,
> feel free to respond if I'm missing something important.

:-(

Would you consider this patch? Seems that upstream use "import" not
instead of "scrot" (despite documentation saying otherwise).

For reasons I don't fully comprehend, scrot when called from xss-lock
always produces a black bitmap, but after this change it works fine.


--- /usr/bin/i3lock-fancy   2018-01-26 15:54:36.0 +1100
+++ bin/lock.sh 2018-09-06 16:29:53.025279474 +1000
@@ -49,7 +49,7 @@
 pl_* ) TEXT="Podaj hasło" ;; # Polish
 esac
 
-scrot -z "$IMAGE"
+import -window root "$IMAGE"
 ICON="$SCRIPTPATH/lock.png"
 PARAM=(--textcolor=ff00 --insidecolor=ff1c --ringcolor=ff3e \
--linecolor=ff00 --keyhlcolor=0080 --ringvercolor= \

-- 
Brian May 

Bug#908094: i3lock-fancy: new upstream version

[Simon Désaulniers]

Hi Brian,

When I first thought about packaging i3lock-fancy, I didn't consider the program
packagable if it would not handle multiple monitors appropriately. At the time,
there was (and there still is) the "dualmonitors" branch which was giving good
results (and still does) so I decided to package it while hoping the branch
would eventually be merged.

> Actually I am somewhat confused, the Debian package seems to contain
> functionality to support multiple monitors not in upstream. Maybe this
> could be pushed upstream first?

Sadly, as you can see from upstream repository, there were multiple
attempts~[1,2,3] at merging the functionnality, but it never did.

> Version in Debian unstable is very old, please consider updating to at
> least version 0.2, the latest release.

Unless there are important issues concerning this request, I don't think that we
should do that for reasons I mentionned above. Please, feel free to respond if
I'm missing something important.

Regards,

[1]: https://github.com/meskarune/i3lock-fancy/pull/68
[2]: https://github.com/meskarune/i3lock-fancy/pull/84
[3]: https://github.com/meskarune/i3lock-fancy/pull/87

On Thu, Sep 06, 2018 at 03:41:14PM +1000, Brian May wrote:
> Package: i3lock-fancy
> Version: 0.0~git20160228.0.0fcb933-2
> Severity: wishlist
> 
> 
> Version in Debian unstable is very old, please consider updating to at
> least version 0.2, the latest release.
> 
> Actually I am somewhat confused, the Debian package seems to contain
> functionality to support multiple monitors not in upstream. Maybe this
> could be pushed upstream first?
> 
> Thanks
> 
> -- System Information:
> Debian Release: 9.5
>   APT prefers stable-updates
>   APT policy: (500, 'stable-updates'), (500, 'stable')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 4.16.0-0.bpo.2-amd64 (SMP w/4 CPU cores)
> Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), 
> LANGUAGE=en_AU.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> 
> Versions of packages i3lock-fancy depends on:
> ii  gawk 1:4.1.4+dfsg-1
> ii  i3lock   2.8-1
> ii  imagemagick  8:6.9.7.4+dfsg-11+deb9u5
> ii  imagemagick-6.q16 [imagemagick]  8:6.9.7.4+dfsg-11+deb9u5
> ii  mawk 1.3.3-17+b3
> ii  scrot0.8-18
> 
> i3lock-fancy recommends no packages.
> 
> Versions of packages i3lock-fancy suggests:
> ii  maim3.3.41-1+b1
> pn  wmctrl  
> 
> -- no debconf information

-- 
Simon Désaulniers
sim.desaulni...@gmail.com


signature.asc
Description: PGP signature

Bug#908094: i3lock-fancy: new upstream version

[Brian May]

Package: i3lock-fancy
Version: 0.0~git20160228.0.0fcb933-2
Severity: wishlist


Version in Debian unstable is very old, please consider updating to at
least version 0.2, the latest release.

Actually I am somewhat confused, the Debian package seems to contain
functionality to support multiple monitors not in upstream. Maybe this
could be pushed upstream first?

Thanks

-- System Information:
Debian Release: 9.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.16.0-0.bpo.2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages i3lock-fancy depends on:
ii  gawk 1:4.1.4+dfsg-1
ii  i3lock   2.8-1
ii  imagemagick  8:6.9.7.4+dfsg-11+deb9u5
ii  imagemagick-6.q16 [imagemagick]  8:6.9.7.4+dfsg-11+deb9u5
ii  mawk 1.3.3-17+b3
ii  scrot0.8-18

i3lock-fancy recommends no packages.

Versions of packages i3lock-fancy suggests:
ii  maim3.3.41-1+b1
pn  wmctrl  

-- no debconf information